From: Stefan Hajnoczi <stefanha@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-block@nongnu.org, hreitz@redhat.com, pkrempa@redhat.com,
peterx@redhat.com, farosas@suse.de, qemu-devel@nongnu.org
Subject: Re: [PATCH v2 03/15] migration/block-active: Remove global active flag
Date: Mon, 3 Feb 2025 13:49:48 -0500 [thread overview]
Message-ID: <20250203184948.GE268514@fedora> (raw)
In-Reply-To: <20250130171240.286878-4-kwolf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 834 bytes --]
On Thu, Jan 30, 2025 at 06:12:34PM +0100, Kevin Wolf wrote:
> Block devices have an individual active state, a single global flag
> can't cover this correctly. This becomes more important as we allow
> users to manually manage which nodes are active or inactive.
>
> Now that it's allowed to call bdrv_inactivate_all() even when some
> nodes are already inactive, we can remove the flag and just
> unconditionally call bdrv_inactivate_all() and, more importantly,
> bdrv_activate_all() before we make use of the nodes.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> migration/migration.h | 3 ---
> migration/block-active.c | 46 ----------------------------------------
> migration/migration.c | 8 -------
> 3 files changed, 57 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-02-03 18:51 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-30 17:12 [PATCH v2 00/15] block: Managing inactive nodes (QSD migration) Kevin Wolf
2025-01-30 17:12 ` [PATCH v2 01/15] block: Add 'active' field to BlockDeviceInfo Kevin Wolf
2025-01-30 19:30 ` Eric Blake
2025-02-03 18:47 ` Stefan Hajnoczi
2025-01-30 17:12 ` [PATCH v2 02/15] block: Inactivate external snapshot overlays when necessary Kevin Wolf
2025-01-30 19:46 ` Eric Blake
2025-02-03 18:48 ` Stefan Hajnoczi
2025-01-30 17:12 ` [PATCH v2 03/15] migration/block-active: Remove global active flag Kevin Wolf
2025-01-30 19:50 ` Eric Blake
2025-02-04 15:50 ` Kevin Wolf
2025-02-03 18:49 ` Stefan Hajnoczi [this message]
2025-01-30 17:12 ` [PATCH v2 04/15] block: Don't attach inactive child to active node Kevin Wolf
2025-01-30 20:08 ` Eric Blake
2025-02-03 18:50 ` Stefan Hajnoczi
2025-01-30 17:12 ` [PATCH v2 05/15] block: Allow inactivating already inactive nodes Kevin Wolf
2025-01-30 20:09 ` Eric Blake
2025-02-03 18:51 ` Stefan Hajnoczi
2025-01-30 17:12 ` [PATCH v2 06/15] block: Fix crash on block_resize on inactive node Kevin Wolf
2025-01-30 20:11 ` Eric Blake
2025-02-03 18:52 ` Stefan Hajnoczi
2025-01-30 17:12 ` [PATCH v2 07/15] block: Add option to create inactive nodes Kevin Wolf
2025-01-30 20:17 ` Eric Blake
2025-02-03 18:53 ` Stefan Hajnoczi
2025-01-30 17:12 ` [PATCH v2 08/15] block: Add blockdev-set-active QMP command Kevin Wolf
2025-01-30 20:22 ` Eric Blake
2025-02-03 18:54 ` Stefan Hajnoczi
2025-01-30 17:12 ` [PATCH v2 09/15] block: Support inactive nodes in blk_insert_bs() Kevin Wolf
2025-01-30 20:26 ` Eric Blake
2025-02-03 18:55 ` Stefan Hajnoczi
2025-01-31 9:50 ` [PATCH v2 10/15] block/export: Don't ignore image activation error in blk_exp_add() Kevin Wolf
2025-02-03 16:30 ` Eric Blake
2025-02-03 18:58 ` Stefan Hajnoczi
2025-02-04 15:54 ` Kevin Wolf
2025-01-31 9:50 ` [PATCH v2 11/15] block/export: Add option to allow export of inactive nodes Kevin Wolf
2025-01-31 13:41 ` Fabiano Rosas
2025-02-04 15:44 ` Kevin Wolf
2025-02-03 19:12 ` Eric Blake
2025-02-03 19:17 ` Stefan Hajnoczi
2025-01-31 9:50 ` [PATCH v2 12/15] nbd/server: Support " Kevin Wolf
2025-02-03 19:17 ` Eric Blake
2025-02-03 19:19 ` Stefan Hajnoczi
2025-02-04 17:10 ` Kevin Wolf
2025-01-31 9:50 ` [PATCH v2 13/15] iotests: Add filter_qtest() Kevin Wolf
2025-02-03 19:19 ` Eric Blake
2025-01-31 9:50 ` [PATCH v2 14/15] iotests: Add qsd-migrate case Kevin Wolf
2025-02-03 19:35 ` Eric Blake
2025-02-03 21:09 ` Kevin Wolf
2025-01-31 9:50 ` [PATCH v2 15/15] iotests: Add (NBD-based) tests for inactive nodes Kevin Wolf
2025-02-03 19:49 ` Eric Blake
2025-02-04 16:30 ` Kevin Wolf
2025-01-31 13:53 ` [PATCH v2 00/15] block: Managing inactive nodes (QSD migration) Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250203184948.GE268514@fedora \
--to=stefanha@redhat.com \
--cc=farosas@suse.de \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=peterx@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.