Re: [PATCH] scripts: Fix potential null-deref

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 934 bytes --]

On Mon, Feb 03, 2025 at 07:50:08PM +0300, Maks Mishin wrote:

> After having been compared to a NULL value at menu.c:799, 
> pointer 'sym' is dereferenced at menu.c:812.
> 
> Signed-off-by: Maks Mishin <maks.mishinFZ@gmail.com>
> ---
>  scripts/kconfig/menu.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
> index 0fe7f3255a..c823719dfd 100644
> --- a/scripts/kconfig/menu.c
> +++ b/scripts/kconfig/menu.c
> @@ -809,8 +809,10 @@ static void get_symbol_str(struct gstr *r, struct symbol *sym,
>  			}
>  		}
>  	}
> -	for_all_prompts(sym, prop)
> -		get_prompt_str(r, prop, head);
> +	if (sym) {
> +		for_all_prompts(sym, prop)
> +			get_prompt_str(r, prop, head);
> +	}
>  
>  	prop = get_symbol_prop(sym);
>  	if (prop) {

Has this been fixed already in the Linux Kernel, where we get this code
from? Thanks.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]