All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
	andrew+netdev@lunn.ch, horms@kernel.org
Subject: Re: [PATCH net 2/2] MAINTAINERS: add a sample ethtool section entry
Date: Tue, 4 Feb 2025 07:37:59 -0800	[thread overview]
Message-ID: <20250204073759.536531d3@kernel.org> (raw)
In-Reply-To: <8ef9275a-b5f9-45e2-a99c-096fb3213ed8@redhat.com>

On Tue, 4 Feb 2025 10:26:40 +0100 Paolo Abeni wrote:
> On 2/2/25 3:11 AM, Jakub Kicinski wrote:
> > This patch is a nop from process perspective, since Andrew already
> > is a maintainer and reviews all this code. Let's focus on discussing
> > merits of the "section entries" in abstract?  
> 
> Should the keyword be a little more generic, i.e. just 'cable_test'?
> AFAICS the current one doesn't catch the device drivers,
> 
> I agree encouraging more driver API reviewer would be great, but I
> personally have a slight preference to add/maintain entries only they
> actually affect the process.

You're right, I was going after the op name. Seems like a good default
keyword. But it appears that there are two layers of ops, one called
start_cable_test and the next cable_test_start, so this isn't catching
actual drivers.

> What about tying the creation of the entry to some specific contribution?

Sure. I'm adding this so that we have a commit to point people at 
as an example when they contribute what should be a new section.
Maybe I don't understand the question..

  reply	other threads:[~2025-02-04 15:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-02  2:11 [PATCH net 1/2] MAINTAINERS: add entry for ethtool Jakub Kicinski
2025-02-02  2:11 ` [PATCH net 2/2] MAINTAINERS: add a sample ethtool section entry Jakub Kicinski
2025-02-03 10:56   ` Simon Horman
2025-02-03 13:29     ` Andrew Lunn
2025-02-03 16:46       ` Jakub Kicinski
2025-02-04  9:39       ` Simon Horman
2025-02-04  9:26   ` Paolo Abeni
2025-02-04 15:37     ` Jakub Kicinski [this message]
2025-02-04 15:48       ` Paolo Abeni
2025-02-04 16:12       ` Andrew Lunn
2025-02-03 10:55 ` [PATCH net 1/2] MAINTAINERS: add entry for ethtool Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250204073759.536531d3@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.