From: Jakub Kicinski <kuba@kernel.org>
To: "Csókás, Bence" <csokas.bence@prolan.hu>
Cc: Laurent Badel <laurentbadel@eaton.com>,
Andrew Lunn <andrew@lunn.ch>, <imx@lists.linux.dev>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Ahmad Fatoum <a.fatoum@pengutronix.de>,
Simon Horman <horms@kernel.org>,
Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Wei Fang <wei.fang@nxp.com>, Shenwei Wang <shenwei.wang@nxp.com>,
Clark Wang <xiaoning.wang@nxp.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net v3] net: fec: Refactor MAC reset to function
Date: Tue, 4 Feb 2025 07:45:04 -0800 [thread overview]
Message-ID: <20250204074504.523c794c@kernel.org> (raw)
In-Reply-To: <20250204093756.253642-2-csokas.bence@prolan.hu>
On Tue, 4 Feb 2025 10:37:54 +0100 Csókás, Bence wrote:
> For instance, as of now, `fec_stop()` does not check for
> `FEC_QUIRK_NO_HARD_RESET`, meaning the MII/RMII mode is cleared on eg.
> a PM power-down event; and `fec_restart()` missed the refactor renaming
> the "magic" constant `1` to `FEC_ECR_RESET`.
Laurent responded to v1 saying this was intentional. Please give more
details on how problem you're seeing and on what platforms. Otherwise
this is not a fix but refactoring.
Please don't post new versions in-reply-to, and add lore links to
the previous version in the changelog.
--
pw-bot: cr
next prev parent reply other threads:[~2025-02-04 15:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-22 16:39 [PATCH] net: fec: Refactor MAC reset to function Csókás, Bence
2025-01-22 19:47 ` Jacob Keller
2025-01-23 1:24 ` Wei Fang
2025-02-04 9:37 ` [PATCH net v3] " Csókás, Bence
2025-02-04 15:45 ` Jakub Kicinski [this message]
2025-02-05 13:53 ` Csókás Bence
2025-02-06 1:06 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250204074504.523c794c@kernel.org \
--to=kuba@kernel.org \
--cc=a.fatoum@pengutronix.de \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=csokas.bence@prolan.hu \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=imx@lists.linux.dev \
--cc=jacob.e.keller@intel.com \
--cc=laurentbadel@eaton.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shenwei.wang@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.