From: kernel test robot <lkp@intel.com>
To: Angelo Dureghello <adureghello@baylibre.com>
Cc: oe-kbuild-all@lists.linux.dev,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Nuno Sa <nuno.sa@analog.com>
Subject: [jic23-iio:testing 23/47] drivers/iio/dac/adi-axi-dac.c:731 axi_dac_bus_set_io_mode() warn: always true condition '(mode >= 0) => (0-u32max >= 0)'
Date: Tue, 4 Feb 2025 07:23:39 +0800 [thread overview]
Message-ID: <202502040758.DJqHqhLO-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git testing
head: 315198c0a370da031f5c3d504b99f771a0c545ab
commit: 493122c53af1915b4b5b5f47a8c446973ebff052 [23/47] iio: dac: adi-axi-dac: add bus mode setup
config: m68k-randconfig-r071-20250204 (https://download.01.org/0day-ci/archive/20250204/202502040758.DJqHqhLO-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 14.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502040758.DJqHqhLO-lkp@intel.com/
smatch warnings:
drivers/iio/dac/adi-axi-dac.c:731 axi_dac_bus_set_io_mode() warn: always true condition '(mode >= 0) => (0-u32max >= 0)'
vim +731 drivers/iio/dac/adi-axi-dac.c
724
725 static int axi_dac_bus_set_io_mode(struct iio_backend *back,
726 enum ad3552r_io_mode mode)
727 {
728 struct axi_dac_state *st = iio_backend_get_priv(back);
729 int ival, ret;
730
> 731 if (!(mode >= AD3552R_IO_MODE_SPI && mode <= AD3552R_IO_MODE_QSPI))
732 return -EINVAL;
733
734 guard(mutex)(&st->lock);
735
736 ret = regmap_update_bits(st->regmap, AXI_DAC_CUSTOM_CTRL_REG,
737 AXI_DAC_CUSTOM_CTRL_MULTI_IO_MODE,
738 FIELD_PREP(AXI_DAC_CUSTOM_CTRL_MULTI_IO_MODE, mode));
739 if (ret)
740 return ret;
741
742 return regmap_read_poll_timeout(st->regmap, AXI_DAC_UI_STATUS_REG, ival,
743 FIELD_GET(AXI_DAC_UI_STATUS_IF_BUSY, ival) == 0, 10,
744 100 * KILO);
745 }
746
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2025-02-03 23:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 23:23 kernel test robot [this message]
2025-02-04 8:43 ` [jic23-iio:testing 23/47] drivers/iio/dac/adi-axi-dac.c:731 axi_dac_bus_set_io_mode() warn: always true condition '(mode >= 0) => (0-u32max >= 0)' Angelo Dureghello
2025-02-04 8:57 ` Jonathan Cameron
2025-02-04 9:12 ` Angelo Dureghello
2025-02-04 19:27 ` Jonathan Cameron
2025-02-08 15:10 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202502040758.DJqHqhLO-lkp@intel.com \
--to=lkp@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=adureghello@baylibre.com \
--cc=nuno.sa@analog.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.