From: Janosch Frank <frankja@linux.ibm.com>
To: kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, imbrenda@linux.ibm.com,
nrb@linux.ibm.com, hca@linux.ibm.com
Subject: [kvm-unit-tests PATCH] lib: s390x: css: Name inline assembly arguments and clean them up
Date: Tue, 4 Feb 2025 09:51:33 +0000 [thread overview]
Message-ID: <20250204100339.28158-1-frankja@linux.ibm.com> (raw)
Less need to count the operands makes the code easier to read.
Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
---
This one has been gathering dust for a while.
rfc->v1: Moved to Q constraint (thanks Heiko)
---
lib/s390x/css.h | 76 ++++++++++++++++++++++++-------------------------
1 file changed, 38 insertions(+), 38 deletions(-)
diff --git a/lib/s390x/css.h b/lib/s390x/css.h
index 504b3f14..42c5830c 100644
--- a/lib/s390x/css.h
+++ b/lib/s390x/css.h
@@ -135,11 +135,11 @@ static inline int ssch(unsigned long schid, struct orb *addr)
int cc;
asm volatile(
- " ssch 0(%2)\n"
- " ipm %0\n"
- " srl %0,28\n"
- : "=d" (cc)
- : "d" (reg1), "a" (addr), "m" (*addr)
+ " ssch %[addr]\n"
+ " ipm %[cc]\n"
+ " srl %[cc],28\n"
+ : [cc] "=d" (cc)
+ : "d" (reg1), [addr] "Q" (*addr)
: "cc", "memory");
return cc;
}
@@ -152,11 +152,11 @@ static inline int stsch(unsigned long schid, struct schib *addr)
asm volatile(
" tmll %[bogus_cc],3\n"
- " stsch 0(%3)\n"
- " ipm %0\n"
- " srl %0,28"
- : "=d" (cc), "=m" (*addr)
- : "d" (reg1), "a" (addr), [bogus_cc] "d" (bogus_cc)
+ " stsch %[addr]\n"
+ " ipm %[cc]\n"
+ " srl %[cc],28"
+ : [cc] "=d" (cc), [addr] "=Q" (*addr)
+ : "d" (reg1), [bogus_cc] "d" (bogus_cc)
: "cc");
return cc;
}
@@ -167,11 +167,11 @@ static inline int msch(unsigned long schid, struct schib *addr)
int cc;
asm volatile(
- " msch 0(%3)\n"
- " ipm %0\n"
- " srl %0,28"
- : "=d" (cc)
- : "d" (reg1), "m" (*addr), "a" (addr)
+ " msch %[addr]\n"
+ " ipm %[cc]\n"
+ " srl %[cc],28"
+ : [cc] "=d" (cc)
+ : "d" (reg1), [addr] "Q" (*addr)
: "cc");
return cc;
}
@@ -184,11 +184,11 @@ static inline int tsch(unsigned long schid, struct irb *addr)
asm volatile(
" tmll %[bogus_cc],3\n"
- " tsch 0(%3)\n"
- " ipm %0\n"
- " srl %0,28"
- : "=d" (cc), "=m" (*addr)
- : "d" (reg1), "a" (addr), [bogus_cc] "d" (bogus_cc)
+ " tsch %[addr]\n"
+ " ipm %[cc]\n"
+ " srl %[cc],28"
+ : [cc] "=d" (cc), [addr] "=Q" (*addr)
+ : "d" (reg1), [bogus_cc] "d" (bogus_cc)
: "cc");
return cc;
}
@@ -200,9 +200,9 @@ static inline int hsch(unsigned long schid)
asm volatile(
" hsch\n"
- " ipm %0\n"
- " srl %0,28"
- : "=d" (cc)
+ " ipm %[cc]\n"
+ " srl %[cc],28"
+ : [cc] "=d" (cc)
: "d" (reg1)
: "cc");
return cc;
@@ -215,9 +215,9 @@ static inline int xsch(unsigned long schid)
asm volatile(
" xsch\n"
- " ipm %0\n"
- " srl %0,28"
- : "=d" (cc)
+ " ipm %[cc]\n"
+ " srl %cc,28"
+ : [cc] "=d" (cc)
: "d" (reg1)
: "cc");
return cc;
@@ -230,9 +230,9 @@ static inline int csch(unsigned long schid)
asm volatile(
" csch\n"
- " ipm %0\n"
- " srl %0,28"
- : "=d" (cc)
+ " ipm %[cc]\n"
+ " srl %[cc],28"
+ : [cc] "=d" (cc)
: "d" (reg1)
: "cc");
return cc;
@@ -245,9 +245,9 @@ static inline int rsch(unsigned long schid)
asm volatile(
" rsch\n"
- " ipm %0\n"
- " srl %0,28"
- : "=d" (cc)
+ " ipm %[cc]\n"
+ " srl %[cc],28"
+ : [cc] "=d" (cc)
: "d" (reg1)
: "cc");
return cc;
@@ -262,9 +262,9 @@ static inline int rchp(unsigned long chpid)
asm volatile(
" tmll %[bogus_cc],3\n"
" rchp\n"
- " ipm %0\n"
- " srl %0,28"
- : "=d" (cc)
+ " ipm %[cc]\n"
+ " srl %[cc],28"
+ : [cc] "=d" (cc)
: "d" (reg1), [bogus_cc] "d" (bogus_cc)
: "cc");
return cc;
@@ -369,9 +369,9 @@ static inline int _chsc(void *p)
int cc;
asm volatile(" .insn rre,0xb25f0000,%2,0\n"
- " ipm %0\n"
- " srl %0,28\n"
- : "=d" (cc), "=m" (p)
+ " ipm %[cc]\n"
+ " srl %[cc],28\n"
+ : [cc] "=d" (cc), "=m" (p)
: "d" (p), "m" (p)
: "cc");
--
2.43.0
next reply other threads:[~2025-02-04 10:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 9:51 Janosch Frank [this message]
2025-02-04 12:55 ` [kvm-unit-tests PATCH] lib: s390x: css: Name inline assembly arguments and clean them up Nico Boehr
2025-02-05 8:17 ` Janosch Frank
2025-02-05 10:25 ` Claudio Imbrenda
2025-02-05 12:08 ` Janosch Frank
2025-02-06 10:36 ` Janosch Frank
2025-02-06 12:03 ` Claudio Imbrenda
2025-02-06 12:42 ` Nico Boehr
2025-02-06 17:22 ` Claudio Imbrenda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250204100339.28158-1-frankja@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.