From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, Kuniyuki Iwashima <kuniyu@amazon.com>,
Simon Horman <horms@kernel.org>,
eric.dumazet@gmail.com
Subject: Re: [PATCH v3 net 11/16] ipv6: input: convert to dev_net_rcu()
Date: Tue, 4 Feb 2025 12:09:03 -0800 [thread overview]
Message-ID: <20250204120903.6c616fc8@kernel.org> (raw)
In-Reply-To: <20250204132357.102354-12-edumazet@google.com>
On Tue, 4 Feb 2025 13:23:52 +0000 Eric Dumazet wrote:
> @@ -488,7 +488,7 @@ static int ip6_input_finish(struct net *net, struct sock *sk, struct sk_buff *sk
> int ip6_input(struct sk_buff *skb)
> {
> return NF_HOOK(NFPROTO_IPV6, NF_INET_LOCAL_IN,
> - dev_net(skb->dev), NULL, skb, skb->dev, NULL,
> + dev_net_rcu(skb->dev), NULL, skb, skb->dev, NULL,
> ip6_input_finish);
> }
> EXPORT_SYMBOL_GPL(ip6_input);
One more here:
[ 4326.034939][ T50] =============================
[ 4326.035125][ T50] WARNING: suspicious RCU usage
[ 4326.035299][ T50] 6.13.0-virtme #1 Not tainted
[ 4326.035955][ T50] -----------------------------
[ 4326.036124][ T50] ./include/net/net_namespace.h:404 suspicious rcu_dereference_check() usage!
[ 4326.036398][ T50]
[ 4326.036398][ T50] other info that might help us debug this:
[ 4326.036398][ T50]
[ 4326.036684][ T50]
[ 4326.036684][ T50] rcu_scheduler_active = 2, debug_locks = 1
[ 4326.036910][ T50] 2 locks held by kworker/2:1/50:
[ 4326.037111][ T50] #0: ffff8880010a9548 ((wq_completion)events){+.+.}-{0:0}, at: process_one_work+0x7ec/0x16d0
[ 4326.037439][ T50] #1: ffffc9000036fd40 ((work_completion)(&trans->work)){+.+.}-{0:0}, at: process_one_work+0xe0b/0x16d0
[ 4326.037741][ T50]
[ 4326.037741][ T50] stack backtrace:
[ 4326.037930][ T50] CPU: 2 UID: 0 PID: 50 Comm: kworker/2:1 Not tainted 6.13.0-virtme #1
[ 4326.037935][ T50] Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011
[ 4326.037937][ T50] Workqueue: events xfrm_trans_reinject
[ 4326.037947][ T50] Call Trace:
[ 4326.037949][ T50] <TASK>
[ 4326.037952][ T50] dump_stack_lvl+0xb0/0xd0
[ 4326.037963][ T50] lockdep_rcu_suspicious+0x1ea/0x280
[ 4326.037975][ T50] ip6_input+0x262/0x3e0
[ 4326.038009][ T50] xfrm_trans_reinject+0x2a2/0x460
[ 4326.038055][ T50] process_one_work+0xe55/0x16d0
[ 4326.038098][ T50] worker_thread+0x58c/0xce0
[ 4326.038121][ T50] kthread+0x359/0x5d0
[ 4326.038141][ T50] ret_from_fork+0x31/0x70
[ 4326.038150][ T50] ret_from_fork_asm+0x1a/0x30
Test output:
https://netdev-3.bots.linux.dev/vmksft-net-dbg/results/978202/61-l2tp-sh/
Decoded:
https://netdev-3.bots.linux.dev/vmksft-net-dbg/results/978202/vm-crash-thr2-0
next prev parent reply other threads:[~2025-02-04 20:09 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 13:23 [PATCH v3 net 00/16] net: first round to use dev_net_rcu() Eric Dumazet
2025-02-04 13:23 ` [PATCH v3 net 01/16] net: add dev_net_rcu() helper Eric Dumazet
2025-02-04 13:23 ` [PATCH v3 net 02/16] ipv4: add RCU protection to ip4_dst_hoplimit() Eric Dumazet
2025-02-04 13:23 ` [PATCH v3 net 03/16] ipv4: use RCU protection in ip_dst_mtu_maybe_forward() Eric Dumazet
2025-02-04 13:23 ` [PATCH v3 net 04/16] ipv4: use RCU protection in ipv4_default_advmss() Eric Dumazet
2025-02-04 13:23 ` [PATCH v3 net 05/16] ipv4: use RCU protection in rt_is_expired() Eric Dumazet
2025-02-04 13:23 ` [PATCH v3 net 06/16] tcp: convert to dev_net_rcu() Eric Dumazet
2025-02-04 13:23 ` [PATCH v3 net 07/16] net: gro: convert four dev_net() calls Eric Dumazet
2025-02-04 13:23 ` [PATCH v3 net 08/16] udp: convert to dev_net_rcu() Eric Dumazet
2025-02-04 13:23 ` [PATCH v3 net 09/16] ipv4: icmp: " Eric Dumazet
2025-02-04 13:23 ` [PATCH v3 net 10/16] ipv6: " Eric Dumazet
2025-02-04 13:23 ` [PATCH v3 net 11/16] ipv6: input: " Eric Dumazet
2025-02-04 20:09 ` Jakub Kicinski [this message]
2025-02-04 20:10 ` Eric Dumazet
2025-02-04 21:00 ` Jakub Kicinski
2025-02-04 21:06 ` Eric Dumazet
2025-02-04 21:17 ` Paul E. McKenney
2025-02-04 21:30 ` Jakub Kicinski
2025-02-04 23:25 ` Paul E. McKenney
2025-02-05 7:57 ` Eric Dumazet
2025-02-05 8:05 ` Eric Dumazet
2025-02-04 13:23 ` [PATCH v3 net 12/16] ipv6: output: " Eric Dumazet
2025-02-04 13:23 ` [PATCH v3 net 13/16] ipv6: use RCU protection in ip6_default_advmss() Eric Dumazet
2025-02-04 13:23 ` [PATCH v3 net 14/16] net: filter: convert to dev_net_rcu() Eric Dumazet
2025-02-04 13:23 ` [PATCH v3 net 15/16] flow_dissector: use rcu protection to fetch dev_net() Eric Dumazet
2025-02-04 13:23 ` [PATCH v3 net 16/16] ipv4: use RCU protection in inet_select_addr() Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250204120903.6c616fc8@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.