Re: [Buildroot] [PATCH 1/1] package/python-aiohttp-sse-client: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

On Wed, 10 Jan 2024 17:37:26 +0100
arnomessiaen@gmail.com wrote:

> From: Arno Messiaen <arnomessiaen@gmail.com>
> 
> This patch adds the python-aiohttp-sse-client package to buildroot.
> This package adds SSE client support to the aiohttp library, as
> opposed to the already exising python-aiohttp-sse package, which
> only adds sse server support.
> 
> Signed-off-by: Arno Messiaen <arnomessiaen@gmail.com>

Sorry for the delay in getting back to you. I have applied your patch
after a few changes.

However, it would be great to have a simple test for this package in
our test suite at support/testing/. Could you have a look at doing this?


> diff --git a/package/python-aiohttp-sse-client/0001-setup.py-remove-pytest-runner-requirement.patch b/package/python-aiohttp-sse-client/0001-setup.py-remove-pytest-runner-requirement.patch
> new file mode 100644
> index 0000000000..96289797f1
> --- /dev/null
> +++ b/package/python-aiohttp-sse-client/0001-setup.py-remove-pytest-runner-requirement.patch
> @@ -0,0 +1,37 @@
> +From fdba1f12843d0fdbd5094144a8081244b71b2cf0 Mon Sep 17 00:00:00 2001
> +From: Arno Messiaen <arnomessiaen@gmail.com>
> +Date: Wed, 22 Nov 2023 08:12:08 +0100
> +Subject: [PATCH] setup.py: remove pytest-runner requirement
> +
> +setup.py: pytest-runner is not required to install the package
> +

This patch lacked an "Upstream:" tag. Which in this case contains "N/A"
as this is really a Buildroot-specific packaging tweak.



> diff --git a/package/python-aiohttp-sse-client/Config.in b/package/python-aiohttp-sse-client/Config.in
> new file mode 100644
> index 0000000000..a4f6a14060
> --- /dev/null
> +++ b/package/python-aiohttp-sse-client/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_PYTHON_AIOHTTP_SSE_CLIENT
> +	bool "python-aiohttp-sse-client"
> +	select BR2_PACKAGE_PYTHON_AIOHTTP # runtime

I've added:

+       select BR2_PACKAGE_PYTHON_ATTRS # runtime
+       select BR2_PACKAGE_PYTHON_MULTIDICT # runtime
+       select BR2_PACKAGE_PYTHON_YARL # runtime

here. Indeed, while they are implied by aiohttp today, this might
change in the future, and those Python modules are directly listed in
aiohttp-sse-client's setup.py.

Thanks, applied with those changes!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot