From: Simon Horman <horms@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch
Subject: Re: [PATCH net v2 2/2] MAINTAINERS: add a sample ethtool section entry
Date: Wed, 5 Feb 2025 16:22:43 +0000 [thread overview]
Message-ID: <20250205162243.GG554665@kernel.org> (raw)
In-Reply-To: <20250204215750.169249-1-kuba@kernel.org>
On Tue, Feb 04, 2025 at 01:57:50PM -0800, Jakub Kicinski wrote:
> I feel like we don't do a good enough keeping authors of driver
> APIs around. The ethtool code base was very nicely compartmentalized
> by Michal. Establish a precedent of creating MAINTAINERS entries
> for "sections" of the ethtool API. Use Andrew and cable test as
> a sample entry. The entry should ideally cover 3 elements:
> a core file, test(s), and keywords. The last one is important
> because we intend the entries to cover core code *and* reviews
> of drivers implementing given API!
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> v2:
> - use cable_test as the keyword, looks like it doesn't produce any
> false positives
> v1: https://lore.kernel.org/20250202021155.1019222-2-kuba@kernel.org
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-02-05 16:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 21:57 [PATCH net v2 1/2] MAINTAINERS: add entry for ethtool Jakub Kicinski
2025-02-04 21:57 ` [PATCH net v2 2/2] MAINTAINERS: add a sample ethtool section entry Jakub Kicinski
2025-02-05 16:22 ` Simon Horman [this message]
2025-02-06 9:40 ` [PATCH net v2 1/2] MAINTAINERS: add entry for ethtool patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250205162243.GG554665@kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.