All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: cros-kernel-buildreports@googlegroups.com
Cc: oe-kbuild-all@lists.linux.dev
Subject: [chrome-os:chromeos-6.6 192/192] drivers/thermal/mediatek/soc_temp_lvts_mt8196.c:230:6: warning: no previous prototype for function 'lvts_wait_for_all_sensing_point_idle'
Date: Thu, 6 Feb 2025 00:58:33 +0800	[thread overview]
Message-ID: <202502060037.eHmmnb8J-lkp@intel.com> (raw)

tree:   https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-6.6
head:   1b7d37693f7bd7e9f37c02d15753e16b5bac8c79
commit: da40e24aff5b36a331b3113fa10dcc46a6cdda9b [192/192] CHROMIUM: thermal/mediatek: add thermal driver
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20250206/202502060037.eHmmnb8J-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250206/202502060037.eHmmnb8J-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502060037.eHmmnb8J-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/thermal/mediatek/soc_temp_lvts_mt8196.c:74:21: warning: variable 's_index' set but not used [-Wunused-but-set-variable]
      74 |         unsigned int i, j, s_index, msr_raw;
         |                            ^
>> drivers/thermal/mediatek/soc_temp_lvts_mt8196.c:230:6: warning: no previous prototype for function 'lvts_wait_for_all_sensing_point_idle' [-Wmissing-prototypes]
     230 | void lvts_wait_for_all_sensing_point_idle(struct lvts_data *lvts_data)
         |      ^
   drivers/thermal/mediatek/soc_temp_lvts_mt8196.c:230:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
     230 | void lvts_wait_for_all_sensing_point_idle(struct lvts_data *lvts_data)
         | ^
         | static 
   drivers/thermal/mediatek/soc_temp_lvts_mt8196.c:860:20: warning: variable 'lvts_data' set but not used [-Wunused-but-set-variable]
     860 |         struct lvts_data *lvts_data;
         |                           ^
   3 warnings generated.


vim +/lvts_wait_for_all_sensing_point_idle +230 drivers/thermal/mediatek/soc_temp_lvts_mt8196.c

   229	
 > 230	void lvts_wait_for_all_sensing_point_idle(struct lvts_data *lvts_data)
   231	{
   232		struct device *dev = lvts_data->dev;
   233		int cnt = 0, i, error_code, mask;
   234		int temp;
   235		void __iomem *base;
   236	
   237		mask = BIT(10) | BIT(7) | BIT(0);
   238		/*
   239		 * Wait until all sensoring points idled.
   240		 * No need to check LVTS status when suspend/resume,
   241		 * this will spend extra 100us of suspend flow.
   242		 * LVTS status will be reset after resume.
   243		 */
   244		while (cnt < 80) {
   245			temp = lvts_thermal_check_all_sensing_point_idle(lvts_data);
   246			if (temp == 0)
   247				goto TAIL;
   248	
   249			udelay(2);
   250			cnt++;
   251		}
   252		for (i = 0; i < lvts_data->num_tc; i++) {
   253			base = GET_BASE_ADDR(i);
   254			temp = readl(LVTSMSRCTL1_0 + base);
   255			if ((temp & mask) != 0) {
   256				error_code = ((temp & BIT(10)) >> 8) +
   257					((temp & BIT(7)) >> 6) +
   258					(temp & BIT(0));
   259	
   260				dev_info(dev, "Error LVTS %d sensing points aren't idle, error_code %d\n",
   261					i, error_code);
   262			}
   263		}
   264	TAIL:
   265		return;
   266	}
   267	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2025-02-05 16:59 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202502060037.eHmmnb8J-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=cros-kernel-buildreports@googlegroups.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.