From: Stefano Stabellini <stefano.stabellini@amd.com>
To: <xen-devel@lists.xenproject.org>
Cc: <sstabellini@kernel.org>, <bertrand.marquis@arm.com>,
<julien@xen.org>, <michal.orzel@amd.com>,
<Volodymyr_Babchuk@epam.com>,
Stefano Stabellini <stefano.stabellini@amd.com>
Subject: [PATCH v5 7/9] init-dom0less: allocate xenstore page is not already allocated
Date: Wed, 5 Feb 2025 17:08:41 -0800 [thread overview]
Message-ID: <20250206010843.618280-7-stefano.stabellini@amd.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2502041807070.9756@ubuntu-linux-20-04-desktop>
We check if the xenstore page is already allocated. If yes, there is
nothing to do. If no, we proceed allocating it.
Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
---
tools/helpers/init-dom0less.c | 54 +++++++++++++++++++++++++++++++++--
1 file changed, 51 insertions(+), 3 deletions(-)
diff --git a/tools/helpers/init-dom0less.c b/tools/helpers/init-dom0less.c
index 2b51965fa7..3cee325358 100644
--- a/tools/helpers/init-dom0less.c
+++ b/tools/helpers/init-dom0less.c
@@ -16,8 +16,35 @@
#include "init-dom-json.h"
+#define XENSTORE_PFN_OFFSET 1
#define STR_MAX_LENGTH 128
+
+static int alloc_xs_page(struct xc_interface_core *xch,
+ libxl_dominfo *info,
+ uint64_t *xenstore_pfn)
+{
+ int rc;
+ const xen_pfn_t base = GUEST_MAGIC_BASE >> XC_PAGE_SHIFT;
+ xen_pfn_t p2m = (GUEST_MAGIC_BASE >> XC_PAGE_SHIFT) + XENSTORE_PFN_OFFSET;
+
+ rc = xc_domain_setmaxmem(xch, info->domid,
+ info->max_memkb + (XC_PAGE_SIZE/1024));
+ if (rc < 0)
+ return rc;
+
+ rc = xc_domain_populate_physmap_exact(xch, info->domid, 1, 0, 0, &p2m);
+ if (rc < 0)
+ return rc;
+
+ *xenstore_pfn = base + XENSTORE_PFN_OFFSET;
+ rc = xc_clear_domain_page(xch, info->domid, *xenstore_pfn);
+ if (rc < 0)
+ return rc;
+
+ return 0;
+}
+
static int get_xs_page(struct xc_interface_core *xch, libxl_dominfo *info,
uint64_t *xenstore_pfn)
{
@@ -233,9 +260,30 @@ static int init_domain(struct xs_handle *xsh,
return 0;
/* Get xenstore page */
- if (get_xs_page(xch, info, &xenstore_pfn) != 0) {
- printf("Error on getting xenstore page\n");
- return 1;
+ if (get_xs_page(xch, info, &xenstore_pfn) != 0 || xenstore_pfn == ~0ULL) {
+ struct xenstore_domain_interface *intf;
+
+ rc = alloc_xs_page(xch, info, &xenstore_pfn);
+ if (rc != 0) {
+ printf("Error on getting xenstore page\n");
+ return 1;
+ }
+
+ intf = xenforeignmemory_map(xfh, info->domid, PROT_READ | PROT_WRITE, 1,
+ &xenstore_pfn, NULL);
+ if (!intf) {
+ printf("Error mapping xenstore page\n");
+ return 1;
+ }
+
+ intf->connection = XENSTORE_RECONNECT;
+ xenforeignmemory_unmap(xfh, intf, 1);
+
+ /* Now everything is ready: set HVM_PARAM_STORE_PFN */
+ rc = xc_hvm_param_set(xch, info->domid, HVM_PARAM_STORE_PFN,
+ xenstore_pfn);
+ if (rc < 0)
+ return rc;
}
rc = xc_dom_gnttab_seed(xch, info->domid, true,
--
2.25.1
next prev parent reply other threads:[~2025-02-06 1:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 1:08 [PATCH v5 0/9] Guest XenStore page allocation for 11 Dom0less domUs Stefano Stabellini
2025-02-06 1:08 ` [PATCH v5 1/9] automation: upgrade Linux kernel for arm64 tests to 6.6.74 Stefano Stabellini
2025-02-06 7:58 ` Orzel, Michal
2025-02-06 23:12 ` Stefano Stabellini
2025-02-06 1:08 ` [PATCH v5 2/9] xen/arm/static-shmem: Static-shmem should be direct-mapped for direct-mapped domains Stefano Stabellini
2025-02-06 8:04 ` Orzel, Michal
2025-02-06 23:13 ` Stefano Stabellini
2025-02-06 1:08 ` [PATCH v5 3/9] xen/arm: Alloc XenStore page for Dom0less DomUs from hypervisor Stefano Stabellini
2025-02-06 10:20 ` Orzel, Michal
2025-02-07 1:19 ` Stefano Stabellini
2025-02-06 1:08 ` [PATCH v5 4/9] tools/init-dom0less: Avoid hardcoding GUEST_MAGIC_BASE Stefano Stabellini
2025-02-06 1:08 ` [PATCH v5 5/9] docs/features/dom0less: Update the late XenStore init protocol Stefano Stabellini
2025-02-06 1:08 ` [PATCH v5 6/9] automation: add ping test to static-mem test Stefano Stabellini
2025-02-06 1:08 ` Stefano Stabellini [this message]
2025-02-06 12:37 ` [PATCH v5 7/9] init-dom0less: allocate xenstore page is not already allocated Jan Beulich
2025-02-06 23:14 ` Stefano Stabellini
2025-02-06 1:08 ` [PATCH v5 8/9] xen/arm: introduce legacy dom0less option for xenstore allocation Stefano Stabellini
2025-02-06 12:08 ` Orzel, Michal
2025-02-07 1:43 ` Stefano Stabellini
2025-02-06 1:08 ` [PATCH v5 9/9] [DO NOT COMMIT] automation: add one test using an older unpatched Linux kernel Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250206010843.618280-7-stefano.stabellini@amd.com \
--to=stefano.stabellini@amd.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=bertrand.marquis@arm.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.