From: David Aguilar <davvid@gmail.com>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Elijah Newren" <newren@gmail.com>,
"Patrick Steinhardt" <ps@pks.im>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: [PATCH v2 3/3] difftool: eliminate use of USE_THE_REPOSITORY_VARIABLE
Date: Wed, 5 Feb 2025 20:20:10 -0800 [thread overview]
Message-ID: <20250206042010.865947-3-davvid@gmail.com> (raw)
In-Reply-To: <20250206042010.865947-1-davvid@gmail.com>
Remove the USE_THE_REPOSITORY_VARIABLE #define now that all
state is passed to each function from callers.
Signed-off-by: David Aguilar <davvid@gmail.com>
---
builtin/difftool.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/builtin/difftool.c b/builtin/difftool.c
index 81d733dfdf..41cd00066c 100644
--- a/builtin/difftool.c
+++ b/builtin/difftool.c
@@ -12,8 +12,6 @@
* Copyright (C) 2016 Johannes Schindelin
*/
-#define USE_THE_REPOSITORY_VARIABLE
-
#include "builtin.h"
#include "abspath.h"
--
2.48.1.461.g612e419e04
next prev parent reply other threads:[~2025-02-06 4:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 4:20 [PATCH v2 1/3] difftool: eliminate use of global variables David Aguilar
2025-02-06 4:20 ` [PATCH v2 2/3] difftool: eliminate use of the_repository David Aguilar
2025-02-06 8:30 ` Elijah Newren
2025-02-06 4:20 ` David Aguilar [this message]
2025-02-06 8:31 ` [PATCH v2 3/3] difftool: eliminate use of USE_THE_REPOSITORY_VARIABLE Elijah Newren
2025-02-07 6:28 ` Patrick Steinhardt
2025-02-07 17:49 ` Junio C Hamano
2025-02-06 8:29 ` [PATCH v2 1/3] difftool: eliminate use of global variables Elijah Newren
2025-02-07 4:44 ` David Aguilar
2025-02-06 13:34 ` Junio C Hamano
2025-02-06 18:08 ` Elijah Newren
2025-02-06 19:07 ` Junio C Hamano
2025-02-07 6:28 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250206042010.865947-3-davvid@gmail.com \
--to=davvid@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=newren@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.