All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: jouni.hogander@intel.com, ankit.k.nautiyal@intel.com
Subject: [PATCH v3 1/2] drm/i915/display: Skip state checker for AS SDP infoframe enable
Date: Thu,  6 Feb 2025 10:20:00 +0530	[thread overview]
Message-ID: <20250206045001.2919360-2-mitulkumar.ajitkumar.golani@intel.com> (raw)
In-Reply-To: <20250206045001.2919360-1-mitulkumar.ajitkumar.golani@intel.com>

Avoid full modeset by skipping infoframe.enable check when toggling
AS SDP while enabling VRR, preventing full modeset while pipe
config changes.

--v2:
- Add check for exclude_infoframe. (Ankit)
- Update commit message. (Ankit)

--v3:
- Optimise PIPE_CONF_CHECK for infoframes.enable. [Ankit]

Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index a6383ddde871..a50b0a008231 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -5388,6 +5388,7 @@ intel_pipe_config_compare(const struct intel_crtc_state *current_config,
 	struct drm_i915_private *dev_priv = to_i915(current_config->uapi.crtc->dev);
 	struct intel_crtc *crtc = to_intel_crtc(pipe_config->uapi.crtc);
 	struct drm_printer p;
+	u32 exclude_infoframes = 0;
 	bool ret = true;
 
 	if (fastset)
@@ -5743,11 +5744,12 @@ intel_pipe_config_compare(const struct intel_crtc_state *current_config,
 	PIPE_CONF_CHECK_I(min_voltage_level);
 
 	if (current_config->has_psr || pipe_config->has_psr)
-		PIPE_CONF_CHECK_X_WITH_MASK(infoframes.enable,
-					    ~intel_hdmi_infoframe_enable(DP_SDP_VSC));
-	else
-		PIPE_CONF_CHECK_X(infoframes.enable);
+		exclude_infoframes |= intel_hdmi_infoframe_enable(DP_SDP_VSC);
+
+	if (current_config->vrr.enable || pipe_config->vrr.enable)
+		exclude_infoframes |= intel_hdmi_infoframe_enable(DP_SDP_ADAPTIVE_SYNC);
 
+	PIPE_CONF_CHECK_X_WITH_MASK(infoframes.enable, ~exclude_infoframes);
 	PIPE_CONF_CHECK_X(infoframes.gcp);
 	PIPE_CONF_CHECK_INFOFRAME(avi);
 	PIPE_CONF_CHECK_INFOFRAME(spd);
-- 
2.48.1


  reply	other threads:[~2025-02-06  4:54 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-06  4:49 [PATCH v3 0/2] Compute as_sdp when vrr is enabled Mitul Golani
2025-02-06  4:50 ` Mitul Golani [this message]
2025-02-06  4:50 ` [PATCH v3 2/2] Revert "drm/i915/dp: Compute as_sdp based on if vrr possible" Mitul Golani
2025-02-06  5:04 ` ✓ CI.Patch_applied: success for Compute as_sdp when vrr is enabled (rev2) Patchwork
2025-02-06  5:04 ` ✓ CI.checkpatch: " Patchwork
2025-02-06  5:05 ` ✓ CI.KUnit: " Patchwork
2025-02-06  5:22 ` ✓ CI.Build: " Patchwork
2025-02-06  5:24 ` ✓ CI.Hooks: " Patchwork
2025-02-06  5:26 ` ✓ CI.checksparse: " Patchwork
2025-02-06  5:34 ` ✗ Fi.CI.SPARSE: warning for Compute as_sdp when vrr is enabled (rev3) Patchwork
2025-02-06  5:46 ` ✓ Xe.CI.BAT: success for Compute as_sdp when vrr is enabled (rev2) Patchwork
2025-02-06  6:42 ` ✗ Xe.CI.Full: failure " Patchwork
2025-02-06 15:43 ` ✗ i915.CI.BAT: failure for Compute as_sdp when vrr is enabled (rev3) Patchwork
2025-02-07  3:45   ` Golani, Mitulkumar Ajitkumar
2025-02-07  4:52 ` ✓ i915.CI.BAT: success " Patchwork
2025-02-07  5:29 ` ✓ i915.CI.Full: " Patchwork
2025-02-07  6:33 ` [PATCH v3 0/2] Compute as_sdp when vrr is enabled Nautiyal, Ankit K

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250206045001.2919360-2-mitulkumar.ajitkumar.golani@intel.com \
    --to=mitulkumar.ajitkumar.golani@intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jouni.hogander@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.