From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>
Cc: Kuniyuki Iwashima <kuniyu@amazon.com>,
Kuniyuki Iwashima <kuni1840@gmail.com>, <netdev@vger.kernel.org>
Subject: [PATCH v1 net-next 5/6] fib: rules: Add error_free label in fib_nl_delrule().
Date: Thu, 6 Feb 2025 17:46:28 +0900 [thread overview]
Message-ID: <20250206084629.16602-6-kuniyu@amazon.com> (raw)
In-Reply-To: <20250206084629.16602-1-kuniyu@amazon.com>
We will hold RTNL just before calling fib_nl2rule_rtnl() in
fib_nl_delrule() and release it before kfree(nlrule).
Let's add a new rule to make the following change cleaner.
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
---
net/core/fib_rules.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/net/core/fib_rules.c b/net/core/fib_rules.c
index 3cdfa3ac8c7c..cc26c762fa9e 100644
--- a/net/core/fib_rules.c
+++ b/net/core/fib_rules.c
@@ -942,23 +942,23 @@ int fib_nl_delrule(struct sk_buff *skb, struct nlmsghdr *nlh,
err = fib_nl2rule_rtnl(nlrule, ops, tb, extack);
if (err)
- goto errout;
+ goto errout_free;
rule = rule_find(ops, frh, tb, nlrule, user_priority);
if (!rule) {
err = -ENOENT;
- goto errout;
+ goto errout_free;
}
if (rule->flags & FIB_RULE_PERMANENT) {
err = -EPERM;
- goto errout;
+ goto errout_free;
}
if (ops->delete) {
err = ops->delete(rule);
if (err)
- goto errout;
+ goto errout_free;
}
if (rule->tun_id)
@@ -1004,8 +1004,9 @@ int fib_nl_delrule(struct sk_buff *skb, struct nlmsghdr *nlh,
kfree(nlrule);
return 0;
-errout:
+errout_free:
kfree(nlrule);
+errout:
rules_ops_put(ops);
return err;
}
--
2.39.5 (Apple Git-154)
next prev parent reply other threads:[~2025-02-06 8:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 8:46 [PATCH v1 net-next 0/6] fib: rules: Convert RTM_NEWRULE and RTM_DELRULE to per-netns RTNL Kuniyuki Iwashima
2025-02-06 8:46 ` [PATCH v1 net-next 1/6] fib: rules: Don't check net in rule_exists() and rule_find() Kuniyuki Iwashima
2025-02-06 8:46 ` [PATCH v1 net-next 2/6] fib: rules: Pass net to fib_nl2rule() instead of skb Kuniyuki Iwashima
2025-02-06 8:46 ` [PATCH v1 net-next 3/6] fib: rules: Split fib_nl2rule() Kuniyuki Iwashima
2025-02-06 8:46 ` [PATCH v1 net-next 4/6] fib: rules: Convert RTM_NEWRULE to per-netns RTNL Kuniyuki Iwashima
2025-02-06 8:46 ` Kuniyuki Iwashima [this message]
2025-02-06 8:46 ` [PATCH v1 net-next 6/6] fib: rules: Convert RTM_DELRULE " Kuniyuki Iwashima
2025-02-06 9:41 ` Eric Dumazet
2025-02-06 9:52 ` Kuniyuki Iwashima
2025-02-06 11:22 ` Ido Schimmel
2025-02-07 4:12 ` Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250206084629.16602-6-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.