From: Ajith P V <ajithpv.linux@gmail.com>
To: dpenkler@gmail.com, gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Ajith P V <ajithpv.linux@gmail.com>
Subject: [PATCH] staging: gpib: Resolve prefixing 0x with decimal
Date: Thu, 6 Feb 2025 14:58:15 +0530 [thread overview]
Message-ID: <20250206092815.3267-1-ajithpv.linux@gmail.com> (raw)
- pr_err() of hp82335_attach() in hp82335 uses 0x%u which is defective.
- The iobase is of u32 and correct prefix is 0x%x.
- This error reported by checkpatch with below message:
ERROR: Prefixing 0x with decimal output is defective
Signed-off-by: Ajith P V <ajithpv.linux@gmail.com>
---
drivers/staging/gpib/hp_82335/hp82335.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gpib/hp_82335/hp82335.c b/drivers/staging/gpib/hp_82335/hp82335.c
index 451d5dc6d340..6ce79b17a419 100644
--- a/drivers/staging/gpib/hp_82335/hp82335.c
+++ b/drivers/staging/gpib/hp_82335/hp82335.c
@@ -274,7 +274,7 @@ static int hp82335_attach(gpib_board_t *board, const gpib_board_config_t *config
case 0xfc000:
break;
default:
- pr_err("hp82335: invalid base io address 0x%u\n", config->ibbase);
+ pr_err("hp82335: invalid base io address 0x%x\n", config->ibbase);
return -EINVAL;
}
if (!request_mem_region(upper_iomem_base, hp82335_upper_iomem_size, "hp82335")) {
--
2.43.0
next reply other threads:[~2025-02-06 9:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 9:28 Ajith P V [this message]
2025-02-14 12:04 ` [PATCH] staging: gpib: Resolve prefixing 0x with decimal Dave Penkler
-- strict thread matches above, loose matches on Subject: below --
2025-02-04 13:51 Ajith P V
2025-02-04 14:06 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250206092815.3267-1-ajithpv.linux@gmail.com \
--to=ajithpv.linux@gmail.com \
--cc=dpenkler@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.