From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <edumazet@google.com>
Cc: <davem@davemloft.net>, <dsahern@kernel.org>,
<eric.dumazet@gmail.com>, <horms@kernel.org>, <kuba@kernel.org>,
<netdev@vger.kernel.org>, <pabeni@redhat.com>,
Kuniyuki Iwashima <kuniyu@amazon.com>
Subject: Re: [PATCH net] net: fib_rules: annotate data-races around rule->[io]ifindex
Date: Thu, 6 Feb 2025 18:40:42 +0900 [thread overview]
Message-ID: <20250206094042.23391-1-kuniyu@amazon.com> (raw)
In-Reply-To: <20250206083051.2494877-1-edumazet@google.com>
From: Eric Dumazet <edumazet@google.com>
Date: Thu, 6 Feb 2025 08:30:51 +0000
> rule->iifindex and rule->oifindex can be read without holding RTNL.
>
> Add READ_ONCE()/WRITE_ONCE() annotations where needed.
>
> Fixes: 32affa5578f0 ("fib: rules: no longer hold RTNL in fib_nl_dumprule()")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
next prev parent reply other threads:[~2025-02-06 9:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 8:30 [PATCH net] net: fib_rules: annotate data-races around rule->[io]ifindex Eric Dumazet
2025-02-06 9:40 ` Kuniyuki Iwashima [this message]
2025-02-06 12:00 ` Ido Schimmel
2025-02-07 22:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250206094042.23391-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.