From: Kees Cook <kees@kernel.org>
To: David Laight <david.laight.linux@gmail.com>
Cc: Suren Baghdasaryan <surenb@google.com>,
Kent Overstreet <kent.overstreet@linux.dev>,
Andy Shevchenko <andy@kernel.org>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Philipp Reisner <philipp.reisner@linbit.com>,
Miguel Ojeda <ojeda@kernel.org>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH 2/3] compiler.h: Introduce __must_be_char_array()
Date: Thu, 6 Feb 2025 13:34:35 -0800 [thread overview]
Message-ID: <202502061333.302D4EA68@keescook> (raw)
In-Reply-To: <20250206195658.79231973@pumpkin>
On Thu, Feb 06, 2025 at 07:56:58PM +0000, David Laight wrote:
> On Thu, 6 Feb 2025 10:11:29 -0800
> Kees Cook <kees@kernel.org> wrote:
>
> > In preparation for adding stricter type checking to the str/mem*()
> > helpers, provide a way to check that a variable is a character array
> > via __must_be_char_array().
> >
> ...
> > +#define __is_char_array(a) (__is_array(a) && sizeof((a)[0]) == 1)
> > +#define __must_be_char_array(a) __BUILD_BUG_ON_ZERO_MSG(!__is_char_array(a), \
> > + "must be byte array")
>
> If you are only checking the size, perhaps __is_byte_array() would
> be a better name.
> (You've even used 'byte' in the error message.)
Yeah, fair point. I went and forth on naming. Fixed for v2.
--
Kees Cook
next prev parent reply other threads:[~2025-02-06 21:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 18:11 [PATCH 0/3] string.h: Use ARRAY_SIZE() for memtostr*()/strtomem*() Kees Cook
2025-02-06 18:11 ` [PATCH 1/3] compiler.h: Move C string helpers into C-only kernel section Kees Cook
2025-02-06 20:07 ` Miguel Ojeda
2025-02-06 21:28 ` Kees Cook
2025-02-06 18:11 ` [PATCH 2/3] compiler.h: Introduce __must_be_char_array() Kees Cook
2025-02-06 19:56 ` David Laight
2025-02-06 21:34 ` Kees Cook [this message]
2025-02-06 20:50 ` Kent Overstreet
2025-02-06 21:26 ` Kees Cook
2025-02-07 8:55 ` Rasmus Villemoes
2025-02-07 13:13 ` David Laight
2025-02-07 13:58 ` Kent Overstreet
2025-02-06 18:11 ` [PATCH 3/3] string.h: Use ARRAY_SIZE() for memtostr*()/strtomem*() Kees Cook
2025-02-06 18:41 ` [PATCH 0/3] " Andy Shevchenko
2025-02-06 18:44 ` Miguel Ojeda
2025-02-06 18:45 ` Andy Shevchenko
2025-02-06 18:52 ` Kees Cook
2025-02-06 19:12 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202502061333.302D4EA68@keescook \
--to=kees@kernel.org \
--cc=andy@kernel.org \
--cc=david.laight.linux@gmail.com \
--cc=justinstitt@google.com \
--cc=kent.overstreet@linux.dev \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=luc.vanoostenryck@gmail.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=ojeda@kernel.org \
--cc=philipp.reisner@linbit.com \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.