All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>,
	linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-hardening@vger.kernel.org
Subject: Re: [PATCH][next] ext4: avoid dozens of -Wflex-array-member-not-at-end warnings
Date: Thu, 6 Feb 2025 10:09:10 -0500	[thread overview]
Message-ID: <20250206150910.GA1130956@mit.edu> (raw)
In-Reply-To: <Zz0TEX3GycUEmISN@kspp>

On Tue, Nov 19, 2024 at 04:37:05PM -0600, Gustavo A. R. Silva wrote:
> -Wflex-array-member-not-at-end was introduced in GCC-14, and we
> are getting ready to enable it, globally.
> 
> Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of
> a flexible structure (`struct shash_desc`) where the size of the
> flexible-array member (`__ctx`) is known at compile-time, and
> refactor the rest of the code, accordingly.
> 
> So, with these changes, fix 38 of the following warnings:
> 
> fs/ext4/ext4.h:2471:35: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]
> 
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>

Thanks, for this patch!  It appears that this patch has since been
obviated by Eric Bigger's commit f2b4fa19647e (" ext4: switch to using
the crc32c library"), which landed during this merge window, so this
patch should not be needed.

						- Ted

  reply	other threads:[~2025-02-06 15:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-19 22:37 [PATCH][next] ext4: avoid dozens of -Wflex-array-member-not-at-end warnings Gustavo A. R. Silva
2025-02-06 15:09 ` Theodore Ts'o [this message]
2025-02-06 23:09   ` Gustavo A. R. Silva
2025-02-07  1:35     ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250206150910.GA1130956@mit.edu \
    --to=tytso@mit.edu \
    --cc=adilger.kernel@dilger.ca \
    --cc=gustavoars@kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.