From: Simon Horman <horms@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Nikita Yushchenko" <nikita.yoush@cogentembedded.com>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH net-next] net: renesas: rswitch: Convert to for_each_available_child_of_node()
Date: Thu, 6 Feb 2025 16:31:26 +0000 [thread overview]
Message-ID: <20250206163126.GY554665@kernel.org> (raw)
In-Reply-To: <CAMuHMdUgydc4q-dSsUQ_zLpkvbv9-26T3tpEO6e7OF491jTrEQ@mail.gmail.com>
On Wed, Feb 05, 2025 at 05:18:14PM +0100, Geert Uytterhoeven wrote:
> Hi Nikita,
>
> On Wed, 5 Feb 2025 at 17:15, Nikita Yushchenko
> <nikita.yoush@cogentembedded.com> wrote:
> > > Simplify rswitch_get_port_node() by using the
> > > for_each_available_child_of_node() helper instead of manually ignoring
> > > unavailable child nodes, and leaking a reference.
> >
> > FYI, I have a patch in my queue that replaces this code with traversing child nodes (via
> > for_each_available_child_of_node()) and only creating devices for ports actually defined in the device tree.
>
> OK, thanks for letting me know!
I am assuming that we can treat Nikita's patch as being orthogonal to this one.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-02-06 16:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 16:12 [PATCH net-next] net: renesas: rswitch: Convert to for_each_available_child_of_node() Geert Uytterhoeven
2025-02-05 16:15 ` Nikita Yushchenko
2025-02-05 16:18 ` Geert Uytterhoeven
2025-02-06 16:31 ` Simon Horman [this message]
2025-02-07 20:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250206163126.GY554665@kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geert@linux-m68k.org \
--cc=kuba@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikita.yoush@cogentembedded.com \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=pabeni@redhat.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.