From: Jakub Kicinski <kuba@kernel.org>
To: Danielle Ratson <danieller@nvidia.com>
Cc: <netdev@vger.kernel.org>, <mkubecek@suse.cz>,
<matt@traverse.com.au>, <daniel.zahka@gmail.com>,
<amcohen@nvidia.com>, <nbu-mlxsw@exchange.nvidia.com>
Subject: Re: [PATCH ethtool-next v4 00/16] Add JSON output to --module-info
Date: Thu, 6 Feb 2025 16:39:49 -0800 [thread overview]
Message-ID: <20250206163949.370011ae@kernel.org> (raw)
In-Reply-To: <20250205155436.1276904-1-danieller@nvidia.com>
On Wed, 5 Feb 2025 17:54:20 +0200 Danielle Ratson wrote:
> Add JSON output for 'ethtool -m' / --module-info, following the
> guideline below:
>
> 1. Fields with description, will have a separate description field.
> 2. Units will be documented in a separate module-info.json file.
> 3. ASCII fields will be presented as strings.
> 4. On/Off is rendered as true/false.
> 5. Yes/no is rendered as true/false.
> 6. Per-channel fields will be presented as array, when each element
> represents a channel.
> 7. Fields that hold version, will be split to major and minor sub
> fields.
>
> This patchset suppose to extend [1] to cover all types of modules.
>
> Patchset overview:
> Patches #1-#7: Preparations.
> Patches #8-#9: Add JSON output support for CMIS compliant modules.
> Patches #10-#11: Add JSON output support for SFF8636 modules.
> Patches #12-#14: Add JSON output support for SFF8079 and SFF8472 modules.
> Patch #15: Add a new schema JSON file for units documentation.
> Patches #16: Add '-j' support to ethtool
Acked-by: Jakub Kicinski <kuba@kernel.org>
Thanks a lot for doing this work!
prev parent reply other threads:[~2025-02-07 0:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 15:54 [PATCH ethtool-next v4 00/16] Add JSON output to --module-info Danielle Ratson
2025-02-05 15:54 ` [PATCH ethtool-next v4 01/16] module_common: Add a new file to all the common code for all module types Danielle Ratson
2025-02-05 15:54 ` [PATCH ethtool-next v4 02/16] ethtool: Standardize Link Length field names across " Danielle Ratson
2025-02-05 15:54 ` [PATCH ethtool-next v4 03/16] sff_common: Move sff_show_revision_compliance() to qsfp.c Danielle Ratson
2025-02-05 15:54 ` [PATCH ethtool-next v4 04/16] cmis: Change loop order in cmis_show_dom_chan_lvl_flags() Danielle Ratson
2025-02-05 15:54 ` [PATCH ethtool-next v4 05/16] qsfp: Reorder the channel-level flags list for SFF8636 module type Danielle Ratson
2025-02-05 15:54 ` [PATCH ethtool-next v4 06/16] qsfp: Refactor sff8636_show_dom() by moving code into separate functions Danielle Ratson
2025-02-05 15:54 ` [PATCH ethtool-next v4 07/16] module_common: Add helpers to support JSON printing for common value types Danielle Ratson
2025-02-05 15:54 ` [PATCH ethtool-next v4 08/16] cmis: Add JSON output handling to --module-info in CMIS modules Danielle Ratson
2025-02-05 15:54 ` [PATCH ethtool-next v4 09/16] cmis: Enable JSON output support " Danielle Ratson
2025-02-05 15:54 ` [PATCH ethtool-next v4 10/16] qsfp: Add JSON output handling to --module-info in SFF8636 modules Danielle Ratson
2025-02-05 15:54 ` [PATCH ethtool-next v4 11/16] qsfp: Enable JSON output support for " Danielle Ratson
2025-02-07 0:38 ` Jakub Kicinski
2025-02-05 15:54 ` [PATCH ethtool-next v4 12/16] sfpid: Add JSON output handling to --module-info in SFF8079 modules Danielle Ratson
2025-02-05 15:54 ` [PATCH ethtool-next v4 13/16] sfpdiag: Add JSON output handling to --module-info in SFF8472 modules Danielle Ratson
2025-02-05 15:54 ` [PATCH ethtool-next v4 14/16] ethtool: Enable JSON output support for SFF8079 and " Danielle Ratson
2025-02-05 15:54 ` [PATCH ethtool-next v4 15/16] module_info: Add a new JSON file for units documentation Danielle Ratson
2025-02-05 15:54 ` [PATCH ethtool-next v4 16/16] ethtool: Add '-j' support to ethtool Danielle Ratson
2025-02-07 0:39 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250206163949.370011ae@kernel.org \
--to=kuba@kernel.org \
--cc=amcohen@nvidia.com \
--cc=daniel.zahka@gmail.com \
--cc=danieller@nvidia.com \
--cc=matt@traverse.com.au \
--cc=mkubecek@suse.cz \
--cc=nbu-mlxsw@exchange.nvidia.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.