From: Jakub Kicinski <kuba@kernel.org>
To: Joe Damato <jdamato@fastly.com>
Cc: netdev@vger.kernel.org, pabeni@redhat.com, edumazet@google.com,
sridhar.samudrala@intel.com,
"David S. Miller" <davem@davemloft.net>,
Simon Horman <horms@kernel.org>,
Amritha Nambiar <amritha.nambiar@intel.com>,
Mina Almasry <almasrymina@google.com>,
linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH net-next v4] netdev-genl: Elide napi_id when not present
Date: Thu, 6 Feb 2025 17:14:05 -0800 [thread overview]
Message-ID: <20250206171405.01f1552d@kernel.org> (raw)
In-Reply-To: <20250205193751.297211-1-jdamato@fastly.com>
On Wed, 5 Feb 2025 19:37:47 +0000 Joe Damato wrote:
> There are at least two cases where napi_id may not present and the
> napi_id should be elided:
>
> 1. Queues could be created, but napi_enable may not have been called
> yet. In this case, there may be a NAPI but it may not have an ID and
> output of a napi_id should be elided.
>
> 2. TX-only NAPIs currently do not have NAPI IDs. If a TX queue happens
> to be linked with a TX-only NAPI, elide the NAPI ID from the netlink
> output as a NAPI ID of 0 is not useful for users.
>
> Signed-off-by: Joe Damato <jdamato@fastly.com>
Applied, thanks!
prev parent reply other threads:[~2025-02-07 1:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 19:37 [PATCH net-next v4] netdev-genl: Elide napi_id when not present Joe Damato
2025-02-06 3:26 ` Samudrala, Sridhar
2025-02-06 9:02 ` Eric Dumazet
2025-02-07 1:14 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250206171405.01f1552d@kernel.org \
--to=kuba@kernel.org \
--cc=almasrymina@google.com \
--cc=amritha.nambiar@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sridhar.samudrala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.