From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C9543C02194 for ; Thu, 6 Feb 2025 22:15:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Lkz5Ief6/yedXCa2E82v4RvcWGp3Dzv7ilZTZRS1+D0=; b=38fVdrtuKFm0tB2VpYl4X/UlLd F2D9z8f6h3FHRvUdKIFnYGvfF5V6WEkk0L2OYE0oBArrIZOgqE+VYo6sWBHkC5jCU9l9ze6RY/7k5 HmzAjT5mtbh2EJbrRI/tnmcF9kf3A6Y78UQVepP9GV/Ufbm4MiILCnk8dzZ4OIofVuX7ByapeMotO W3mquxGRshyHPQ52VAiOzZgvMz3tteggZXgoAWocyOtyXLix4zefTViqvxErFVylhQow9R1Fa/gig C27mnJbo3poEvi0NXtvEgBhzlErDw3QXf7SbXPeCJwtsbHdG/gqGfKFF/d152wXgaQBHDhoF0Xt/v WI+YQI1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tgA9i-00000007fPu-1Auo; Thu, 06 Feb 2025 22:15:30 +0000 Received: from mail-ot1-x32e.google.com ([2607:f8b0:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tgA4X-00000007ehS-40sQ for linux-arm-kernel@lists.infradead.org; Thu, 06 Feb 2025 22:10:11 +0000 Received: by mail-ot1-x32e.google.com with SMTP id 46e09a7af769-726819aa3fcso892306a34.0 for ; Thu, 06 Feb 2025 14:10:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1738879809; x=1739484609; darn=lists.infradead.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=Lkz5Ief6/yedXCa2E82v4RvcWGp3Dzv7ilZTZRS1+D0=; b=ACXeEl4+AD0Qw7G/ueuPxH9ceZz+L3JtgztgWQ6CJ1EAaAlrdokzBx18W9zSGuG2gY kldR1IYfWB1gU7Q2y9UB/PB5wg93Mw1S0Drkg5AunEwOaextKinNbKQP7j0bs2iGs8gG Ljq/iN5L5Z7IXjSWOYwHS+teiM4M9bnDKlfk0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738879809; x=1739484609; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Lkz5Ief6/yedXCa2E82v4RvcWGp3Dzv7ilZTZRS1+D0=; b=S1yeCz1LHqlw5a6L+XnnOO/MFUfrec7xnBj+L+02ek6QBpK47EAFcUf16mzp6dVH4M kZE+VRuelUO6sG/W4CE5FYksk/ugtas3WAdxc9Dy3ujrsLZTOBRZq9C4j0FMTaY29PFd rayvLAlRBmuj/BXPyaV26WHjIBo03/qix5/kpbTM0lxvM1TUGl0W4w/WjPwiMdKwaukV ZfqHOa9sQgVPX/jlZLmA+2Wl1mjPZpj4muCzrLH1b2xQwOQRFMDvlyok6u1HrNg8y9dj Qe0A1Il/VN/R+iV25qKp9/3xe4SjBPN6xFKbsxOxh17yI4+qjBGIVc52dmC4P7sF3s7N KfFw== X-Forwarded-Encrypted: i=1; AJvYcCWTNd1gGALwYwQ80aMbHkoJLmxPsTiOzA3cZ5+8ck5d5bmbfiu1mvJcvwR+QkOy1EDAPjOyDKsBqKGflR7F9aVn@lists.infradead.org X-Gm-Message-State: AOJu0YwvjixKIcIrPufAvx3dplhNQDHHp+mLE3NYsfFVvctxt+CooTmP 8jewY6MbifPdiGJx0oygOQsEOx4Zjsk+6qcNHew63xuZYtY7PbGEtIcb9VGMgQ== X-Gm-Gg: ASbGncvdUx7kc/+tl75pQSy266Gk/wX8qEv75bsFMVbas7njM9e226WwYcmbFsjCE36 iV0TMhXCLwZBtbfmMkPSdKyJYgu98w7qh1NKkq4r439yVcd4Rh1EhBu8Onfb/GOz0QtOEL4xFF0 hLfyI0eRnaEy44FCUWybN5/Iq0nmkN20fpOfgo4pPxaP8mRxE0Eh12NJV55iyhdGKtgH8f5ZOsV V/f4GshL0N0dAp9lEexW5I5S1fBLgHI6xAR4LtBQr4g7ivuh6a2uFkfNCfi0pT4SWFuROmE/9zU FYa6sC7po2jXHSxlI2xhdGHOu347nOwcjN6qMQENPolIaTSPA08= X-Google-Smtp-Source: AGHT+IFe5+HDp6jW4POK05lh6FZmTZaClwC8C9AdZB4KwfkTEdj/0zyU6GxhcMlShT6jCqkuU2sdmg== X-Received: by 2002:a05:6830:378c:b0:71e:946:80c4 with SMTP id 46e09a7af769-726b87f8463mr750227a34.12.1738879808913; Thu, 06 Feb 2025 14:10:08 -0800 (PST) Received: from mail.broadcom.net ([192.19.144.250]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-5fc544cf88esm454109eaf.15.2025.02.06.14.10.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2025 14:10:08 -0800 (PST) From: Kamal Dasu To: ulf.hansson@linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, adrian.hunter@intel.com, linux-mmc@vger.kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, wsa+renesas@sang-engineering.com Cc: f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com, Kamal Dasu Subject: [PATCH RFC 3/3] mmc: sdhci-brcmstb: Add rpmb sharing support in host driver Date: Thu, 6 Feb 2025 17:09:40 -0500 Message-Id: <20250206220940.10553-4-kamal.dasu@broadcom.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20250206220940.10553-1-kamal.dasu@broadcom.com> References: <20250206220940.10553-1-kamal.dasu@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250206_141009_998814_F7B15D8E X-CRM114-Status: GOOD ( 24.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Kamal Dasu Adding sdio rpmb parition sharing support to brcmstb host driver. The sdhci-brcmstb controller driver uses SDIO_SHARE registers and HW semaphore register to synchronize access between linux and the trusted zone firmware. Signed-off-by: Kamal Dasu --- drivers/mmc/host/sdhci-brcmstb.c | 275 ++++++++++++++++++++++++++++++- 1 file changed, 273 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/sdhci-brcmstb.c b/drivers/mmc/host/sdhci-brcmstb.c index 0ef4d578ade8..6ba90108cd5c 100644 --- a/drivers/mmc/host/sdhci-brcmstb.c +++ b/drivers/mmc/host/sdhci-brcmstb.c @@ -46,9 +46,32 @@ /* Select all SD UHS type I SDR speed above 50MB/s */ #define MMC_CAP_UHS_I_SDR_MASK (MMC_CAP_UHS_SDR50 | MMC_CAP_UHS_SDR104) +#define SDHCI_BRCMSTB_AGENT_LINUX 'L' +#define SDHCI_BRCMSTB_AGENT_TZOS 'A' +#define FLSHARE_IPIS0_INT_SEND_MASK BIT(17) +#define HWSEM_AQUIRE 1 +#define HWSEM_RELEASE 0 + +enum brcmstb_sdhci_share_reg { + BRCMSTB_SD_SHARE_REG_NEXT = 0x0, /* Next Agent Register */ + BRCMSTB_SD_SHARE_REG_PMC = 0x4, /* Work Agent1 Register */ + BRCMSTB_SD_SHARE_REG_TZOS = 0x8, /* Work Agent2 Register */ + BRCMSTB_SD_SHARE_REG_LINUX = 0xc, /* Work Agent3 Register */ +}; + +struct brcmstb_sdio_share_info { + void __iomem *share_reg; + void __iomem *sem_reg; + void __iomem *ipis0_reg; + int irq_recv; + wait_queue_head_t wq; +}; + + struct sdhci_brcmstb_priv { void __iomem *cfg_regs; unsigned int flags; + struct brcmstb_sdio_share_info *si; struct clk *base_clk; u32 base_freq_hz; }; @@ -288,7 +311,7 @@ static const struct brcmstb_match_priv match_priv_7216 = { .ops = &sdhci_brcmstb_ops_7216, }; -static struct brcmstb_match_priv match_priv_74165b0 = { +static const struct brcmstb_match_priv match_priv_74165b0 = { .flags = BRCMSTB_MATCH_FLAGS_HAS_CLOCK_GATE, .hs400es = sdhci_brcmstb_hs400es, .ops = &sdhci_brcmstb_ops_74165b0, @@ -303,6 +326,176 @@ static const struct of_device_id __maybe_unused sdhci_brcm_of_match[] = { {}, }; +static void sdhci_brcmstb_dbg_dump_sdio_share_regs(struct sdhci_host *host) +{ + struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); + struct sdhci_brcmstb_priv *priv = sdhci_pltfm_priv(pltfm_host); + struct brcmstb_sdio_share_info *si = priv->si; + + dev_dbg(mmc_dev(host->mmc), + "sem:0x%x wn:0x%x wa:0x%x wl:0x%x\n", + readl(si->sem_reg), + readl(si->share_reg + BRCMSTB_SD_SHARE_REG_NEXT), + readl(si->share_reg + BRCMSTB_SD_SHARE_REG_TZOS), + readl(si->share_reg + BRCMSTB_SD_SHARE_REG_LINUX)); +} + +static bool sdhci_brcmstb_host_is_next(struct brcmstb_sdio_share_info *si) +{ + u32 wn; + + /* if work queue is empty or we are next */ + wn = readl(si->share_reg + BRCMSTB_SD_SHARE_REG_NEXT); + return (wn == 0 ? true : (wn == SDHCI_BRCMSTB_AGENT_LINUX)); +} + +#define SDHCI_BRCMSTB_HOST_TIMEOUT_MS 5 + +static int sdhci_brcmstb_wait_for_host(struct sdhci_host *host) +{ + struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); + struct sdhci_brcmstb_priv *priv = sdhci_pltfm_priv(pltfm_host); + struct brcmstb_sdio_share_info *si = priv->si; + int ret = 0; + + /* put self in wait queue if host not avialable */ + ret = wait_event_timeout(si->wq, sdhci_brcmstb_host_is_next(si), + msecs_to_jiffies(SDHCI_BRCMSTB_HOST_TIMEOUT_MS) + 1); + + return ret; +} + +static u32 semreg_wrrdl(struct sdhci_host *host, u32 value, void __iomem *addr) +{ + writel(value, addr); + return readl(addr); +} + +static void sdhci_brcmstb_hwsem(struct sdhci_host *host, int sem_op) +{ + struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); + struct sdhci_brcmstb_priv *priv = sdhci_pltfm_priv(pltfm_host); + struct brcmstb_sdio_share_info *si = priv->si; + u32 wr_val; + u32 wa, sem_val; + bool is_next; + int ret = 0; + + while (1) { + if (sem_op == HWSEM_AQUIRE) { + /* + * get hw sem : + * + * 1. write linux agent id to work register WL + * 2. check if we are next in line or workqueue empty + * 3. if linux is not next in queue go into waitq + * + * handle case where the next work agent was not set + * but TZOS grabbed the semaphore before we could + * in that case too we put ourselves in wait queue, + * tzos shall remove linux from wait queue using IPI + */ + wr_val = SDHCI_BRCMSTB_AGENT_LINUX; + writel(wr_val, si->share_reg + BRCMSTB_SD_SHARE_REG_LINUX); + is_next = sdhci_brcmstb_host_is_next(si); + if (!is_next) + ret = sdhci_brcmstb_wait_for_host(host); + } else { + /* + * release hw semphore + * 1. set the next agent before releasing hw sem + * 2. clear work agent + * 3. Release hw semaphore + */ + wa = readl(si->share_reg + BRCMSTB_SD_SHARE_REG_TZOS); + writel(wa, si->share_reg + BRCMSTB_SD_SHARE_REG_NEXT); + writel(0, si->share_reg + BRCMSTB_SD_SHARE_REG_LINUX); + wr_val = 0; + sem_val = readl(si->sem_reg); + if (!sem_val || sem_val != SDHCI_BRCMSTB_AGENT_LINUX) + goto out; + + } + + /* try to grab/release hw semaphore */ + sem_val = semreg_wrrdl(host, wr_val, si->sem_reg); + + if (!wr_val || (sem_val == wr_val)) + break; + } + + return; +out: + sdhci_brcmstb_dbg_dump_sdio_share_regs(host); + dev_dbg(mmc_dev(host->mmc), "%s ret:%d\n", + (sem_op == HWSEM_AQUIRE) ? "get" : "release", ret); +} + +static bool sdhci_brcmstb_cqe_is_idle(struct sdhci_host *host) +{ + struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); + struct sdhci_brcmstb_priv *priv = sdhci_pltfm_priv(pltfm_host); + struct mmc_host *mmc = host->mmc; + struct cqhci_host *cq_host; + + if (!(priv->flags & BRCMSTB_PRIV_FLAGS_HAS_CQE)) + return true; + + cq_host = mmc->cqe_private; + /* still processing mrqs in cqe mode */ + return (cq_host->qcnt == 0 && !cq_host->recovery_halt) ? true : false; +} + +static void sdhci_brcmstb_aquire_hwsem(struct sdhci_host *host) +{ + struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); + struct sdhci_brcmstb_priv *priv = sdhci_pltfm_priv(pltfm_host); + struct brcmstb_sdio_share_info *si = priv->si; + u32 wn = SDHCI_BRCMSTB_AGENT_LINUX; + + sdhci_brcmstb_hwsem(host, HWSEM_AQUIRE); + /* indicate linux as next agent since it got the hw semaphore */ + writel(wn, si->share_reg + BRCMSTB_SD_SHARE_REG_NEXT); + dev_dbg(mmc_dev(host->mmc), "hwsem get\n"); + sdhci_brcmstb_dbg_dump_sdio_share_regs(host); +} + +static void sdhci_brcmstb_release_hwsem(struct sdhci_host *host) +{ + struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); + struct sdhci_brcmstb_priv *priv = sdhci_pltfm_priv(pltfm_host); + struct brcmstb_sdio_share_info *si = priv->si; + u32 wn; + + if (!sdhci_brcmstb_cqe_is_idle(host)) + return; + + wn = readl(si->share_reg + BRCMSTB_SD_SHARE_REG_NEXT); + /* release hw semaphore send IPI when done */ + sdhci_brcmstb_hwsem(host, HWSEM_RELEASE); + + if (wn == SDHCI_BRCMSTB_AGENT_TZOS) + writel(FLSHARE_IPIS0_INT_SEND_MASK, si->ipis0_reg); + + dev_dbg(mmc_dev(host->mmc), "hwsem release\n"); + sdhci_brcmstb_dbg_dump_sdio_share_regs(host); +} + +static void sdhci_brcmstb_request_start(struct mmc_host *mmchost, + struct mmc_request *mrq) +{ + sdhci_brcmstb_aquire_hwsem(mmc_priv(mmchost)); +} + +static void sdhci_brcmstb_request_done(struct mmc_host *mmchost, + struct mmc_request *mrq) +{ + struct sdhci_host *host = mmc_priv(mmchost); + + if (!mmchost->ongoing_mrq) + sdhci_brcmstb_release_hwsem(host); +} + static u32 sdhci_brcmstb_cqhci_irq(struct sdhci_host *host, u32 intmask) { int cmd_error = 0; @@ -316,6 +509,81 @@ static u32 sdhci_brcmstb_cqhci_irq(struct sdhci_host *host, u32 intmask) return 0; } +static irqreturn_t sdhci_brcmstb_recv_ipi0_irq(int irq, void *dev_id) +{ + struct sdhci_host *host = dev_id; + struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); + struct sdhci_brcmstb_priv *priv = sdhci_pltfm_priv(pltfm_host); + struct brcmstb_sdio_share_info *si = priv->si; + u32 wn; + + wn = readl(si->share_reg + BRCMSTB_SD_SHARE_REG_NEXT); + dev_dbg(mmc_dev(host->mmc), "ipi irq %d wn 0x%x\n", irq, wn); + + if (wn == SDHCI_BRCMSTB_AGENT_LINUX) + wake_up(&si->wq); + + return IRQ_HANDLED; +} + +static int sdhci_brcmstb_sdio_share_init(struct platform_device *pdev) +{ + struct sdhci_host *host = dev_get_drvdata(&pdev->dev); + struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); + struct sdhci_brcmstb_priv *priv = sdhci_pltfm_priv(pltfm_host); + struct brcmstb_sdio_share_info *si; + void __iomem *sdio_sh_regs; + int ret; + + /* sdio_share block */ + sdio_sh_regs = devm_platform_ioremap_resource_byname(pdev, "share"); + if (IS_ERR(sdio_sh_regs)) + return 0; + + si = kcalloc(1, sizeof(struct brcmstb_sdio_share_info), + GFP_KERNEL); + if (!si) + return -ENOMEM; + + si->share_reg = sdio_sh_regs; + si->sem_reg = devm_platform_ioremap_resource_byname(pdev, + "mmc_sem"); + if (IS_ERR(si->sem_reg)) { + ret = PTR_ERR(si->sem_reg); + dev_err(&pdev->dev, "mmc_sem register\n"); + goto err; + } + + si->irq_recv = platform_get_irq_byname_optional(pdev, "recv_ipi0"); + if (si->irq_recv < 0) { + ret = si->irq_recv; + dev_err(&pdev->dev, "recv_ipi0 IRQ not found\n"); + goto err; + } + + ret = devm_request_irq(&pdev->dev, si->irq_recv, + sdhci_brcmstb_recv_ipi0_irq, + 0, "mmc_recv_ipi0", host); + if (ret < 0) { + dev_err(&pdev->dev, "mmc_recv_ipi0 IRQ request_irq failed\n"); + goto err; + } + + si->ipis0_reg = devm_platform_ioremap_resource_byname(pdev, "flshr_ipis0"); + if (IS_ERR(si->ipis0_reg)) + goto err; + + priv->si = si; + init_waitqueue_head(&si->wq); + host->mmc_host_ops.request_start = sdhci_brcmstb_request_start; + host->mmc_host_ops.request_done = sdhci_brcmstb_request_done; + + return 0; +err: + kfree(si); + return ret; +} + static int sdhci_brcmstb_add_host(struct sdhci_host *host, struct sdhci_brcmstb_priv *priv) { @@ -482,8 +750,11 @@ static int sdhci_brcmstb_probe(struct platform_device *pdev) goto err; pltfm_host->clk = clk; - return res; + res = sdhci_brcmstb_sdio_share_init(pdev); + if (res) + goto err; + return res; err: sdhci_pltfm_free(pdev); clk_disable_unprepare(base_clk); -- 2.17.1