From: Sairaj Kodilkar <sarunkod@amd.com>
To: <qemu-devel@nongnu.org>
Cc: <mst@redhat.com>, <vasant.hegde@amd.com>,
<suravee.suthikulpanit@amd.com>,
Sairaj Kodilkar <sarunkod@amd.com>
Subject: [PATCH 1/2] amd_iommu: Use correct DTE field for interrupt passthrough
Date: Fri, 7 Feb 2025 10:23:53 +0530 [thread overview]
Message-ID: <20250207045354.27329-2-sarunkod@amd.com> (raw)
In-Reply-To: <20250207045354.27329-1-sarunkod@amd.com>
Interrupt passthrough is determine by the bits 191,190,187-184.
These bits are part of the 3rd quad word (i.e. index 2) in DTE. Hence
replace dte[3] by dte[2].
Fixes: b44159fe0 ("x86_iommu/amd: Add interrupt remap support when VAPIC is not enabled")
Signed-off-by: Sairaj Kodilkar <sarunkod@amd.com>
Reviewed-by: Vasant Hegde <vasant.hegde@amd.com>
---
hw/i386/amd_iommu.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
index 6b13ce894b1a..98f1209a3818 100644
--- a/hw/i386/amd_iommu.c
+++ b/hw/i386/amd_iommu.c
@@ -1309,15 +1309,15 @@ static int amdvi_int_remap_msi(AMDVIState *iommu,
ret = -AMDVI_IR_ERR;
break;
case AMDVI_IOAPIC_INT_TYPE_NMI:
- pass = dte[3] & AMDVI_DEV_NMI_PASS_MASK;
+ pass = dte[2] & AMDVI_DEV_NMI_PASS_MASK;
trace_amdvi_ir_delivery_mode("nmi");
break;
case AMDVI_IOAPIC_INT_TYPE_INIT:
- pass = dte[3] & AMDVI_DEV_INT_PASS_MASK;
+ pass = dte[2] & AMDVI_DEV_INT_PASS_MASK;
trace_amdvi_ir_delivery_mode("init");
break;
case AMDVI_IOAPIC_INT_TYPE_EINT:
- pass = dte[3] & AMDVI_DEV_EINT_PASS_MASK;
+ pass = dte[2] & AMDVI_DEV_EINT_PASS_MASK;
trace_amdvi_ir_delivery_mode("eint");
break;
default:
--
2.34.1
next prev parent reply other threads:[~2025-02-07 4:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-07 4:53 [PATCH v2 0/2] Emulated AMD IOMMU cleanup and fixes Sairaj Kodilkar
2025-02-07 4:53 ` Sairaj Kodilkar [this message]
2025-02-07 4:53 ` [PATCH 2/2] amd_iommu: Use correct bitmask to set capability BAR Sairaj Kodilkar
2025-02-07 4:59 ` [PATCH v2 0/2] Emulated AMD IOMMU cleanup and fixes Arun Kodilkar, Sairaj
2025-02-25 8:47 ` Michael Tokarev
2025-02-26 12:53 ` Vasant Hegde
2025-02-26 15:22 ` Michael Tokarev
2025-02-28 10:04 ` Vasant Hegde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250207045354.27329-2-sarunkod@amd.com \
--to=sarunkod@amd.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=suravee.suthikulpanit@amd.com \
--cc=vasant.hegde@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.