From: "Michael S. Tsirkin" <mst@redhat.com>
To: Eric Auger <eric.auger@redhat.com>
Cc: eric.auger.pro@gmail.com, qemu-devel@nongnu.org,
qemu-arm@nongnu.org, peter.maydell@linaro.org,
jasowang@redhat.com, imammedo@redhat.com, peterx@redhat.com,
alex.williamson@redhat.com, clg@redhat.com, philmd@linaro.org,
zhenzhong.duan@intel.com, ddutile@redhat.com
Subject: Re: [PATCH 0/5] Fix vIOMMU reset order
Date: Fri, 7 Feb 2025 06:09:56 -0500 [thread overview]
Message-ID: <20250207060822-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20250206142307.921070-1-eric.auger@redhat.com>
On Thu, Feb 06, 2025 at 03:21:51PM +0100, Eric Auger wrote:
> This is a follow-up of Peter's attempt to fix the fact that
> vIOMMUs are likely to be reset before the device they protect:
>
> [PATCH 0/4] intel_iommu: Reset vIOMMU after all the rest of devices
> https://lore.kernel.org/all/20240117091559.144730-1-peterx@redhat.com/
>
> This is especially observed with virtio devices when a qmp system_reset
> command is sent but also with VFIO devices.
>
> This series puts the vIOMMU reset in the 3-phase exit callback.
>
> This scheme was tested successful with virtio-devices and some
> VFIO devices. Nevertheless not all the topologies have been
> tested yet.
>
> Best Regards
>
> Eric
Looks good.
Acked-by: Michael S. Tsirkin <mst@redhat.com>
How should this be merged?
I supposed I can merge the 1st three and the other
two by the respective maintainers?
I don't think there's a dependency here, right?
> This series can be found at:
> https://github.com/eauger/qemu/tree/viommu-3phase-reset-v1
>
> Eric Auger (4):
> hw/virtio/virtio-iommu: Migrate to 3-phase reset
> hw/i386/intel-iommu: Migrate to 3-phase reset
> hw/arm/smmuv3: Move reset to exit phase
> hw/vfio/common: Add a trace point in vfio_reset_handler
>
> Peter Xu (1):
> hw/i386/intel_iommu: Tear down address spaces before IOMMU reset
>
> hw/arm/smmuv3.c | 9 +++++----
> hw/i386/intel_iommu.c | 10 ++++++----
> hw/vfio/common.c | 1 +
> hw/virtio/virtio-iommu.c | 9 +++++----
> hw/arm/trace-events | 1 +
> hw/i386/trace-events | 1 +
> hw/vfio/trace-events | 1 +
> hw/virtio/trace-events | 2 +-
> 8 files changed, 21 insertions(+), 13 deletions(-)
>
> --
> 2.47.1
next prev parent reply other threads:[~2025-02-07 11:10 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 14:21 [PATCH 0/5] Fix vIOMMU reset order Eric Auger
2025-02-06 14:21 ` [PATCH 1/5] hw/virtio/virtio-iommu: Migrate to 3-phase reset Eric Auger
2025-02-06 14:21 ` [PATCH 2/5] hw/i386/intel-iommu: " Eric Auger
2025-02-06 14:21 ` [PATCH 3/5] hw/i386/intel_iommu: Tear down address spaces before IOMMU reset Eric Auger
2025-02-17 3:02 ` Duan, Zhenzhong
2025-02-17 7:31 ` Eric Auger
2025-02-06 14:21 ` [PATCH 4/5] hw/arm/smmuv3: Move reset to exit phase Eric Auger
2025-02-07 16:37 ` Peter Maydell
2025-02-07 16:50 ` Eric Auger
2025-02-07 16:58 ` Peter Maydell
2025-02-07 17:47 ` Peter Xu
2025-02-07 18:18 ` Peter Maydell
2025-02-10 8:47 ` Eric Auger
2025-02-10 14:14 ` Peter Xu
2025-02-10 14:22 ` Peter Maydell
2025-02-12 17:28 ` Cédric Le Goater
2025-02-10 8:35 ` Eric Auger
2025-02-10 14:18 ` Peter Xu
2025-02-10 8:40 ` Eric Auger
2025-02-06 14:21 ` [PATCH 5/5] hw/vfio/common: Add a trace point in vfio_reset_handler Eric Auger
2025-02-07 17:18 ` Cédric Le Goater
2025-02-07 11:09 ` Michael S. Tsirkin [this message]
2025-02-07 16:40 ` [PATCH 0/5] Fix vIOMMU reset order Peter Maydell
2025-02-07 16:52 ` Eric Auger
2025-02-07 16:54 ` Peter Xu
2025-02-07 17:06 ` Peter Maydell
2025-02-07 17:31 ` Peter Xu
2025-02-10 8:45 ` Eric Auger
2025-02-07 17:25 ` Cédric Le Goater
2025-02-10 8:49 ` Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250207060822-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=clg@redhat.com \
--cc=ddutile@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=eric.auger@redhat.com \
--cc=imammedo@redhat.com \
--cc=jasowang@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.