From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7767EC02196 for ; Fri, 7 Feb 2025 10:25:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 3CFEE810A5; Fri, 7 Feb 2025 10:25:19 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 6gO4w1B2zOT0; Fri, 7 Feb 2025 10:25:18 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 5464C810A8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1738923918; bh=Lja0VEgMbAUT5aCxumJQSLEEY1cqyf8McBodGV/vQG4=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=SAgsXF/Zoe1Ee0eJ9PDqdx+iI8K5KKBnUxf75w4s5o2rG51lmQH2qh+jp/n3XN/g2 Ki0AWDq+6WpLdwYUKFs8KT9UvwY0TS78gjnRCFeIS8MRA86O3gOWwhVYjiz7opjoyD GZeBImF/laHbD/HswH7l8ZmqiIWWv3xYlYMTLPHCnqWFHPrr9FoiMRu2VPTLow7Iwc M9lVE9ywYNzYd0vwi8k7V88BynTfoBFQx+inJ/ge8lC1pQ6bzVJ0r3wajM8WWPjvQ9 822PYcNIVB3I4MyTMFdVnF07DW6ST09TmLJbWiwH0eIkVx0hWbqr/mGYm9nMc4MQTJ CymDUmf1hwjVw== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id 5464C810A8; Fri, 7 Feb 2025 10:25:18 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists1.osuosl.org (Postfix) with ESMTP id 697D9C0 for ; Fri, 7 Feb 2025 10:25:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 64A0E704C4 for ; Fri, 7 Feb 2025 10:25:17 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id mLNEPOoQik9n for ; Fri, 7 Feb 2025 10:25:16 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org ACDB2704D1 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org ACDB2704D1 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp3.osuosl.org (Postfix) with ESMTPS id ACDB2704D1 for ; Fri, 7 Feb 2025 10:25:16 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 394FF5C15C1; Fri, 7 Feb 2025 10:24:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 552F7C4CED1; Fri, 7 Feb 2025 10:25:14 +0000 (UTC) Date: Fri, 7 Feb 2025 10:25:12 +0000 From: Simon Horman To: Piotr Kwapulinski Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, Dan Carpenter , Michal Swiatkowski , Przemek Kitszel Message-ID: <20250207102512.GN554665@kernel.org> References: <20250206151920.20292-1-piotr.kwapulinski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250206151920.20292-1-piotr.kwapulinski@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738923915; bh=I2q0FoV43+9sH+XTQuRkQL4F9g4e1iWfAdsRC+49Rpw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cwUMJ7zMM+LqXh/1XBLgwPWA2922Qjx9EaIefT3IyK8iyef3+dC5dK5MSLYLV7Htc uBkZdLYHjVHmLkvmyieVbnJr007LXnohmpBfd/4L6dl5ZRaGc/o5QFvwJAz2Y6NNfA HbIkZZyMGSXQN4f5f1j+oqXr++zFaGkbfP6KMTDHeMluD2IKsWkjTNAVuJgtevx9kD U+efDr2k5tvQsnWEhMl9WAGcY0nRiRj2Il3//rVXBCCeVMX5KL01YURu94IRkBbAl8 WRLeu/PBukt5MMoJwtRYrYuE0mEPDE/fl7Yv9ozJ3gW+bZ004slDKD7Wq+0LjQw+yr 9uGjv9Ji6ABYQ== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=cwUMJ7zM Subject: Re: [Intel-wired-lan] [PATCH iwl-net] ixgbe: fix media cage present detection for E610 device X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thu, Feb 06, 2025 at 04:19:20PM +0100, Piotr Kwapulinski wrote: > The commit 23c0e5a16bcc ("ixgbe: Add link management support for E610 > device") introduced incorrect checking of media cage presence for E610 > device. Fix it. > > Fixes: 23c0e5a16bcc ("ixgbe: Add link management support for E610 device") > Reported-by: Dan Carpenter > Closes: https://lore.kernel.org/all/e7d73b32-f12a-49d1-8b60-1ef83359ec13@stanley.mountain/ > Reviewed-by: Michal Swiatkowski > Reviewed-by: Przemek Kitszel > Signed-off-by: Piotr Kwapulinski Reviewed-by: Simon Horman From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 309B780BFF for ; Fri, 7 Feb 2025 10:25:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738923916; cv=none; b=tZ7/QXDXWTeWaUp+IEay89QkhoJqWeoMjlKkS8aM15qNEgKP28j4qvd+qor9kzBMohZsoIqUJsUGh7TaFZSo/q6mMLDBt7hUGgVfLxBkY6TDQWAwclFK9xTYhn5IWnxVyzNoFMlEUp7BbaDGiWlbPGIrWl1U6+EwvarnEcTkHvw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738923916; c=relaxed/simple; bh=I2q0FoV43+9sH+XTQuRkQL4F9g4e1iWfAdsRC+49Rpw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WeLMQF147Njc85F8/OaDuZk6F9FV2/lazNiD7SfGabiClv6CSh/aV/267y7cLW9zEos/3sUasjkhf3KWZ4AeJIHToSop0JPew9QuDr2VLvUo0n+/FDBn2/fSPqraqqanWP7XiOuLql5imf1FTXED2Jw0zsn15NecQ8ppbY3hRQM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cwUMJ7zM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cwUMJ7zM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 552F7C4CED1; Fri, 7 Feb 2025 10:25:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738923915; bh=I2q0FoV43+9sH+XTQuRkQL4F9g4e1iWfAdsRC+49Rpw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cwUMJ7zMM+LqXh/1XBLgwPWA2922Qjx9EaIefT3IyK8iyef3+dC5dK5MSLYLV7Htc uBkZdLYHjVHmLkvmyieVbnJr007LXnohmpBfd/4L6dl5ZRaGc/o5QFvwJAz2Y6NNfA HbIkZZyMGSXQN4f5f1j+oqXr++zFaGkbfP6KMTDHeMluD2IKsWkjTNAVuJgtevx9kD U+efDr2k5tvQsnWEhMl9WAGcY0nRiRj2Il3//rVXBCCeVMX5KL01YURu94IRkBbAl8 WRLeu/PBukt5MMoJwtRYrYuE0mEPDE/fl7Yv9ozJ3gW+bZ004slDKD7Wq+0LjQw+yr 9uGjv9Ji6ABYQ== Date: Fri, 7 Feb 2025 10:25:12 +0000 From: Simon Horman To: Piotr Kwapulinski Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, Dan Carpenter , Michal Swiatkowski , Przemek Kitszel Subject: Re: [PATCH iwl-net] ixgbe: fix media cage present detection for E610 device Message-ID: <20250207102512.GN554665@kernel.org> References: <20250206151920.20292-1-piotr.kwapulinski@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250206151920.20292-1-piotr.kwapulinski@intel.com> On Thu, Feb 06, 2025 at 04:19:20PM +0100, Piotr Kwapulinski wrote: > The commit 23c0e5a16bcc ("ixgbe: Add link management support for E610 > device") introduced incorrect checking of media cage presence for E610 > device. Fix it. > > Fixes: 23c0e5a16bcc ("ixgbe: Add link management support for E610 device") > Reported-by: Dan Carpenter > Closes: https://lore.kernel.org/all/e7d73b32-f12a-49d1-8b60-1ef83359ec13@stanley.mountain/ > Reviewed-by: Michal Swiatkowski > Reviewed-by: Przemek Kitszel > Signed-off-by: Piotr Kwapulinski Reviewed-by: Simon Horman