From: Jakub Kicinski <kuba@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v3 2/2] net: phy: dp83tg720: Add randomized polling intervals for unstable link detection
Date: Fri, 7 Feb 2025 16:34:21 -0800 [thread overview]
Message-ID: <20250207163421.0a1122ec@kernel.org> (raw)
In-Reply-To: <20250206093902.3331832-3-o.rempel@pengutronix.de>
On Thu, 6 Feb 2025 10:39:02 +0100 Oleksij Rempel wrote:
> +static unsigned int dp83tg720_phy_get_next_update_time(struct phy_device *phydev)
over 80 chars, why did you decide to put the word "phy" into this
function name
> + /* When the link is up, use a fixed 1000ms interval (in jiffies) */
comment over 80 chars
prev parent reply other threads:[~2025-02-08 0:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 9:39 [PATCH net-next v3 0/2] Use PHYlib for reset randomization and adjustable polling Oleksij Rempel
2025-02-06 9:39 ` [PATCH net-next v3 1/2] net: phy: Add support for driver-specific next update time Oleksij Rempel
2025-02-08 0:31 ` Jakub Kicinski
2025-02-09 23:33 ` Andrew Lunn
2025-02-06 9:39 ` [PATCH net-next v3 2/2] net: phy: dp83tg720: Add randomized polling intervals for unstable link detection Oleksij Rempel
2025-02-08 0:34 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250207163421.0a1122ec@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.