From: Jakub Kicinski <kuba@kernel.org>
To: Thorsten Scherer <t.scherer@eckelmann.de>
Cc: netdev@vger.kernel.org, Woojung Huh <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
kernel@pengutronix.de
Subject: Re: [PATCH] net: dsa: microchip: KSZ8563 register regmap alignment to 32 bit boundaries
Date: Fri, 7 Feb 2025 17:00:37 -0800 [thread overview]
Message-ID: <20250207170037.06d853af@kernel.org> (raw)
In-Reply-To: <20250206122246.58115-1-t.scherer@eckelmann.de>
On Thu, 6 Feb 2025 13:22:45 +0100 Thorsten Scherer wrote:
> - regmap_reg_range(0x1122, 0x1127),
> - regmap_reg_range(0x112a, 0x112b),
> - regmap_reg_range(0x1136, 0x1139),
> - regmap_reg_range(0x113e, 0x113f),
> + regmap_reg_range(0x1120, 0x112b),
> + regmap_reg_range(0x1134, 0x113b),
> + regmap_reg_range(0x113c, 0x113f),
can these two not be merged?
> regmap_reg_range(0x1400, 0x1401),
> regmap_reg_range(0x1403, 0x1403),
> regmap_reg_range(0x1410, 0x1417),
> @@ -747,10 +746,9 @@ static const struct regmap_range ksz8563_valid_regs[] = {
> regmap_reg_range(0x2030, 0x2030),
> regmap_reg_range(0x2100, 0x2111),
> regmap_reg_range(0x211a, 0x211d),
> - regmap_reg_range(0x2122, 0x2127),
> - regmap_reg_range(0x212a, 0x212b),
> - regmap_reg_range(0x2136, 0x2139),
> - regmap_reg_range(0x213e, 0x213f),
> + regmap_reg_range(0x2120, 0x212b),
> + regmap_reg_range(0x2134, 0x213b),
> + regmap_reg_range(0x213c, 0x213f),
and these?
--
pw-bot: cr
next prev parent reply other threads:[~2025-02-08 1:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 12:22 [PATCH] net: dsa: microchip: KSZ8563 register regmap alignment to 32 bit boundaries Thorsten Scherer
2025-02-08 1:00 ` Jakub Kicinski [this message]
2025-02-10 17:13 ` Thorsten Scherer
2025-02-10 17:50 ` Tristram.Ha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250207170037.06d853af@kernel.org \
--to=kuba@kernel.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux@rasmusvillemoes.dk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=t.scherer@eckelmann.de \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.