From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D477D2A1D8; Fri, 7 Feb 2025 17:36:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738949820; cv=none; b=GL+w+0ejQq2MWnA3tR8ZyOlDdbwy+TsOSqS8spbNG07YGvVzcdZecpmpVKqwcgZ3cbfnH+oJqi3cwYi5Me+TDmYOfbB4hhCNZuS5HjRB3bV056x+tNRqY/iZjYpqFGRfUOfPjZetoLqq5851OAvL4AcOVY8D6H4io3pZ3cswBqk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738949820; c=relaxed/simple; bh=fcpm8zPo3t6of/QhUdAYAl07owRMtxY3+gOrEtI6YWw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fY2DDaJolrDbX+2hsjEKbpojvFS4MTp5YXlGSxjSD5RVoj1AqshHJFR4sH3RfJZr+eiE1yBQV/VigPBZPfDb+j+aUGoiqn0cD8TwceGgRFO5QRfA/Zjc1/tWsrvGKNb7QI/pmp04LDlBw5pyIwFz0qmgVf3h39UANpFyw3Kbl9o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=exoVW02j; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="exoVW02j" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1738949815; bh=fcpm8zPo3t6of/QhUdAYAl07owRMtxY3+gOrEtI6YWw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=exoVW02jeexZbuX6mheZygHMwFFf+/EVtzbAUB74lRSEEJFBEYxPjYKEDzndF5JDY X1k8Z9+gNFuw6g7TiNF0RjWtkJvyMkB3zBgO+g76aYEECEz7SZt44mSps9XppaAwiO 6Bi/H8XlfziQ64dS7BCZa+q8lM4HICX4/LiLh+68X0ZgGfnAdUiJN+yuo2HGSrGEjK OV/v/0pnyoEDH+ElvroIgHM3Yc+2/lvucEBAyttMIB4SfeXK4MQ52qAAlElY/b01rz PqNRMtI/iGM0U5DNp1l9vPGdXiDVa4rl0Bp8MoVIblLppA8pcEb/48bDeuHOE1PeyD Usc5bfC34ASKQ== Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id 1FDB217E02AF; Fri, 7 Feb 2025 18:36:55 +0100 (CET) Date: Fri, 7 Feb 2025 18:36:47 +0100 From: Boris Brezillon To: "Rob Herring (Arm)" Cc: Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?B?QmrDtnJu?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Beata Michalska , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org Subject: Re: [PATCH] drm/panthor: Convert IOCTL defines to an enum Message-ID: <20250207183647.2bc1e5ed@collabora.com> In-Reply-To: <20250204232824.3819437-1-robh@kernel.org> References: <20250204232824.3819437-1-robh@kernel.org> Organization: Collabora X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 4 Feb 2025 17:28:24 -0600 "Rob Herring (Arm)" wrote: > Use an enum instead of #defines for panthor IOCTLs. This allows the > header to be used with Rust code as bindgen can't handle complex > defines. > > Cc: Beata Michalska > Signed-off-by: Rob Herring (Arm) Queued to drm-misc-next. > --- > include/uapi/drm/panthor_drm.h | 86 +++++++++++++++++----------------- > 1 file changed, 44 insertions(+), 42 deletions(-) > > diff --git a/include/uapi/drm/panthor_drm.h b/include/uapi/drm/panthor_drm.h > index b99763cbae48..97e2c4510e69 100644 > --- a/include/uapi/drm/panthor_drm.h > +++ b/include/uapi/drm/panthor_drm.h > @@ -129,48 +129,6 @@ enum drm_panthor_ioctl_id { > DRM_PANTHOR_TILER_HEAP_DESTROY, > }; > > -/** > - * DRM_IOCTL_PANTHOR() - Build a Panthor IOCTL number > - * @__access: Access type. Must be R, W or RW. > - * @__id: One of the DRM_PANTHOR_xxx id. > - * @__type: Suffix of the type being passed to the IOCTL. > - * > - * Don't use this macro directly, use the DRM_IOCTL_PANTHOR_xxx > - * values instead. > - * > - * Return: An IOCTL number to be passed to ioctl() from userspace. > - */ > -#define DRM_IOCTL_PANTHOR(__access, __id, __type) \ > - DRM_IO ## __access(DRM_COMMAND_BASE + DRM_PANTHOR_ ## __id, \ > - struct drm_panthor_ ## __type) > - > -#define DRM_IOCTL_PANTHOR_DEV_QUERY \ > - DRM_IOCTL_PANTHOR(WR, DEV_QUERY, dev_query) > -#define DRM_IOCTL_PANTHOR_VM_CREATE \ > - DRM_IOCTL_PANTHOR(WR, VM_CREATE, vm_create) > -#define DRM_IOCTL_PANTHOR_VM_DESTROY \ > - DRM_IOCTL_PANTHOR(WR, VM_DESTROY, vm_destroy) > -#define DRM_IOCTL_PANTHOR_VM_BIND \ > - DRM_IOCTL_PANTHOR(WR, VM_BIND, vm_bind) > -#define DRM_IOCTL_PANTHOR_VM_GET_STATE \ > - DRM_IOCTL_PANTHOR(WR, VM_GET_STATE, vm_get_state) > -#define DRM_IOCTL_PANTHOR_BO_CREATE \ > - DRM_IOCTL_PANTHOR(WR, BO_CREATE, bo_create) > -#define DRM_IOCTL_PANTHOR_BO_MMAP_OFFSET \ > - DRM_IOCTL_PANTHOR(WR, BO_MMAP_OFFSET, bo_mmap_offset) > -#define DRM_IOCTL_PANTHOR_GROUP_CREATE \ > - DRM_IOCTL_PANTHOR(WR, GROUP_CREATE, group_create) > -#define DRM_IOCTL_PANTHOR_GROUP_DESTROY \ > - DRM_IOCTL_PANTHOR(WR, GROUP_DESTROY, group_destroy) > -#define DRM_IOCTL_PANTHOR_GROUP_SUBMIT \ > - DRM_IOCTL_PANTHOR(WR, GROUP_SUBMIT, group_submit) > -#define DRM_IOCTL_PANTHOR_GROUP_GET_STATE \ > - DRM_IOCTL_PANTHOR(WR, GROUP_GET_STATE, group_get_state) > -#define DRM_IOCTL_PANTHOR_TILER_HEAP_CREATE \ > - DRM_IOCTL_PANTHOR(WR, TILER_HEAP_CREATE, tiler_heap_create) > -#define DRM_IOCTL_PANTHOR_TILER_HEAP_DESTROY \ > - DRM_IOCTL_PANTHOR(WR, TILER_HEAP_DESTROY, tiler_heap_destroy) > - > /** > * DOC: IOCTL arguments > */ > @@ -1019,6 +977,50 @@ struct drm_panthor_tiler_heap_destroy { > __u32 pad; > }; > > +/** > + * DRM_IOCTL_PANTHOR() - Build a Panthor IOCTL number > + * @__access: Access type. Must be R, W or RW. > + * @__id: One of the DRM_PANTHOR_xxx id. > + * @__type: Suffix of the type being passed to the IOCTL. > + * > + * Don't use this macro directly, use the DRM_IOCTL_PANTHOR_xxx > + * values instead. > + * > + * Return: An IOCTL number to be passed to ioctl() from userspace. > + */ > +#define DRM_IOCTL_PANTHOR(__access, __id, __type) \ > + DRM_IO ## __access(DRM_COMMAND_BASE + DRM_PANTHOR_ ## __id, \ > + struct drm_panthor_ ## __type) > + > +enum { > + DRM_IOCTL_PANTHOR_DEV_QUERY = > + DRM_IOCTL_PANTHOR(WR, DEV_QUERY, dev_query), > + DRM_IOCTL_PANTHOR_VM_CREATE = > + DRM_IOCTL_PANTHOR(WR, VM_CREATE, vm_create), > + DRM_IOCTL_PANTHOR_VM_DESTROY = > + DRM_IOCTL_PANTHOR(WR, VM_DESTROY, vm_destroy), > + DRM_IOCTL_PANTHOR_VM_BIND = > + DRM_IOCTL_PANTHOR(WR, VM_BIND, vm_bind), > + DRM_IOCTL_PANTHOR_VM_GET_STATE = > + DRM_IOCTL_PANTHOR(WR, VM_GET_STATE, vm_get_state), > + DRM_IOCTL_PANTHOR_BO_CREATE = > + DRM_IOCTL_PANTHOR(WR, BO_CREATE, bo_create), > + DRM_IOCTL_PANTHOR_BO_MMAP_OFFSET = > + DRM_IOCTL_PANTHOR(WR, BO_MMAP_OFFSET, bo_mmap_offset), > + DRM_IOCTL_PANTHOR_GROUP_CREATE = > + DRM_IOCTL_PANTHOR(WR, GROUP_CREATE, group_create), > + DRM_IOCTL_PANTHOR_GROUP_DESTROY = > + DRM_IOCTL_PANTHOR(WR, GROUP_DESTROY, group_destroy), > + DRM_IOCTL_PANTHOR_GROUP_SUBMIT = > + DRM_IOCTL_PANTHOR(WR, GROUP_SUBMIT, group_submit), > + DRM_IOCTL_PANTHOR_GROUP_GET_STATE = > + DRM_IOCTL_PANTHOR(WR, GROUP_GET_STATE, group_get_state), > + DRM_IOCTL_PANTHOR_TILER_HEAP_CREATE = > + DRM_IOCTL_PANTHOR(WR, TILER_HEAP_CREATE, tiler_heap_create), > + DRM_IOCTL_PANTHOR_TILER_HEAP_DESTROY = > + DRM_IOCTL_PANTHOR(WR, TILER_HEAP_DESTROY, tiler_heap_destroy), > +}; > + > #if defined(__cplusplus) > } > #endif