Re: [PATCH v4 4/6] mm/damon: introduce DAMOS filter type hugepage

[SeongJae Park <sj@kernel.org>]

On Fri, 7 Feb 2025 18:22:04 +0000 Usama Arif <usamaarif642@gmail.com> wrote:

> 
> 
> On 04/02/2025 23:12, SeongJae Park wrote:
> > On Mon,  3 Feb 2025 22:55:31 +0000 Usama Arif <usamaarif642@gmail.com> wrote:
> > 
> > 
> >> +	case DAMOS_FILTER_TYPE_HUGEPAGE:
> >> +		folio_sz = folio_size(folio);
> >> +		matched = filter->folio_size.min <= folio_sz && folio_sz <= filter->folio_size.max;
> > 
> > We should also return 'false' if the folio is not a large folio (folio_sz ==
> > PAGE_SIZE), if we agreed to my suggestion on the previous version of this patch
> > series?
> > 
> 
> Thanks SJ for the reviews.

The pleasure is mine!

> 
> I will address all of the changes in the next revision.

Looking forward to :)

> The only thing over here is, I would
> like the filter to work for folios of all sizes, even PAGE_SIZE. It would give us a more convenient
> way of knowing if hot regions are mainly being backed by 4K pages, and improve observability.
> Let me know if thats ok?

I have no strong opinion here.  Unless others have concerns, I'm ok with your
approach.


Thanks,
SJ