From: kernel test robot <lkp@intel.com>
To: Gabriele Monaco <gmonaco@redhat.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [RFC PATCH 04/11] rv: Add option for nested monitors and include sched
Date: Sun, 9 Feb 2025 00:26:45 +0800 [thread overview]
Message-ID: <202502090006.mpaCJjXx-lkp@intel.com> (raw)
In-Reply-To: <20250206080952.98478-5-gmonaco@redhat.com>
Hi Gabriele,
[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:
[auto build test WARNING on 5c8c229261f14159b54b9a32f12e5fa89d88b905]
url: https://github.com/intel-lab-lkp/linux/commits/Gabriele-Monaco/tracing-Fix-DECLARE_TRACE_CONDITION/20250206-161349
base: 5c8c229261f14159b54b9a32f12e5fa89d88b905
patch link: https://lore.kernel.org/r/20250206080952.98478-5-gmonaco%40redhat.com
patch subject: [RFC PATCH 04/11] rv: Add option for nested monitors and include sched
config: i386-buildonly-randconfig-003-20250207 (https://download.01.org/0day-ci/archive/20250209/202502090006.mpaCJjXx-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250209/202502090006.mpaCJjXx-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502090006.mpaCJjXx-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> kernel/trace/rv/rv.c:777: warning: Function parameter or struct member 'parent' not described in 'rv_register_monitor'
vim +777 kernel/trace/rv/rv.c
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 769
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 770 /**
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 771 * rv_register_monitor - register a rv monitor.
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 772 * @monitor: The rv_monitor to be registered.
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 773 *
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 774 * Returns 0 if successful, error otherwise.
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 775 */
cd664010e822b7 Gabriele Monaco 2025-02-06 776 int rv_register_monitor(struct rv_monitor *monitor, struct rv_monitor *parent)
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 @777 {
cd664010e822b7 Gabriele Monaco 2025-02-06 778 struct rv_monitor_def *r, *p = NULL;
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 779 int retval = 0;
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 780
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 781 if (strlen(monitor->name) >= MAX_RV_MONITOR_NAME_SIZE) {
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 782 pr_info("Monitor %s has a name longer than %d\n", monitor->name,
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 783 MAX_RV_MONITOR_NAME_SIZE);
cd664010e822b7 Gabriele Monaco 2025-02-06 784 return -EINVAL;
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 785 }
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 786
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 787 mutex_lock(&rv_interface_lock);
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 788
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 789 list_for_each_entry(r, &rv_monitors_list, list) {
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 790 if (strcmp(monitor->name, r->monitor->name) == 0) {
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 791 pr_info("Monitor %s is already registered\n", monitor->name);
cd664010e822b7 Gabriele Monaco 2025-02-06 792 retval = -EEXIST;
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 793 goto out_unlock;
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 794 }
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 795 }
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 796
cd664010e822b7 Gabriele Monaco 2025-02-06 797 if (parent) {
cd664010e822b7 Gabriele Monaco 2025-02-06 798 list_for_each_entry(r, &rv_monitors_list, list) {
cd664010e822b7 Gabriele Monaco 2025-02-06 799 if (strcmp(parent->name, r->monitor->name) == 0) {
cd664010e822b7 Gabriele Monaco 2025-02-06 800 p = r;
cd664010e822b7 Gabriele Monaco 2025-02-06 801 break;
cd664010e822b7 Gabriele Monaco 2025-02-06 802 }
cd664010e822b7 Gabriele Monaco 2025-02-06 803 }
cd664010e822b7 Gabriele Monaco 2025-02-06 804 }
cd664010e822b7 Gabriele Monaco 2025-02-06 805
cd664010e822b7 Gabriele Monaco 2025-02-06 806 if (p && rv_is_nested_monitor(p)) {
cd664010e822b7 Gabriele Monaco 2025-02-06 807 pr_info("Parent monitor %s is already nested, cannot nest further\n",
cd664010e822b7 Gabriele Monaco 2025-02-06 808 parent->name);
cd664010e822b7 Gabriele Monaco 2025-02-06 809 return -EINVAL;
cd664010e822b7 Gabriele Monaco 2025-02-06 810 }
cd664010e822b7 Gabriele Monaco 2025-02-06 811
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 812 r = kzalloc(sizeof(struct rv_monitor_def), GFP_KERNEL);
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 813 if (!r) {
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 814 retval = -ENOMEM;
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 815 goto out_unlock;
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 816 }
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 817
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 818 r->monitor = monitor;
cd664010e822b7 Gabriele Monaco 2025-02-06 819 r->parent = parent;
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 820
cd664010e822b7 Gabriele Monaco 2025-02-06 821 retval = create_monitor_dir(r, p);
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 822 if (retval) {
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 823 kfree(r);
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 824 goto out_unlock;
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 825 }
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 826
cd664010e822b7 Gabriele Monaco 2025-02-06 827 /* keep children close to the parent for easier visualisation */
cd664010e822b7 Gabriele Monaco 2025-02-06 828 if (p)
cd664010e822b7 Gabriele Monaco 2025-02-06 829 list_add(&r->list, &p->list);
cd664010e822b7 Gabriele Monaco 2025-02-06 830 else
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 831 list_add_tail(&r->list, &rv_monitors_list);
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 832
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 833 out_unlock:
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 834 mutex_unlock(&rv_interface_lock);
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 835 return retval;
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 836 }
102227b970a152 Daniel Bristot de Oliveira 2022-07-29 837
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-02-08 16:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 8:09 [RFC PATCH 00/11] rv: Add scheduler specification monitors Gabriele Monaco
2025-02-06 8:09 ` [RFC PATCH 01/11] tracing: Fix DECLARE_TRACE_CONDITION Gabriele Monaco
2025-02-06 8:09 ` [RFC PATCH 02/11] rv: Add license identifiers to monitor files Gabriele Monaco
2025-02-06 8:09 ` [RFC PATCH 03/11] sched: Add sched tracepoints for RV task model Gabriele Monaco
2025-02-06 8:19 ` Peter Zijlstra
2025-02-06 8:36 ` Gabriele Monaco
2025-02-06 8:57 ` Peter Zijlstra
2025-02-06 11:47 ` Gabriele Monaco
2025-02-06 13:36 ` Steven Rostedt
2025-02-06 8:09 ` [RFC PATCH 04/11] rv: Add option for nested monitors and include sched Gabriele Monaco
2025-02-08 16:26 ` kernel test robot [this message]
2025-02-06 8:09 ` [RFC PATCH 05/11] rv: Add sco and tss per-cpu monitors Gabriele Monaco
2025-02-06 8:09 ` [RFC PATCH 06/11] rv: Add snroc per-task monitor Gabriele Monaco
2025-02-06 8:09 ` [RFC PATCH 07/11] rv: Add scpd, snep and sncid per-cpu monitors Gabriele Monaco
2025-02-06 8:09 ` [RFC PATCH 08/11] tools/rv: Add support for nested monitors Gabriele Monaco
2025-02-06 8:09 ` [RFC PATCH 09/11] verification/dot2k: " Gabriele Monaco
2025-02-06 8:09 ` [RFC PATCH 10/11] Documentation/rv: Add docs for the sched monitors Gabriele Monaco
2025-02-06 8:09 ` [RFC PATCH 11/11] tools/rv: Allow rv list to filter for container Gabriele Monaco
2025-02-07 10:55 ` [RFC PATCH 00/11] rv: Add scheduler specification monitors Juri Lelli
2025-02-07 11:36 ` Gabriele Monaco
2025-02-07 14:27 ` Juri Lelli
2025-02-07 14:57 ` Gabriele Monaco
2025-02-10 12:56 ` Gabriele Monaco
2025-02-11 9:38 ` Juri Lelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202502090006.mpaCJjXx-lkp@intel.com \
--to=lkp@intel.com \
--cc=gmonaco@redhat.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.