From: alison.schofield@intel.com
To: nvdimm@lists.linux.dev
Cc: Michal Suchanek <msuchanek@suse.de>,
Alison Schofield <alison.schofield@intel.com>
Subject: [ndctl PATCH] cxl/json: remove prefix from tracefs.h #include
Date: Sun, 9 Feb 2025 10:03:46 -0800 [thread overview]
Message-ID: <20250209180348.1773179-1-alison.schofield@intel.com> (raw)
From: Michal Suchanek <msuchanek@suse.de>
Distros vary on whether tracefs.h is placed in {prefix}/libtracefs/
or {prefix}/tracefs/. Since the library ships with pkgconfig info
to determine the exact include path the #include statement can drop
the tracefs/ prefix.
This was previously found and fixed elsewhere:
a59866328ec5 ("cxl/monitor: fix include paths for tracefs and traceevent")
but was introduced anew with cxl media-error support in ndctl v80.
Reposted here from github pull request:
https://github.com/pmem/ndctl/pull/268/
[ alison: commit msg and log edits ]
Fixes: 9873123fce03 ("cxl/list: collect and parse media_error records")
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
Signed-off-by: Alison Schofield <alison.schofield@intel.com>
---
cxl/json.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cxl/json.c b/cxl/json.c
index 5066d3bed13f..e65bd803b706 100644
--- a/cxl/json.c
+++ b/cxl/json.c
@@ -9,7 +9,7 @@
#include <json-c/json.h>
#include <json-c/printbuf.h>
#include <ccan/short_types/short_types.h>
-#include <tracefs/tracefs.h>
+#include <tracefs.h>
#include "filter.h"
#include "json.h"
base-commit: 04815e5f8b87e02a4fb5a61aeebaa5cad25a15c3
--
2.37.3
next reply other threads:[~2025-02-09 18:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-09 18:03 alison.schofield [this message]
2025-02-11 17:14 ` [ndctl PATCH] cxl/json: remove prefix from tracefs.h #include Marc Herbert
2025-02-12 16:11 ` Dave Jiang
2025-03-03 19:59 ` Alison Schofield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250209180348.1773179-1-alison.schofield@intel.com \
--to=alison.schofield@intel.com \
--cc=msuchanek@suse.de \
--cc=nvdimm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.