From: kernel test robot <lkp@intel.com>
To: kernel@openeuler.org, Yang Yingliang <yangyingliang@huawei.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [openeuler:openEuler-1.0-LTS 1420/1420] mm/mem_reliable.c:272:5: sparse: sparse: symbol 'reliable_debug_handler' was not declared. Should it be static?
Date: Sun, 9 Feb 2025 20:23:48 +0800 [thread overview]
Message-ID: <202502092003.Ptadb8Sw-lkp@intel.com> (raw)
tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS
head: cc7cb040bd0afe96f1da94c9f21eda5a986510a5
commit: 851a3ff0b4de68403c9a344c3d5378aa590705b7 [1420/1420] mm: Introduce proc interface to control memory reliable features
config: arm64-randconfig-r131-20250208 (https://download.01.org/0day-ci/archive/20250209/202502092003.Ptadb8Sw-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 14.2.0
reproduce: (https://download.01.org/0day-ci/archive/20250209/202502092003.Ptadb8Sw-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502092003.Ptadb8Sw-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
mm/mem_reliable.c:52:14: sparse: sparse: restricted gfp_t degrades to integer
mm/mem_reliable.c:199:5: sparse: sparse: symbol 'reliable_limit_handler' was not declared. Should it be static?
>> mm/mem_reliable.c:272:5: sparse: sparse: symbol 'reliable_debug_handler' was not declared. Should it be static?
mm/mem_reliable.c:199:5: warning: no previous prototype for 'reliable_limit_handler' [-Wmissing-prototypes]
199 | int reliable_limit_handler(struct ctl_table *table, int write,
| ^~~~~~~~~~~~~~~~~~~~~~
mm/mem_reliable.c:272:5: warning: no previous prototype for 'reliable_debug_handler' [-Wmissing-prototypes]
272 | int reliable_debug_handler(struct ctl_table *table, int write,
| ^~~~~~~~~~~~~~~~~~~~~~
vim +/reliable_debug_handler +272 mm/mem_reliable.c
271
> 272 int reliable_debug_handler(struct ctl_table *table, int write,
273 void __user *buffer, size_t *length, loff_t *ppos)
274 {
275 unsigned long old_ctrl_bits, new_ctrl_bits;
276 static DEFINE_MUTEX(reliable_debug_mutex);
277 int ret;
278
279 mutex_lock(&reliable_debug_mutex);
280 old_ctrl_bits = mem_reliable_ctrl_bits;
281 ret = proc_doulongvec_minmax(table, write, buffer, length, ppos);
282 if (ret == 0 && write) {
283 if (mem_reliable_ctrl_bits > (1 << CTRL_BITS_SHIFT) - 1) {
284 mem_reliable_ctrl_bits = old_ctrl_bits;
285 mutex_unlock(&reliable_debug_mutex);
286
287 return -EINVAL;
288 }
289
290 new_ctrl_bits = mem_reliable_ctrl_bits;
291 mem_reliable_ctrl_bits = old_ctrl_bits;
292 if (!!test_bit(MEM_RELIABLE_ALL, &new_ctrl_bits))
293 mem_reliable_parse_ctrl_bits(new_ctrl_bits);
294 else
295 mem_reliable_disable_all();
296 }
297
298 mutex_unlock(&reliable_debug_mutex);
299
300 return ret;
301 }
302
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2025-02-09 12:24 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202502092003.Ptadb8Sw-lkp@intel.com \
--to=lkp@intel.com \
--cc=kernel@openeuler.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.