From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4B72262D11 for ; Mon, 10 Feb 2025 22:38:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227096; cv=none; b=KK8GtzsOEC5cAPctQjeZgG6w6HTuuNzstJsVV77BPryDQmg15VD11q9dfGCpb2mUbi5Lybz6a2SerSdMem5T8bb+jJ7pm/AFI7EK4RxFre98r0EuvpKbJrLo1RHXwpsARW1aay+5jTCMGNAV0vsyps3PqQ9cNnvkgJZJ0TQihi0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227096; c=relaxed/simple; bh=QtC6oLxmw2DvbNfS+XsWeQUt9WZBo54DTtz6cY2CdFQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KINSs26QmYyKy9eOoyN3a3ZufL0hsLtPzgjb9GaUsQz/rdM3x8EAg4ldduWPKK3EVjG6mVGAcDtCeg3ouGy5b9ynQ+4O/nNldRBd8bQA9eZ4wtezJqRMjW9D8x/0TgpWn0YaNFJ5sEaPhFzdtwTlCfpToWGIOErAVuTReYo5JP4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=zEC5uXyi; arc=none smtp.client-ip=209.85.167.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="zEC5uXyi" Received: by mail-oi1-f179.google.com with SMTP id 5614622812f47-3f3a6ee569cso484190b6e.0 for ; Mon, 10 Feb 2025 14:38:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227094; x=1739831894; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Rir37DR+dGjXzV88JkfAUftf+GWLKbTzx84djPKNaJM=; b=zEC5uXyiKhnWOqx5/A8Yv466JRMMJpfwQTn92/mpKZPcLRRpvvrtis3ZcZ8KXEs2bZ MYupPNSVfFZyhyW8mGDUXI7AkGkRPbwA5Ip8LRCzhWlJNwQ8JW1hHsZnwHNb90V0OYyN DyaeDXGZtV6R4og2AP/D+rqByz5AEqDCvkw+vDjbZOT/yDIPlpGbDsdU987VvJhNr3Rm LgUIQVTjmd6QOgHUUBpVWidY5H2scFqZbGYGkzFylqfteOf5Lui0VIZgYmrn9uwBVKfv iYI7mnqGc/V52O3qyFceLfV+fnXugHeokcmKk86QXw6q21/eBgjFmexD0j/GxKETOMKu KnJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227094; x=1739831894; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Rir37DR+dGjXzV88JkfAUftf+GWLKbTzx84djPKNaJM=; b=TZxAM3WYSQzFsmhrjDM5U9DBVgEvVYo0iLqF/E8G/34J7iKykiqxppyju0Ja9uEo5g nzU4lbhiWrWEx1RZgDLPrP78brJ3CutJSn0czBKqFfYK5Aa/4l4tLAfnL0GPxjTLS0y7 JqBExxKZ3Csw1kCOpln+7kWbGaEqTe/BDaKi7zgd53t5TRVHvkqUThicUNyDk26SSrE1 k1g382lB8cl6wMIS5puliwtcQ4RWc1fMa+j0Rn0W/PW2ZfCzFoC9rytCQVpuDFiBi9ni 8XDtVyY3SgspaxheiVcFpAyrSS3gG9t5Eyi6psryGNfibbVIZXf/hXVwO725cPpftWJ3 recA== X-Gm-Message-State: AOJu0YyPcfKf66rqhSulLppeFzbuaKFzxKs/DEF5v31LecV0Ys3LnS4M 5LLmQFaC379+d+tDLhosKNcrrJt+F6M3KcnXldg2nSWSlzZDOh8iSlSEa/vS1Hk= X-Gm-Gg: ASbGncsDgjgaTWQL11VMSaDFhaF7tQv0SW6UEnruQA0Hddj3u2DPg4HABQqYiEbzibF 4FTPuOs87uKM78UZWjQFdHuq5vmlwqHq1CKgQFouyU98yOCD/VpsSgXro0RJlaTckM2Grgnjg8D VtrlcL0mQ4wBYjcsgswwbK/guIsYOwUUwo4HS+2zZMhzIyX2PcsTl4fqsCLN+FhyRVtX0X2fO6J jZs5i9ho+SKxoDmY6UgiAkex/9pAZMi9oY23YhAJPjTHuStlwQ90m7AUeMyebwwJW7l8bWNvi8A DV2NBVqTG/L5hVDhLhbaHK/4Zm79zhfTY6hgWeJG/Gg1fIc= X-Google-Smtp-Source: AGHT+IEVAt15PQdS8DVNqyeJacSiAcXpbNeOp6OkG5/0y5b43SqHZC4XrUJm46YNpLSsnE3NWRVPBQ== X-Received: by 2002:a05:6808:150e:b0:3ea:519e:cc71 with SMTP id 5614622812f47-3f39242c9d0mr8056705b6e.39.1739227093792; Mon, 10 Feb 2025 14:38:13 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.38.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:38:12 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:40 -0600 Subject: [PATCH v3 14/15] phy: mapphone-mdm6600: use gpiod_multi_set_value_cansleep Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250210-gpio-set-array-helper-v3-14-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). ddata->cmd_gpios->ndescs is validated to be equal to PHY_MDM6600_NR_CMD_LINES during driver probe, so it will have the same value as the previously hard-coded argument. Reviewed-by: Linus Walleij Signed-off-by: David Lechner --- drivers/phy/motorola/phy-mapphone-mdm6600.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/phy/motorola/phy-mapphone-mdm6600.c b/drivers/phy/motorola/phy-mapphone-mdm6600.c index 152344e4f7e44de0f8ab1cae6ae01a1f1c5408e9..fd0e0cd1c1cfb10fb55ed271e47b6a0bf857028e 100644 --- a/drivers/phy/motorola/phy-mapphone-mdm6600.c +++ b/drivers/phy/motorola/phy-mapphone-mdm6600.c @@ -177,9 +177,7 @@ static void phy_mdm6600_cmd(struct phy_mdm6600 *ddata, int val) values[0] = val; - gpiod_set_array_value_cansleep(PHY_MDM6600_NR_CMD_LINES, - ddata->cmd_gpios->desc, - ddata->cmd_gpios->info, values); + gpiod_multi_set_value_cansleep(ddata->cmd_gpios, values); } /** -- 2.43.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8B98C021B0 for ; Mon, 10 Feb 2025 22:55:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=J2GMJRVXUlJ6uxL+2YFdZuz7FQgT7AmzR8OsNGToXLM=; b=2j196h7Foga4fN 2b7xZ+qxEGx2W0CgFNohiQNF924YK990xLnITNMG4piAgNnNTyrIVGXa2DQzItR46K6+2+PU6pOhf 6MdASIDboQZaHSG2lzWVp9VuBrbshhVrF5VGngKFs1hhCViTXHR5SGOUuw8sA73FUqNhO6yKTfqy7 cimzCmHrAsKFaR5Epv1OjHgp2lFT3HpZ/XwvSjF0AjnNdDH7Ibh+12suCPzuCYtfC+PUhoZ2iz+wE iP/Do4VyUG2Mp8NeDrJ/CsLvRKJzKDwEQFGkyynjufj19EwdcIPR59m11ngGv4YXkKLDRhEhAfWBv 5dx/2ev7AJBHWqeIRLQA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1thcgq-00000001kZc-2LzP; Mon, 10 Feb 2025 22:55:44 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thcPz-00000001gUD-2we6 for linux-phy@bombadil.infradead.org; Mon, 10 Feb 2025 22:38:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Sender:Reply-To:Content-ID:Content-Description; bh=Rir37DR+dGjXzV88JkfAUftf+GWLKbTzx84djPKNaJM=; b=RM15PzPojE1Y5ynmThVQsq04Mo XO4O2p493Nja9NcR+K/bOAn9V5x5TaRn+HCNNWq+4vqA75Xm+ETwaAOlaQ78bWcz5YV9ae3nKAD61 hqTmxvT2vWSn6SSuNpTXzfuqAWKHhcvhjS3MzYXDQwJ++vlDFpm7+1GZPsa3rO5hejrDZoEz4wFxh M1ywSsv6xtqKGMeehiC0/cpQlRLMy6XjNVpOfjZ8+YQPPLUsmMo2uMptU4L4o86kvx3kjdizIyX52 ZIKW23jO7kTov5O4jOSRGWGNBAvkY/QUNEGMNgFsWOxHQodwGQf7AeY1seFtCaOdc0sxeep3VPne8 wc2FC1mg==; Received: from mail-oi1-x22b.google.com ([2607:f8b0:4864:20::22b]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thcPw-00000000KU9-2kcy for linux-phy@lists.infradead.org; Mon, 10 Feb 2025 22:38:18 +0000 Received: by mail-oi1-x22b.google.com with SMTP id 5614622812f47-3f3a6ee569cso484187b6e.0 for ; Mon, 10 Feb 2025 14:38:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227094; x=1739831894; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Rir37DR+dGjXzV88JkfAUftf+GWLKbTzx84djPKNaJM=; b=KCno6SoPLXIjJf+kdmHw8rLawrfQKoTx1Pn4mp2hlRjF7H/XUMuq3VaWnnL6JtSgro FHTrKmDKzBhrmYzv9Cwla9DHJBqKuH2CB9hzyLNICOrblGewsmT3pk0mnm7pO5ZmTCWJ 9T+d22aHFdmsgvgb/SvN2IN8HsObd0tE4TZ0YeQvwuNOntxNEtNMEL2g+Pa5pGxFfpXC z/8K0QnLukXNvem6KpBFU9MXmovt3Axs5pP9rmasCUovAPTj3HVlAYWtV722KP6qP5rK V7wtytKs7wpl+NQYkfKPMOCDeGcsiTYMQFgGcBpfZD1pVyrEsx4DB5barJH6dL2NlngM Dnqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227094; x=1739831894; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Rir37DR+dGjXzV88JkfAUftf+GWLKbTzx84djPKNaJM=; b=EIbDWaA5LyX185dbNnzj37k9OAfRo+WK/tOOoOzIodgrToCasQ42eNfsm2BAQ7Z5KC yUN9jeVhU5EZClxguMbZ8rvweh9Pf1OT74RJemDMgGAI7EDWcOkhDPwQXBYtM5EQOGll JGwAg6ZmQPKAO6mGYq3pPubU/MjklvrAaD3qtiW3+GwTvmhO5kWdiwSgfAZqAlnaAmL4 bX6R3jya0b4WRK5DUOGN5v+pLSvsxCumh5mBC1y96zHLPK7tqYs9SIEvTLWsSZqWbiH9 5nok+R5NEhO8J7+HRci+nqXimsJTdN1Cs6+Mb3i9o+eifXGAKcAJbN5bPTBlrH/ctsXQ eQLA== X-Forwarded-Encrypted: i=1; AJvYcCU987+dgZLcLX9MbNsSPzFah0LUOwnxT6hqcc3ak4SWUkCUK7PapF0vfB5+/W+oyy5FVBI1PK8nb+A=@lists.infradead.org X-Gm-Message-State: AOJu0YxKcWN0uGTr3mbpudSG39RFpNVWaagk2Nccmr/fJ2chmESH9nhN ThESUt8AlShuQcy5eeGpVwUCFWY6b9NfgtQxuG8rOK9UaQHT+9viHVHgZMUfj8M= X-Gm-Gg: ASbGncstJMfYdmxMf0+5vUXfBRHd7JIQFMH9FlzuJvSdXUrEiPyf0488EhbCQw7h6k5 iAjARwAlE51CfH9bYOwUmiodgJv2Fyi74NEPgvN0LIVRiS3jq5y4XabvQP1KJJBqKTG6sE7IHN3 ziB2neDa/b3BfH3umgCgXDwO09XRBHNE6ky6gSnFz3F+8DfMIbk7PR7SGJqsDWMP4ibrnn1C4Bg ecLpEh9Ch+Gm/qEeuZ4Uv2uzbHsKntEIFuX3oSGKHDXg4tI8yE81vjXJiVdCgUM4yjX6g/buaM4 3YVje6tSn+W2bbur37TdujgIQpdUqSwoC7nRp7V+T46/gTU= X-Google-Smtp-Source: AGHT+IEVAt15PQdS8DVNqyeJacSiAcXpbNeOp6OkG5/0y5b43SqHZC4XrUJm46YNpLSsnE3NWRVPBQ== X-Received: by 2002:a05:6808:150e:b0:3ea:519e:cc71 with SMTP id 5614622812f47-3f39242c9d0mr8056705b6e.39.1739227093792; Mon, 10 Feb 2025 14:38:13 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.38.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:38:12 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:40 -0600 Subject: [PATCH v3 14/15] phy: mapphone-mdm6600: use gpiod_multi_set_value_cansleep MIME-Version: 1.0 Message-Id: <20250210-gpio-set-array-helper-v3-14-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250210_223817_004694_60333677 X-CRM114-Status: GOOD ( 11.68 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). ddata->cmd_gpios->ndescs is validated to be equal to PHY_MDM6600_NR_CMD_LINES during driver probe, so it will have the same value as the previously hard-coded argument. Reviewed-by: Linus Walleij Signed-off-by: David Lechner --- drivers/phy/motorola/phy-mapphone-mdm6600.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/phy/motorola/phy-mapphone-mdm6600.c b/drivers/phy/motorola/phy-mapphone-mdm6600.c index 152344e4f7e44de0f8ab1cae6ae01a1f1c5408e9..fd0e0cd1c1cfb10fb55ed271e47b6a0bf857028e 100644 --- a/drivers/phy/motorola/phy-mapphone-mdm6600.c +++ b/drivers/phy/motorola/phy-mapphone-mdm6600.c @@ -177,9 +177,7 @@ static void phy_mdm6600_cmd(struct phy_mdm6600 *ddata, int val) values[0] = val; - gpiod_set_array_value_cansleep(PHY_MDM6600_NR_CMD_LINES, - ddata->cmd_gpios->desc, - ddata->cmd_gpios->info, values); + gpiod_multi_set_value_cansleep(ddata->cmd_gpios, values); } /** -- 2.43.0 -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy