From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16333C02198 for ; Mon, 10 Feb 2025 14:58:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id A113C60B21; Mon, 10 Feb 2025 14:58:32 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id u5mHcEj3OYnt; Mon, 10 Feb 2025 14:58:32 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org F358360AFE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1739199512; bh=H2wexfijalRbRZgKoTXhkJl5A95n+GpaiTrJP70Z8u0=; h=Date:From:To:Cc:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=N8yBJDAy/meRYklQBbMMWhHVh05tDnVva1nVIL/vheGSNcWf+ApjpYO/c59IzkU/1 Y8lpFdv61SHNx0fvsZtwUe5Ps3wmvORZzg6hM+SNvtd7G+ZuRZPhHHtfEgAn8gVdBj GZO3rGdfQyx0AI+Ki39AUMp6jqHve2DLamxoB7uEfWxU4aMHsWTRZzmYbRrSoB5p+T krdV6v1NOBZi8j0pLsQWDJjmXYqJzRp8Asxa+vLqJcoTWMG8evIZDOudDovBQWF9IA Ufn1NWRM2J+0FYTLgxFfz3oKk29fCxvlLW3eUDUlJPG2a/7RvDllE4KKkaWP9FrZeq 3omTSdpK2qIIg== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id F358360AFE; Mon, 10 Feb 2025 14:58:31 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists1.osuosl.org (Postfix) with ESMTP id 8B0356C for ; Mon, 10 Feb 2025 14:58:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 7A2E2401D2 for ; Mon, 10 Feb 2025 14:58:30 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id X6mVvaB1jpkw for ; Mon, 10 Feb 2025 14:58:29 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2604:1380:45d1:ec00::3; helo=nyc.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 9FC6440197 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 9FC6440197 Received: from nyc.source.kernel.org (nyc.source.kernel.org [IPv6:2604:1380:45d1:ec00::3]) by smtp2.osuosl.org (Postfix) with ESMTPS id 9FC6440197 for ; Mon, 10 Feb 2025 14:58:29 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 47D61A4172A; Mon, 10 Feb 2025 14:56:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 284A7C4CED1; Mon, 10 Feb 2025 14:58:27 +0000 (UTC) Date: Mon, 10 Feb 2025 06:58:26 -0800 From: Jakub Kicinski To: Piotr Wejman Cc: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20250210065826.63a8822d@kernel.org> In-Reply-To: <20250208154350.75316-1-wejmanpm@gmail.com> References: <20250208154350.75316-1-wejmanpm@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739199507; bh=lNe0mZFoZDbbCnGKAeb7nhDZMeQMOeBsOMs6KbIvGMY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Pev92nibWQAIsa+j//NG3oi60URV8IstozxTcs9QE4oxHRTtEvFUiW0NJ8BYziZcO MRWyoBzpFe/1g9MuRVxlByBkXW5GzzvPkkS1LwFRcDqz6U5hRX4cQXQqi8CADuWgtm Uj7uIVnJ/b571wAy6F3nxPPolUNrsosgXvH+MvJPPLgxp16ygUwNWOdf964ZzTv8vP x51WXs3cVKQdODZamGOyaVVFqvVaANVJ7CCZEAg+JZAfqRO3r1WeGsrtZD3Rqitm+v 3H5QbJ/Q3FdQy1Mctmg02ijs5DUoEgjc+IrekhIVjGMmNv8EZu1EIGNF711NkIWtYf CngAr2r6LyYow== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=Pev92nib Subject: Re: [Intel-wired-lan] [PATCH v2] net: e1000e: convert to ndo_hwtstamp_get() and ndo_hwtstamp_set() X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Sat, 8 Feb 2025 16:43:49 +0100 Piotr Wejman wrote: > - if (!(adapter->flags & FLAG_HAS_HW_TIMESTAMP)) > + if (!(adapter->flags & FLAG_HAS_HW_TIMESTAMP)) { > + NL_SET_ERR_MSG(extack, "No HW timestamp support\n"); No new lines at the end of extack messages, please. User space adds its own line breaks. -- pw-bot: cr From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20D41237717; Mon, 10 Feb 2025 14:58:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739199508; cv=none; b=S+Jj3V+h0G/4A26TNRkWBg0pMwjQyD12fEBYMr8VojGo9qtH9CvKmcrL1GikOYSoejS9RaCqiCw+nhXhHbLZcIr8VyGiNiaTMezTCNBxwAnoO+ZZwOnR6YVxrm6MMcMp4BfLrKsrhNc1TlwD/3ASlKS2sV7Mr5Kx7uFZyWvR17M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739199508; c=relaxed/simple; bh=lNe0mZFoZDbbCnGKAeb7nhDZMeQMOeBsOMs6KbIvGMY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=tP6dD1bgyNPrcSZaqUYz5d1zglx0qUkZGD9UckWcfhtCTTR+waovDAwcb4uPxDfQYC11At9mwLU1apyC8UcRqyqpQJreGQZRQi0hsy68C/H19EDfnk/SoiWozuJTjTtnjjS/Qbw+IMCDBC/czKWHjoraxXysPhXqKIt/LvpFSoI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Pev92nib; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Pev92nib" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 284A7C4CED1; Mon, 10 Feb 2025 14:58:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739199507; bh=lNe0mZFoZDbbCnGKAeb7nhDZMeQMOeBsOMs6KbIvGMY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Pev92nibWQAIsa+j//NG3oi60URV8IstozxTcs9QE4oxHRTtEvFUiW0NJ8BYziZcO MRWyoBzpFe/1g9MuRVxlByBkXW5GzzvPkkS1LwFRcDqz6U5hRX4cQXQqi8CADuWgtm Uj7uIVnJ/b571wAy6F3nxPPolUNrsosgXvH+MvJPPLgxp16ygUwNWOdf964ZzTv8vP x51WXs3cVKQdODZamGOyaVVFqvVaANVJ7CCZEAg+JZAfqRO3r1WeGsrtZD3Rqitm+v 3H5QbJ/Q3FdQy1Mctmg02ijs5DUoEgjc+IrekhIVjGMmNv8EZu1EIGNF711NkIWtYf CngAr2r6LyYow== Date: Mon, 10 Feb 2025 06:58:26 -0800 From: Jakub Kicinski To: Piotr Wejman Cc: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net: e1000e: convert to ndo_hwtstamp_get() and ndo_hwtstamp_set() Message-ID: <20250210065826.63a8822d@kernel.org> In-Reply-To: <20250208154350.75316-1-wejmanpm@gmail.com> References: <20250208154350.75316-1-wejmanpm@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 8 Feb 2025 16:43:49 +0100 Piotr Wejman wrote: > - if (!(adapter->flags & FLAG_HAS_HW_TIMESTAMP)) > + if (!(adapter->flags & FLAG_HAS_HW_TIMESTAMP)) { > + NL_SET_ERR_MSG(extack, "No HW timestamp support\n"); No new lines at the end of extack messages, please. User space adds its own line breaks. -- pw-bot: cr