From: Jeevan B <jeevan.b@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: swati2.sharma@intel.com, Jeevan B <jeevan.b@intel.com>
Subject: [PATCH i-g-t] tests/intel/kms_pm_dc: Ensure eDP detection before skipping test
Date: Mon, 10 Feb 2025 16:06:19 +0530 [thread overview]
Message-ID: <20250210103619.1235820-1-jeevan.b@intel.com> (raw)
Ensure all outputs are checked before skipping the test, preventing
premature exits when an eDP is available later.
v2: Optimized eDP detection by merging loops.
Signed-off-by: Jeevan B <jeevan.b@intel.com>
---
tests/intel/kms_pm_dc.c | 40 ++++++++++++++++++++++++----------------
1 file changed, 24 insertions(+), 16 deletions(-)
diff --git a/tests/intel/kms_pm_dc.c b/tests/intel/kms_pm_dc.c
index 9551cc6b9..bbb29d7d9 100644
--- a/tests/intel/kms_pm_dc.c
+++ b/tests/intel/kms_pm_dc.c
@@ -640,30 +640,38 @@ static void test_deep_pkgc_state(data_t *data)
time_t delay;
enum pipe pipe;
bool pkgc_flag = false;
- bool flip = true;
+ bool flip = true, edp_found = false;
igt_display_t *display = &data->display;
igt_plane_t *primary;
igt_output_t *output = NULL;
for_each_pipe_with_valid_output(display, pipe, output) {
- if (output->config.connector->connector_type != DRM_MODE_CONNECTOR_eDP)
- igt_skip("No eDP output found, skipping the test.\n");
- /* Check VRR capabilities before setting up */
- if (igt_output_has_prop(output, IGT_CONNECTOR_VRR_CAPABLE) &&
- igt_output_get_prop(output, IGT_CONNECTOR_VRR_CAPABLE)) {
- /*
- * TODO: Add check for vmin = vmax = flipline if VRR enabled
- * when KMD allows for such capability.
- */
- igt_pipe_set_prop_value(display, pipe,
- IGT_CRTC_VRR_ENABLED, false);
- igt_assert(igt_display_try_commit_atomic(display,
- DRM_MODE_ATOMIC_ALLOW_MODESET,
- NULL) == 0);
- break;
+ if (output->config.connector->connector_type == DRM_MODE_CONNECTOR_eDP) {
+
+ edp_found = true;
+ /* Check VRR capabilities before setting up */
+ if (igt_output_has_prop(output, IGT_CONNECTOR_VRR_CAPABLE) &&
+ igt_output_get_prop(output, IGT_CONNECTOR_VRR_CAPABLE)) {
+ /*
+ * TODO: Add check for vmin = vmax = flipline if VRR enabled
+ * when KMD allows for such capability.
+ */
+ igt_pipe_set_prop_value(display, pipe,
+ IGT_CRTC_VRR_ENABLED, false);
+ igt_assert(igt_display_try_commit_atomic(display,
+ DRM_MODE_ATOMIC_ALLOW_MODESET,
+ NULL) == 0);
+ }
+ break;
}
}
+
+ if (!edp_found) {
+ igt_skip("No eDP output found, skipping the test.\n");
+ return;
+ }
+
igt_display_reset(display);
igt_output_set_pipe(output, pipe);
--
2.25.1
next reply other threads:[~2025-02-10 10:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 10:36 Jeevan B [this message]
2025-02-10 12:47 ` ✓ Xe.CI.BAT: success for tests/intel/kms_pm_dc: Ensure eDP detection before skipping test (rev2) Patchwork
2025-02-10 13:02 ` ✓ i915.CI.BAT: " Patchwork
2025-02-10 15:30 ` ✗ Xe.CI.Full: failure " Patchwork
2025-02-10 15:49 ` ✗ i915.CI.Full: " Patchwork
2025-02-18 10:12 ` [PATCH i-g-t] tests/intel/kms_pm_dc: Ensure eDP detection before skipping test Sharma, Swati2
-- strict thread matches above, loose matches on Subject: below --
2025-02-06 15:59 Jeevan B
2025-02-07 4:35 ` Samala, Pranay
2025-02-07 5:03 ` B, Jeevan
2025-02-07 14:55 ` Sharma, Swati2
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250210103619.1235820-1-jeevan.b@intel.com \
--to=jeevan.b@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=swati2.sharma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.