From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B8DCC02198 for ; Mon, 10 Feb 2025 16:45:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:message-id:in-reply-to:references: mime-version:content-transfer-encoding:subject:reply-to: sender:list-id:list-help:list-subscribe:list-unsubscribe: list-post:list-owner:list-archive; bh=LpnkJwX/bvfJbLQ1CddMO/tdMeWXnQ4rZAIETYJn6KU=; b=jxgPU8skIbZMAQ0yq7kKLgXtfMy4zQnwX8AL4ZkgVDU8/Ta6Jul9yGpv RdRwmPuON/o7yiM0QliixeSWRkiNWlKxXvxjHajZk8/lRJVe133iSeOPw 5e3mz3xi3dJCGfsAp+80VHz566rugfdQkeeajQEJ8mTRlnsLKG5dVLtbv g=; Authentication-Results: mail2-relais-roc.national.inria.fr; dkim=none (message not signed) header.i=none; spf=Pass smtp.mailfrom=cocci-owner@inria.fr; spf=None smtp.helo=postmaster@sympa.inria.fr Received-SPF: Pass (mail2-relais-roc.national.inria.fr: domain of cocci-owner@inria.fr designates 128.93.162.160 as permitted sender) identity=mailfrom; client-ip=128.93.162.160; receiver=mail2-relais-roc.national.inria.fr; envelope-from="cocci-owner@inria.fr"; x-sender="cocci-owner@inria.fr"; x-conformance=spf_only; x-record-type="v=spf1"; x-record-text="v=spf1 include:mailout.safebrands.com a:basic-mail.safebrands.com a:basic-mail01.safebrands.com a:basic-mail02.safebrands.com ip4:128.93.142.0/24 ip4:192.134.164.0/24 ip4:128.93.162.160 ip4:128.93.162.3 ip4:128.93.162.88 ip4:89.107.174.7 mx ~all" Received-SPF: None (mail2-relais-roc.national.inria.fr: no sender authenticity information available from domain of postmaster@sympa.inria.fr) identity=helo; client-ip=128.93.162.160; receiver=mail2-relais-roc.national.inria.fr; envelope-from="cocci-owner@inria.fr"; x-sender="postmaster@sympa.inria.fr"; x-conformance=spf_only X-IronPort-AV: E=Sophos;i="6.13,275,1732575600"; d="scan'208";a="207544914" Received: from prod-listesu18.inria.fr (HELO sympa.inria.fr) ([128.93.162.160]) by mail2-relais-roc.national.inria.fr with ESMTP; 10 Feb 2025 17:45:37 +0100 Received: by sympa.inria.fr (Postfix, from userid 20132) id 689F7E0D1F; Mon, 10 Feb 2025 17:45:37 +0100 (CET) Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) by sympa.inria.fr (Postfix) with ESMTPS id 5D5C1E0260 for ; Mon, 10 Feb 2025 17:45:33 +0100 (CET) IronPort-SDR: 67aa2d2d_QkER1oUEhkcOF3icHfIjf5aBq8ZtgweAdMrKxyYpQIJZC9Q 334fz3uYzp6vvlHIFXoYIr+3LtgJBe8Wit/VdHw== X-IPAS-Result: =?us-ascii?q?A0FUAgBALKpnhdlUsotaHQEBAQEJARIBBQUBQIFTgkSBV?= =?us-ascii?q?zMEC0iNUoZTgiSgIQEDAQ1EBAEBkA0CHgcBBDQTAQIEAQEBAQMCAwEBAQEBA?= =?us-ascii?q?RABAQUBAQECAQECBAYBAhABAQEBQEmGCIJiAYQABjo/EAsOOFYGE4MCgmUDs?= =?us-ascii?q?H2BNIEB4CGBSIhPAYVrhHcnG4INgUqCdT6LBwSCL4Fug0CkA0gKexwDWSwBV?= =?us-ascii?q?RMNCgsHBWFISAM1DAswFSMPgRQFNAo3OoINaUk6Ag0CNYIefIIrgiCCO4RDh?= =?us-ascii?q?EuFWIISgWADAxYSAYMheByETR1AAwsYDUgRLDcUG0RuB54FPIUqAZk0jhNro?= =?us-ascii?q?QSEJYRvnFdNl0OTD5h8o1N1hGaBfiOBXDMaCCgIgyJPHA/XByU1PAIHCwEBA?= =?us-ascii?q?wmQYYFLAQE?= IronPort-PHdr: A9a23:1p39nBQFM38jfyyDSpld+kzrm9psolSWAWYlg6HPa5pwe6iut67vI FbYra00ygOSB8ODs7kf27eJ++C4ACpcus/H6ChDOLV3FDY7yuwu3DYcSPafDkP6KPO4JwcbJ +9lEGFfwnegLEJOE9z/bVCB6le77DoVBwmtfVEtfre9FYHdldm42P6v8JPPfQpImCC9YbRvJ xmqsAndrMYbjIV8Jqor1hfFvnREdupVyG5oJ1+YghLw6tut8JJ5/Cldte8t+9RcXanmeqgzU KBVAikhP20p68LnsgXOQxGI6nUATGsdjwBGAxLC7BH0X5fxtjX1u+9g0ySEPsP4UK45Vy264 6hkVBHnhiEHNyUk8G7Mkcx/kLhboBO6qBNhxYPffZyYO+B/fqPZetMaWHZBU8NMXCFPHo+wc 40CBPcaMO1Gs4fyuUcBrRqmBQmtGuzvzCNIhmTr1qE+yugtDB3K0BAlE98IrX/arsj6NL0KX O67zKfG0yvOYe5V1zj/5ojGdR8uru2DU79rbcrcy1MiGx/fg1mMt4DoOS6e2OQXs2ic6uptT f+hi3I5pAFvvDevwNonhJXOhoIO1lDL6zh2wJooLtC/Uk57ZsWkEIdOuC6HK4t7WcwiQ2Zvu Cknz70GuIW7cDINyJQ9yB7ScvqKeJWH7Rz/TuieOyt4hG57d7KlgRa/6UmtxvP8WMWo01tHs i5In8TMuH0P1xLe5daKRud880qgxzqC0wLe5O5FLE46iafVJJ4vzqMwm5cOsEnOHiD7lFnwg aSLdUsk4vCl5/npb7jivJOQKo15hwLkPqktlcGzG/o0PhUMUmSD5OiwyKHv8Vf7TbhKlPE7l rfVvIraKMkYoKOyHhFY0oI+6xakEzepzs4Yk2QGLFNEZh2Kl5TlNlfTK/7iF/i/mU6jkDJzy vDGILLhBpLNI2Den7fvc7dx8VVcyA0uzdBF+51bFKsNIPHtVU/rstzXEBs5Pxazw+b9B9Vxz oIeWWSRDa+FKK7erFGF6+Y1L+WRZoIYuyzxJvsq6vL0k3M1hF0QcbGs3ZQNaXC4GvpmI1+eY XrpmtoPDHsEsBciQOHyll2NSjtdZ3SqUq0z+zw2EI2mDYDERo+whbyB3Ty7EodRZmBcBVCBC W3od4KfW/cQdi2dP9NhnycHVbe/UY8h0w+htAvgx7pgNOrU9TUUtZT429dt/e3ciQky9SBoD 8Say2yBUnl4nnkUSD8uwKB/vUt9x0+f3qh/n/NXCd1T6uhSUgY6MJ7c1/Z1B8rzWgLHZNeJS UypTs+oATErHZoNxIoialh8F52Ygxnd0jDiV7oYv7CCGp046K/VwXXrYc16ziCV+rMmigwdX sZROGvuvKlk6wXfG8adiUKCi6umaYwT2ynB8WaYi22UsxcLA0ZLTazZUCVHNQPtptPj6xaHF uf2YVxGGg5IyMrYb7BPdsWsl1JNAvHqJNXZZWu13Wa2HxeBgL2WP8LxY2tI+iLbBQAflhwLu 26cPF0kATy9rm7CJDNpEl7qYliq9vNx+zugVkFh9wiRdAV60qatvBschPiSUfQWi4k+g390t T9XHgOD9YfZDN2Mogt6OqJGboYn50xb2G7Fnw9wJJqtK+ZlnFFNOx9vsRbI0BN6Qp5FjdBsr H4uy19qLrmE1Vpaaz6C9Zz+JfvMLXTo9x3paKPM3FzaltGM9c/j8dwerFPu9EGsH0smqTB81 sVNlmGb7dPMBRYTVpT4VgA28QJ7rvfUeHt14YScznBqPaSu112Kk9s0GOsozAqhdNZDIeuFE gH1CcgTG8mpLqQjhVGoahsOOO0a+rQzOouqcP6P2ajjO+gF/nrul2Nc/I1xzmqD8C1wT+/Tm ZEfzLDQ3weKUSv9kEb0qtr+yshPYTAfGHb6yDCxXdUAIPQtLcBbVSH0epLko7c2z4TgUHNZ6 lO5UlYP2cvzPAGXc0S4xwpbk0IevX2gnyK8iT1yiTAg6KSFj0msi6zvcgQKPmlTSSxsl1Dpd MKPtetCCVaiTAp8qjHw6kH9y61av+J4NWaGW0BTYyX6M0lhX7G2u77EZNRAosBN020fQKGnb FaWR6So6QEdyD/uE3d2yzc8ezSrodP+hRMw2yqNaX10qnTeY8R5wxzSscfdSfBm1T0DXCBki DPTCzBQJvGR9M6P39fGu+G6DSe6U4FLNDPsxsWGvTe64mtjBVu+meqyk5vpC1py3Sj+3thsH SLGyXS0KrLR7PzvL+hEfBxWLgrz7M12H4Bl1Iwqi8QK3mMGi5mJ1XkKi2H+NZNcw622YHcWR DENysLY+22HkAU6dSPPnt2pECXBhJE4OJGzeSsO1zg47txWBavc97FCkSZv4xK5oQ/Xfflhj 2IYwPoq5mQdhrJs2kJlxSGcD7YOWEhAaHW3xlLRsID4/PkRPj/wIt3SnAJkkNusDa+PuFRZU Xf9INI5GDNoq994OxTK2WHy7YftfJ/Ra8gSv1uaiUSl7aAdJZQvm/4NnSciN3j6uChv8NQA1 Ulw17K46batfmpq+668AwUeMSf6MtkU4S3ggbp2ncuM2Y2rWJJ7FX9YOfmgBeLtCz8Uufn9Y ky1KgZk/2mROriKIyXK50Bho3fOCNasLX7CPn4C0dhuWDGeKVZZjQRSWy811M1cdEji1Inqd 0F34SoU71jzp05Xy+5mABL4V3/WuAaibjpnAIjaNhdd6RtOolvEKcHLpPwmBDlWp9fyyW7FY nzefQlDCnsFH1CJF0y2dKf7/sHOqqCZHrbscqGIO+jI8LcPEa7Undquytc0pm3dcJzQbj8yU 7thgxUmPzgxGtyFyWxTFmpLz2STP4jE+V+94nEl95zitqizHl20o9bSQ7pKbYc2p0/w3vrFb r/LwncgTFQQnpIUmy2SluBDjgdJ23k8K2f1SOYN7XafHuWOxudWF0BJMX0raJkRtPJkjFUVN JeJ1oOtjuwqyaBpbjUNHV35xJPzO5RWcTjmZAuVWBjXbeaNeGWTkZOwP//0SKUO3r8K70Hi4 G3LSx2/YzjaxTTiD0j9Y6YS0ET5dFRIsYW5OH6BEEDFS9TrIl2+Od5z13gtxKEsw2nNPigaO CR9dEVEqvuR6zlZi7NxAT4J6H0tNuSClyuDiouQYp8LrftmBDh1nONG8Tw7zbVS9iRNWP1yn mPbsNdvp1isluTHxCBgVVJCrTNChYTDuksHW+2R7p5bRXPN5w4A902cBQtMvNx4ENbi/aNd0 N7CkOT0MjgDu9PY8M0ABtTFfcKKNH1yVHihUDXQDQYDUXuqLTSG3B0bya7CsC3J6MJj9cuJ+ tJGULJQWV0rG+lPD01kGIZHO5JrRnY+lrXdiscU5H24pR2XRcNAv5mBWOjBZJenYDufk7RAY AMFhL3iKoFGfLbB4BQ3dFNZntH0MR/fWtdBpyx6KAgurxBX92NiQ2Ev80HocAWg5DkUD/H+z XtUwkNuJP8g8jvh+QJ9Pl3RuC45i1U8g/3pjy/XaznsNqy9G4JbESz5sw42KJyxEGMXJUWi2 EdjMjnDXbdYibBtIHtqhAHrspxKAfdATKdAbXf4KtmUau8u3FAarT+olxYvDQ7tBpxlmA4ra tirtX0Sg2qLjfY5K7OWP61U1FNdwKGDpCml0qY22gBMfy4w IronPort-Data: A9a23:ipM8VKMvvDLA8AfvrR1dk8FynXyQoLVcMsEvi/4bfWQNrUol3mZWn WIXXz2CbKnbMDbyKY8kadvgoUgO7ZCGnIBlQXM5pCpnJ55ogZqcVI7Bdi8cHAvLc5adFBo/h yk6QoOdRCzhZiaE/n9BCpC48T8mk/vgqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziLBVOSvU0 T/Ji5OZYQTNNwJcaDpOtvrZ8Us35pwehRtB1rAATaAT1LPhvyJNZH4vDfnZB2f1RIBSAtm7S 47rpF1u1j6xE78FU7tJo56jGqE4aua60Tum1hK6b5Ofbi1q/UTe5EqU2M00Mi+7gx3R9zx4J U4kWZaYEW/FNYWU8AgRvoUx/4iT8sSq9ZeeSUVTv/B/wGXKTjzi2uRTNnhqErMq0eNuEFpF3 vsxfWVlghCr34pawZq3RPYqncM+NsLmeoASoHdtyXfeF/lOrZLrGv6bo4YHjHFg2oYURKm2i 8kxMVKDaDz7WSYXb0kdK5Bros39iX74fzhZsxSSv6Vi+W/I0AF9zJDuPcDTd9jMQt9a9qqdj jieoDmlXkFLa7RzzxKc6E68m92MoR/RBohKPeSny+Nnvl2Mkzl75Bo+Dgbj/6nm0yZSQel3I Esf8SsGtrk37EXtT9/nXhT+rmTsg/IHc9ZeDKsh7xyXwaeS4AuDAGUACDlbZ7TKqfPaWxQm6 xiHhsLUPwUzn4OnYneE54yfhjSbbH19wXA5WQcISg4M4t/GqY41jw7SQtsLLEJTpoOvcd0X6 27WxBXSl4kuYdg3O7JXFG0rbhqgqIePVQko/A7aGGGo9AV0YMiifYPABbnnARRoc9nxorqp5 iFsdy2iAAYmVs3leMulG7RlIV1Rz6zZWAAweHY2d3Xbyxyj+mS4Yadb6yxkKUFiP64sIGCyM RaJ5FIKvs4JYxNGiJObharvUazGKoC+SbzYugz8N4oXCnSMXF7dpX82DaJu9zu8zRNEfV4D1 WezKpv0UyZFUMyLPRK7Xvoc1747jjsz333STp3ghxWh2vz2WZJmYeltDbd6VchgtPnsiFyMo 753aZDQoz0BC7KWX8Ui2dVIRbz8BSNgXciuwyGWH8bfSjdb9JYJUKOBmux+JNY4x8y4VI7gp xmAZ6OR83Kn7VWvFOlAQikLhGrHDMYl/0EodzchJ0ip0HUFaIOipvVXPZgucLVtsKQpwfdoR rNXM4+NE9ZeeAThoj49VJjaqJA9VRKJgQnVATGpTgJidLFdRivI2OTeQC3RyAc0ABGai+4Cs py79waCQZM8VwVoV8nXT/S0zmKOh3sWmcMsfk7yJ9VCJVfmq7Z7GnbMk/ZtHdAGLCvY4j7Lx jSHIAw5oNPVqNQf6+j5hqGjrqaoHdBhH0FcIXLp0LauOQTe/Uuh2YVmUu2YWRz8DUTaoL6DY 8dRxNHCaMw3pk5A6ddAIuw63JAA6MvKjJ4E6AZdRVHgTUmhU5FkKVm4hfh/jLVHnOJliFHnS 3C024doPJuSM5nYC38XHg0ua9qD2dwymjX/6fcUIl3w1BRo/YioAFljAB2RtBNzdLdFEpsp4 eMEiv4k7waSjhkLMNHfqgt282+KDGILUoR5l5U8LbLotDEWyQB5UcSBMhP13ZCBUMUTE08IJ jTPurHOqY4BzWX/cl0yN0P348xjubo0tip3kWAyf2aypoKdh9sc/gFgzjAsfwEEkjRFy71SP 0ZoBW1UJIKP3S1atOpebV+zBgsaJhu4+1Pw+XQNhmb2X0mlbU2TDWwfaMKm3lEVzHJYRRdfp Iqn8WfCVS2wWtPcxQ4wZBJVkOPiRtlP6QHyosCrMMCbFZ0cYzC+oKuRSUcXihngW+UduVbmo LR0weNOdqHLDy4cjKklAY28175LahSlJnRHcM5x7pEyAmDQVzGj6wegc3nrVJt2GMXL1kukB +hFBMFFDU2+3RnTiAErP/cHJrsskcM54NYHRKjQGlcHlLmitRtsjoPb83nvpW0sQug2q/0HF KHqS2ugHFCT1FxuoE2ciOlfO2G9X8sIWx2k4sCx79cyNswitMNCTBgM94Wa7lSvHilpxRa2h D/4RrT3yrViwLt8noG3HaRkAR61GOzJV++J0V6StthQZ4n1Lc7+kh4f8XvhHgVJPIk+X8Z8u qSNveXWgmLEnucSeELIl6aRE5Jm4Z2JY9NWFcbsPV9Ytyemc+390SspomyXB8RAr4JA25OBW QC9VvqVSfcUfNVsnFtudClUFkcmOZTdN6vPi3u0kKWRN0I7zwfCEdKA8E3pZ0F9cgsjGcX3K i3wisaUyuFolqZ+Lz5aOKg+GL59GkHpZoU+fd6otTW4MHihsmnfhpTczygf+RP5IVjaNv3l4 KD1ZAn0LzWzn6Dq8Ot3kaJPuj8vMXIsptVoI2w8/Yd6hQnvWSRCZa4YPI4dA55Zrj3q2duqL HvRZW8lEmPmUS4CbRz458/5UxyCAvAVfO30PSEt41jefhLe6Fls21e93nwID7ZKljrfICWPJ d8BvGb3IwK6z9dqSPwV6/j9hv1orh8fKrTk5mil+/EewT5HaVnJ6JClNAlATyrKF4fKjkqjy a0dWzVfWE/iIaLuOZ8IRpOWcS31eBvgyDIkaCaUhtHFtO13CQGGJOLXY4nO71HIUCjGyHPii 586q6thLl16AkAuhJY= IronPort-HdrOrdr: A9a23:V+WAaaqaOpLCApYOv9YiYTwaV5okeYIsimQD101hICG9vPb3qy nIpoV86faUskd3ZJhOo7290cW7LU80sKQFgrX5Xo3SODUO2lHJEGgK1+KLqFfd8m/Fh4xgPM xbEpSWZueeMbEDt7ee3DWF X-Talos-CUID: =?us-ascii?q?9a23=3AWQqrSGscgIe9K+iR9dTzmfua6IspTzrT1WbtGXb?= =?us-ascii?q?kJlhbY7iMWGSb06RNxp8=3D?= X-Talos-MUID: 9a23:gH5R/gT9FU1uEiXdRXT1ng1yKfUr35iEVkpVuMwZhtSJCyxvbmI= X-IronPort-Anti-Spam-Filtered: true X-IronPort-AV: E=Sophos;i="6.13,275,1732575600"; d="scan'208";a="207544897" X-MGA-submission: =?us-ascii?q?MDEXvzx+OX0uvETCUxgYFk5QX/fbzpl9F1FQvF?= =?us-ascii?q?pk1tlvAZpLUQx/vLytzq3aoSF6EbQCNyRNSBQ6AM0qkLcR8mEC98x3LI?= =?us-ascii?q?iEWpIWi96AxqdlbJW30GsiNEdf5Yck3+YnjrruSDXV+Ui6pGqWT6j0/L?= =?us-ascii?q?8U4QWsdHiQpFgc43F0xINwVA=3D=3D?= Received: from dfw.source.kernel.org ([139.178.84.217]) by mail2-smtp-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2025 17:45:32 +0100 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 0CEE95C06D4; Mon, 10 Feb 2025 16:44:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53627C4CED1; Mon, 10 Feb 2025 16:45:29 +0000 (UTC) Date: Mon, 10 Feb 2025 11:45:31 -0500 From: Steven Rostedt To: David Reaver Cc: Greg Kroah-Hartman , "Rafael J . Wysocki" , Danilo Krummrich , Christian Brauner , Alexander Viro , linux-fsdevel@vger.kernel.org, cocci@inria.fr, linux-kernel@vger.kernel.org Message-ID: <20250210114531.20ea15cf@gandalf.local.home> In-Reply-To: <20250210052039.144513-6-me@davidreaver.com> References: <20250210052039.144513-1-me@davidreaver.com> <20250210052039.144513-6-me@davidreaver.com> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [cocci] [RFC PATCH 5/6] debugfs: Manual fixes for incomplete Coccinelle conversions Reply-To: Steven Rostedt X-Loop: cocci@inria.fr X-Sequence: 2399 Errors-To: cocci-owner@inria.fr Precedence: list Precedence: bulk Sender: cocci-request@inria.fr X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: On Sun, 9 Feb 2025 21:20:25 -0800 David Reaver wrote: > --- a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h > +++ b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h > @@ -9,6 +9,7 @@ > #include > > struct intel_gt; > +#define debugfs_node dentry > > #define __GT_DEBUGFS_ATTRIBUTE_FOPS(__name) \ > static const struct file_operations __name ## _fops = { \ Why are you adding these defines? All files should be just including so that they can use either "dentry" or "debugfs_node" while you do he conversion. Then the last patch should just modify debugfs and debugfs.h and no other file should be touched. I'll comment on the last patch to explain what I was expecting to be done that should satisfy Al. -- Steve From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E37532566C6; Mon, 10 Feb 2025 16:45:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739205930; cv=none; b=Ddk/PoMUyf1pYY80l+7BS86IwmZPRfqDRk6GW0T9NsyCSj6Dg1z8TqXo/Sol7zJixTqDPtNAb3VreeaY2E2GjCPOLVR1MGoRvF9DVzoCm6eZI3ZXRFm99FbiLMPPTN6b6RlB3hSGcFsVHDgzGRtUQz1AW5S0U7nFbINRUzIGmSw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739205930; c=relaxed/simple; bh=bF+4FoPgASdI1wrJVM4rNBQc3DuiC7mNwZcdUEgoPxc=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qf5iYPi/QQSuisssW5xjbZHe9VHkWTBFNR6/ZHf1G+mjWvc3NW80Y27xW0l67usdT4x36NVx/LMpikrLCGRurGlqht82bmLTgvrnlXE+YThNHjs9xE4VIjTofI7ttB+np4fMvp0wmSdEt7wnDWT2N2SAb69jxGZjhvkurrquyfg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53627C4CED1; Mon, 10 Feb 2025 16:45:29 +0000 (UTC) Date: Mon, 10 Feb 2025 11:45:31 -0500 From: Steven Rostedt To: David Reaver Cc: Greg Kroah-Hartman , "Rafael J . Wysocki" , Danilo Krummrich , Christian Brauner , Alexander Viro , linux-fsdevel@vger.kernel.org, cocci@inria.fr, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 5/6] debugfs: Manual fixes for incomplete Coccinelle conversions Message-ID: <20250210114531.20ea15cf@gandalf.local.home> In-Reply-To: <20250210052039.144513-6-me@davidreaver.com> References: <20250210052039.144513-1-me@davidreaver.com> <20250210052039.144513-6-me@davidreaver.com> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 9 Feb 2025 21:20:25 -0800 David Reaver wrote: > --- a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h > +++ b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h > @@ -9,6 +9,7 @@ > #include > > struct intel_gt; > +#define debugfs_node dentry > > #define __GT_DEBUGFS_ATTRIBUTE_FOPS(__name) \ > static const struct file_operations __name ## _fops = { \ Why are you adding these defines? All files should be just including so that they can use either "dentry" or "debugfs_node" while you do he conversion. Then the last patch should just modify debugfs and debugfs.h and no other file should be touched. I'll comment on the last patch to explain what I was expecting to be done that should satisfy Al. -- Steve