From: ecordonnier@snap.com
To: openembedded-core@lists.openembedded.org
Cc: Etienne Cordonnier <ecordonnier@snap.com>
Subject: [PATCH] gdb-cross: remove duplicated PACKAGECONFIG
Date: Mon, 10 Feb 2025 16:49:58 +0100 [thread overview]
Message-ID: <20250210154958.1119250-1-ecordonnier@snap.com> (raw)
From: Etienne Cordonnier <ecordonnier@snap.com>
Duplicating the PACKAGECONFIG variable in gdb-cross and gdb-common makes
it easy to forget updating one definition without updating the other.
However at the moment there is no need for two different definitions.
xz is also useful for gdb-cross when minidebuginfo is enabled, so it also needs
to be in the definition of PACKAGECONFIG in gdb-cross.inc
Let's remove the definition from gdb-cross.inc to make maintenance easier.
This enables xz for gdb-cross as side-effect.
Signed-off-by: Etienne Cordonnier <ecordonnier@snap.com>
---
meta/recipes-devtools/gdb/gdb-cross.inc | 1 -
1 file changed, 1 deletion(-)
diff --git a/meta/recipes-devtools/gdb/gdb-cross.inc b/meta/recipes-devtools/gdb/gdb-cross.inc
index 399f4bba97a..4f16deabe3e 100644
--- a/meta/recipes-devtools/gdb/gdb-cross.inc
+++ b/meta/recipes-devtools/gdb/gdb-cross.inc
@@ -5,7 +5,6 @@ DEPENDS = "expat-native gmp-native mpfr-native ncurses-native flex-native bison-
inherit python3native pkgconfig
# Overrides PACKAGECONFIG variables in gdb-common.inc
-PACKAGECONFIG ??= "python readline ${@bb.utils.filter('DISTRO_FEATURES', 'debuginfod', d)}"
PACKAGECONFIG[python] = "--with-python=${PYTHON},--without-python,python3-native"
PACKAGECONFIG[readline] = "--with-system-readline,--without-system-readline,readline-native"
PACKAGECONFIG[debuginfod] = "--with-debuginfod, --without-debuginfod, elfutils-native"
--
2.43.0
next reply other threads:[~2025-02-10 15:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 15:49 ecordonnier [this message]
2025-02-10 16:21 ` [OE-core] [PATCH] gdb-cross: remove duplicated PACKAGECONFIG Richard Purdie
2025-02-10 17:30 ` Khem Raj
2025-02-10 18:20 ` Etienne Cordonnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250210154958.1119250-1-ecordonnier@snap.com \
--to=ecordonnier@snap.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.