From: Jakub Kicinski <kuba@kernel.org>
To: Gal Pressman <gal@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Tariq Toukan <tariqt@nvidia.com>,
Edward Cree <ecree.xilinx@gmail.com>,
Ahmed Zaki <ahmed.zaki@intel.com>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH net-next v2 0/2] Symmetric OR-XOR RSS hash
Date: Mon, 10 Feb 2025 16:27:25 -0800 [thread overview]
Message-ID: <20250210162725.4bd38438@kernel.org> (raw)
In-Reply-To: <191d5c1c-7a86-4309-9e74-0bc275c01e45@nvidia.com>
On Sun, 9 Feb 2025 09:59:22 +0200 Gal Pressman wrote:
> I don't understand the rationale, the new input_xfrm field didn't
> deserve a selftest, why does a new value to the field does?
Ahmed and Sudheer added ETHTOOL_MSG_RSS_GET as part of their work.
Everyone pays off a little bit of technical debt to get their
feature in.
I don't appreciate your reaction. Please stop acting as if nVidia was
a victim of some grand conspiracy within netdev.
> Testing this would require new userspace ethtool (which has not been
> submitted yet), I don't think it's wise to implement a test before the
> user interface/output is merged.
No it doesn't. You can call netlink directly from Python or C.
> I assume you want an additional case in rss_ctx.py?
No, separate test.
next prev parent reply other threads:[~2025-02-11 0:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 13:53 [PATCH net-next v2 0/2] Symmetric OR-XOR RSS hash Gal Pressman
2025-02-05 13:53 ` [PATCH net-next v2 1/2] ethtool: " Gal Pressman
2025-02-05 22:20 ` Edward Cree
2025-02-07 1:31 ` Jakub Kicinski
2025-02-09 7:59 ` Gal Pressman
2025-02-05 13:53 ` [PATCH net-next v2 2/2] net/mlx5e: Symmetric OR-XOR RSS hash control Gal Pressman
2025-02-07 1:32 ` [PATCH net-next v2 0/2] Symmetric OR-XOR RSS hash Jakub Kicinski
2025-02-09 7:59 ` Gal Pressman
2025-02-11 0:27 ` Jakub Kicinski [this message]
2025-02-11 15:26 ` Gal Pressman
2025-02-12 18:13 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250210162725.4bd38438@kernel.org \
--to=kuba@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.