From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC0E1C02198 for ; Mon, 10 Feb 2025 13:39:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Message-ID:Date:From:Cc:To:Subject:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=mzwXH8QbzSf11HwOS0XSMdUPB1KhZbQyxtCgVUY5z2k=; b=UU0cZ8B9CXwzkT1ZxRDOYvoMvh dHAhRetGmCEyABzqJQg8ahulE76tSb4wAR39vgBgt1plygtXdCLbgR9cr8azlEdHgZ0SQmAbCPL5L WjA1dz4Wbv1QJVurzxnh2v50emKf5DAQL7UI/sJM3V/GYU/F7vQrhrVBfgK97SOSlvR5Rlzhow9Ao u/+9jEzMAhBOAIPZTmSzqZsf0Wji9P+568qxNdPa0phVWosA0NYM7Wc6vNotsnbAl47NLaKmZmrH3 PSLrhEEVHiS/dZQLPwvEncwXgjuzfjuXH3L1SPZL8VAPW5O03PC+T/jbiBfm1IiUxi3PyhJFKQS1I qKzzxzEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1thU0i-0000000Hatv-07ms; Mon, 10 Feb 2025 13:39:40 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thTkh-0000000HWsj-2YRZ; Mon, 10 Feb 2025 13:23:09 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 21D965C1D24; Mon, 10 Feb 2025 13:22:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1CD1EC4CED1; Mon, 10 Feb 2025 13:23:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1739193786; bh=oWx4BAP0EIg5C3iG442czeJGEBApEjEuVZ9EtETXvmg=; h=Subject:To:Cc:From:Date:From; b=BU+BhwneE0E6i/EgwS7HzVSFhkzBfYyYjICBsTDVgmUmynDgnLBvQYusT/zc1RSSW n3kddiI7bPvlrH4bUDKAetCz30NT0LPPy14286G1GTQ40d0GdFbBl2rifkSChoVFQq +gMpNHAgvy31JNrq4AgowvBeKfTWzudcXanUEUfs= Subject: Patch "drm/rockchip: cdn-dp: Use drm_connector_helper_hpd_irq_event()" has been added to the 5.4-stable tree To: andy.yan@rock-chips.com,dri-devel@lists.freedesktop.org,gregkh@linuxfoundation.org,groeck@chromium.org,heiko@sntech.de,hjc@rock-chips.com,linux-arm-kernel@lists.infradead.org,linux-rockchip@lists.infradead.org,tzimmermann@suse.de,zyw@rock-chips.com Cc: From: Date: Mon, 10 Feb 2025 14:22:46 +0100 Message-ID: <2025021046-opal-phoniness-65b3@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-stable: commit X-Patchwork-Hint: ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250210_052307_748019_9B78DD7D X-CRM114-Status: GOOD ( 17.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This is a note to let you know that I've just added the patch titled drm/rockchip: cdn-dp: Use drm_connector_helper_hpd_irq_event() to the 5.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: drm-rockchip-cdn-dp-use-drm_connector_helper_hpd_irq_event.patch and it can be found in the queue-5.4 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >From 666e1960464140cc4bc9203c203097e70b54c95a Mon Sep 17 00:00:00 2001 From: Thomas Zimmermann Date: Tue, 5 Nov 2024 14:38:16 +0100 Subject: drm/rockchip: cdn-dp: Use drm_connector_helper_hpd_irq_event() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Thomas Zimmermann commit 666e1960464140cc4bc9203c203097e70b54c95a upstream. The code for detecting and updating the connector status in cdn_dp_pd_event_work() has a number of problems. - It does not aquire the locks to call the detect helper and update the connector status. These are struct drm_mode_config.connection_mutex and struct drm_mode_config.mutex. - It does not use drm_helper_probe_detect(), which helps with the details of locking and detection. - It uses the connector's status field to determine a change to the connector status. The epoch_counter field is the correct one. The field signals a change even if the connector status' value did not change. Replace the code with a call to drm_connector_helper_hpd_irq_event(), which fixes all these problems. Signed-off-by: Thomas Zimmermann Fixes: 81632df69772 ("drm/rockchip: cdn-dp: do not use drm_helper_hpd_irq_event") Cc: Chris Zhong Cc: Guenter Roeck Cc: Sandy Huang Cc: "Heiko Stübner" Cc: Andy Yan Cc: dri-devel@lists.freedesktop.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-rockchip@lists.infradead.org Cc: # v4.11+ Signed-off-by: Heiko Stuebner Link: https://patchwork.freedesktop.org/patch/msgid/20241105133848.480407-1-tzimmermann@suse.de Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/rockchip/cdn-dp-core.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) --- a/drivers/gpu/drm/rockchip/cdn-dp-core.c +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c @@ -917,9 +917,6 @@ static void cdn_dp_pd_event_work(struct { struct cdn_dp_device *dp = container_of(work, struct cdn_dp_device, event_work); - struct drm_connector *connector = &dp->connector; - enum drm_connector_status old_status; - int ret; mutex_lock(&dp->lock); @@ -981,11 +978,7 @@ static void cdn_dp_pd_event_work(struct out: mutex_unlock(&dp->lock); - - old_status = connector->status; - connector->status = connector->funcs->detect(connector, false); - if (old_status != connector->status) - drm_kms_helper_hotplug_event(dp->drm_dev); + drm_connector_helper_hpd_irq_event(&dp->connector); } static int cdn_dp_pd_event(struct notifier_block *nb, Patches currently in stable-queue which might be from tzimmermann@suse.de are queue-5.4/drm-rockchip-cdn-dp-use-drm_connector_helper_hpd_irq_event.patch queue-5.4/m68k-vga-fix-i-o-defines.patch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE6E4C02198 for ; Mon, 10 Feb 2025 13:39:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:From:Cc:To :Subject:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=TAvN9ArDgdsLGvAwvxyK0S6THq1WqiPpA57oEeeuH4Q=; b=sSzodNQu7+riWz G3PW0o7AINpVeH7QpAy+S+Fk3AbZuSieAaeD5iASuloy18cUdEmq+Ydkjjj+trUdodVf2womLcx3c VDe46aEsGY0zWeOIXWHMXj5oNXyD7CYIsxX3tmeC6Wfo/A7xrQ4RzyBizRLx3yAGxvRXqZzg7xh7/ pTP6Bhva+7pOfr6SuRAaRZBSmv5jwa4JoJMBY0q4sjeVCXl/jcdX5WtO645nhjX2Q3JqxLragofpT GPNqlzTGzFc56APtkyF7jRAJ6QimoC5XnG36rfHCBp/b+qFRXPE8nJKlqRVKm35KbrrFVffENBNFa TrV1jhOhkaEJ4GDcLZ9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1thU0i-0000000HauG-2LpS; Mon, 10 Feb 2025 13:39:40 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thTkh-0000000HWsj-2YRZ; Mon, 10 Feb 2025 13:23:09 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 21D965C1D24; Mon, 10 Feb 2025 13:22:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1CD1EC4CED1; Mon, 10 Feb 2025 13:23:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1739193786; bh=oWx4BAP0EIg5C3iG442czeJGEBApEjEuVZ9EtETXvmg=; h=Subject:To:Cc:From:Date:From; b=BU+BhwneE0E6i/EgwS7HzVSFhkzBfYyYjICBsTDVgmUmynDgnLBvQYusT/zc1RSSW n3kddiI7bPvlrH4bUDKAetCz30NT0LPPy14286G1GTQ40d0GdFbBl2rifkSChoVFQq +gMpNHAgvy31JNrq4AgowvBeKfTWzudcXanUEUfs= Subject: Patch "drm/rockchip: cdn-dp: Use drm_connector_helper_hpd_irq_event()" has been added to the 5.4-stable tree To: andy.yan@rock-chips.com,dri-devel@lists.freedesktop.org,gregkh@linuxfoundation.org,groeck@chromium.org,heiko@sntech.de,hjc@rock-chips.com,linux-arm-kernel@lists.infradead.org,linux-rockchip@lists.infradead.org,tzimmermann@suse.de,zyw@rock-chips.com Cc: From: Date: Mon, 10 Feb 2025 14:22:46 +0100 Message-ID: <2025021046-opal-phoniness-65b3@gregkh> MIME-Version: 1.0 X-stable: commit X-Patchwork-Hint: ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250210_052307_748019_9B78DD7D X-CRM114-Status: GOOD ( 17.43 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org ClRoaXMgaXMgYSBub3RlIHRvIGxldCB5b3Uga25vdyB0aGF0IEkndmUganVzdCBhZGRlZCB0aGUg cGF0Y2ggdGl0bGVkCgogICAgZHJtL3JvY2tjaGlwOiBjZG4tZHA6IFVzZSBkcm1fY29ubmVjdG9y X2hlbHBlcl9ocGRfaXJxX2V2ZW50KCkKCnRvIHRoZSA1LjQtc3RhYmxlIHRyZWUgd2hpY2ggY2Fu IGJlIGZvdW5kIGF0OgogICAgaHR0cDovL3d3dy5rZXJuZWwub3JnL2dpdC8/cD1saW51eC9rZXJu ZWwvZ2l0L3N0YWJsZS9zdGFibGUtcXVldWUuZ2l0O2E9c3VtbWFyeQoKVGhlIGZpbGVuYW1lIG9m IHRoZSBwYXRjaCBpczoKICAgICBkcm0tcm9ja2NoaXAtY2RuLWRwLXVzZS1kcm1fY29ubmVjdG9y X2hlbHBlcl9ocGRfaXJxX2V2ZW50LnBhdGNoCmFuZCBpdCBjYW4gYmUgZm91bmQgaW4gdGhlIHF1 ZXVlLTUuNCBzdWJkaXJlY3RvcnkuCgpJZiB5b3UsIG9yIGFueW9uZSBlbHNlLCBmZWVscyBpdCBz aG91bGQgbm90IGJlIGFkZGVkIHRvIHRoZSBzdGFibGUgdHJlZSwKcGxlYXNlIGxldCA8c3RhYmxl QHZnZXIua2VybmVsLm9yZz4ga25vdyBhYm91dCBpdC4KCgpGcm9tIDY2NmUxOTYwNDY0MTQwY2M0 YmM5MjAzYzIwMzA5N2U3MGI1NGM5NWEgTW9uIFNlcCAxNyAwMDowMDowMCAyMDAxCkZyb206IFRo b21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPgpEYXRlOiBUdWUsIDUgTm92IDIw MjQgMTQ6Mzg6MTYgKzAxMDAKU3ViamVjdDogZHJtL3JvY2tjaGlwOiBjZG4tZHA6IFVzZSBkcm1f Y29ubmVjdG9yX2hlbHBlcl9ocGRfaXJxX2V2ZW50KCkKTUlNRS1WZXJzaW9uOiAxLjAKQ29udGVu dC1UeXBlOiB0ZXh0L3BsYWluOyBjaGFyc2V0PVVURi04CkNvbnRlbnQtVHJhbnNmZXItRW5jb2Rp bmc6IDhiaXQKCkZyb206IFRob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPgoK Y29tbWl0IDY2NmUxOTYwNDY0MTQwY2M0YmM5MjAzYzIwMzA5N2U3MGI1NGM5NWEgdXBzdHJlYW0u CgpUaGUgY29kZSBmb3IgZGV0ZWN0aW5nIGFuZCB1cGRhdGluZyB0aGUgY29ubmVjdG9yIHN0YXR1 cyBpbgpjZG5fZHBfcGRfZXZlbnRfd29yaygpIGhhcyBhIG51bWJlciBvZiBwcm9ibGVtcy4KCi0g SXQgZG9lcyBub3QgYXF1aXJlIHRoZSBsb2NrcyB0byBjYWxsIHRoZSBkZXRlY3QgaGVscGVyIGFu ZCB1cGRhdGUKdGhlIGNvbm5lY3RvciBzdGF0dXMuIFRoZXNlIGFyZSBzdHJ1Y3QgZHJtX21vZGVf Y29uZmlnLmNvbm5lY3Rpb25fbXV0ZXgKYW5kIHN0cnVjdCBkcm1fbW9kZV9jb25maWcubXV0ZXgu CgotIEl0IGRvZXMgbm90IHVzZSBkcm1faGVscGVyX3Byb2JlX2RldGVjdCgpLCB3aGljaCBoZWxw cyB3aXRoIHRoZQpkZXRhaWxzIG9mIGxvY2tpbmcgYW5kIGRldGVjdGlvbi4KCi0gSXQgdXNlcyB0 aGUgY29ubmVjdG9yJ3Mgc3RhdHVzIGZpZWxkIHRvIGRldGVybWluZSBhIGNoYW5nZSB0bwp0aGUg Y29ubmVjdG9yIHN0YXR1cy4gVGhlIGVwb2NoX2NvdW50ZXIgZmllbGQgaXMgdGhlIGNvcnJlY3Qg b25lLiBUaGUKZmllbGQgc2lnbmFscyBhIGNoYW5nZSBldmVuIGlmIHRoZSBjb25uZWN0b3Igc3Rh dHVzJyB2YWx1ZSBkaWQgbm90CmNoYW5nZS4KClJlcGxhY2UgdGhlIGNvZGUgd2l0aCBhIGNhbGwg dG8gZHJtX2Nvbm5lY3Rvcl9oZWxwZXJfaHBkX2lycV9ldmVudCgpLAp3aGljaCBmaXhlcyBhbGwg dGhlc2UgcHJvYmxlbXMuCgpTaWduZWQtb2ZmLWJ5OiBUaG9tYXMgWmltbWVybWFubiA8dHppbW1l cm1hbm5Ac3VzZS5kZT4KRml4ZXM6IDgxNjMyZGY2OTc3MiAoImRybS9yb2NrY2hpcDogY2RuLWRw OiBkbyBub3QgdXNlIGRybV9oZWxwZXJfaHBkX2lycV9ldmVudCIpCkNjOiBDaHJpcyBaaG9uZyA8 enl3QHJvY2stY2hpcHMuY29tPgpDYzogR3VlbnRlciBSb2VjayA8Z3JvZWNrQGNocm9taXVtLm9y Zz4KQ2M6IFNhbmR5IEh1YW5nIDxoamNAcm9jay1jaGlwcy5jb20+CkNjOiAiSGVpa28gU3TDvGJu ZXIiIDxoZWlrb0BzbnRlY2guZGU+CkNjOiBBbmR5IFlhbiA8YW5keS55YW5Acm9jay1jaGlwcy5j b20+CkNjOiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCkNjOiBsaW51eC1hcm0ta2Vy bmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKQ2M6IGxpbnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVh ZC5vcmcKQ2M6IDxzdGFibGVAdmdlci5rZXJuZWwub3JnPiAjIHY0LjExKwpTaWduZWQtb2ZmLWJ5 OiBIZWlrbyBTdHVlYm5lciA8aGVpa29Ac250ZWNoLmRlPgpMaW5rOiBodHRwczovL3BhdGNod29y ay5mcmVlZGVza3RvcC5vcmcvcGF0Y2gvbXNnaWQvMjAyNDExMDUxMzM4NDguNDgwNDA3LTEtdHpp bW1lcm1hbm5Ac3VzZS5kZQpTaWduZWQtb2ZmLWJ5OiBHcmVnIEtyb2FoLUhhcnRtYW4gPGdyZWdr aEBsaW51eGZvdW5kYXRpb24ub3JnPgotLS0KIGRyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9jZG4t ZHAtY29yZS5jIHwgICAgOSArLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigr KSwgOCBkZWxldGlvbnMoLSkKCi0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9jZG4tZHAt Y29yZS5jCisrKyBiL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9jZG4tZHAtY29yZS5jCkBAIC05 MTcsOSArOTE3LDYgQEAgc3RhdGljIHZvaWQgY2RuX2RwX3BkX2V2ZW50X3dvcmsoc3RydWN0CiB7 CiAJc3RydWN0IGNkbl9kcF9kZXZpY2UgKmRwID0gY29udGFpbmVyX29mKHdvcmssIHN0cnVjdCBj ZG5fZHBfZGV2aWNlLAogCQkJCQkJZXZlbnRfd29yayk7Ci0Jc3RydWN0IGRybV9jb25uZWN0b3Ig KmNvbm5lY3RvciA9ICZkcC0+Y29ubmVjdG9yOwotCWVudW0gZHJtX2Nvbm5lY3Rvcl9zdGF0dXMg b2xkX3N0YXR1czsKLQogCWludCByZXQ7CiAKIAltdXRleF9sb2NrKCZkcC0+bG9jayk7CkBAIC05 ODEsMTEgKzk3OCw3IEBAIHN0YXRpYyB2b2lkIGNkbl9kcF9wZF9ldmVudF93b3JrKHN0cnVjdAog CiBvdXQ6CiAJbXV0ZXhfdW5sb2NrKCZkcC0+bG9jayk7Ci0KLQlvbGRfc3RhdHVzID0gY29ubmVj dG9yLT5zdGF0dXM7Ci0JY29ubmVjdG9yLT5zdGF0dXMgPSBjb25uZWN0b3ItPmZ1bmNzLT5kZXRl Y3QoY29ubmVjdG9yLCBmYWxzZSk7Ci0JaWYgKG9sZF9zdGF0dXMgIT0gY29ubmVjdG9yLT5zdGF0 dXMpCi0JCWRybV9rbXNfaGVscGVyX2hvdHBsdWdfZXZlbnQoZHAtPmRybV9kZXYpOworCWRybV9j b25uZWN0b3JfaGVscGVyX2hwZF9pcnFfZXZlbnQoJmRwLT5jb25uZWN0b3IpOwogfQogCiBzdGF0 aWMgaW50IGNkbl9kcF9wZF9ldmVudChzdHJ1Y3Qgbm90aWZpZXJfYmxvY2sgKm5iLAoKClBhdGNo ZXMgY3VycmVudGx5IGluIHN0YWJsZS1xdWV1ZSB3aGljaCBtaWdodCBiZSBmcm9tIHR6aW1tZXJt YW5uQHN1c2UuZGUgYXJlCgpxdWV1ZS01LjQvZHJtLXJvY2tjaGlwLWNkbi1kcC11c2UtZHJtX2Nv bm5lY3Rvcl9oZWxwZXJfaHBkX2lycV9ldmVudC5wYXRjaApxdWV1ZS01LjQvbTY4ay12Z2EtZml4 LWktby1kZWZpbmVzLnBhdGNoCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGludXgtcm9ja2NoaXBAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LXJvY2tjaGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CFEBFC02198 for ; Mon, 10 Feb 2025 13:23:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4BBF310E529; Mon, 10 Feb 2025 13:23:08 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="BU+Bhwne"; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5049B10E529 for ; Mon, 10 Feb 2025 13:23:07 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 21D965C1D24; Mon, 10 Feb 2025 13:22:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1CD1EC4CED1; Mon, 10 Feb 2025 13:23:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1739193786; bh=oWx4BAP0EIg5C3iG442czeJGEBApEjEuVZ9EtETXvmg=; h=Subject:To:Cc:From:Date:From; b=BU+BhwneE0E6i/EgwS7HzVSFhkzBfYyYjICBsTDVgmUmynDgnLBvQYusT/zc1RSSW n3kddiI7bPvlrH4bUDKAetCz30NT0LPPy14286G1GTQ40d0GdFbBl2rifkSChoVFQq +gMpNHAgvy31JNrq4AgowvBeKfTWzudcXanUEUfs= Subject: Patch "drm/rockchip: cdn-dp: Use drm_connector_helper_hpd_irq_event()" has been added to the 5.4-stable tree To: andy.yan@rock-chips.com, dri-devel@lists.freedesktop.org, gregkh@linuxfoundation.org, groeck@chromium.org, heiko@sntech.de, hjc@rock-chips.com, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, tzimmermann@suse.de, zyw@rock-chips.com Cc: From: Date: Mon, 10 Feb 2025 14:22:46 +0100 Message-ID: <2025021046-opal-phoniness-65b3@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-stable: commit X-Patchwork-Hint: ignore X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This is a note to let you know that I've just added the patch titled drm/rockchip: cdn-dp: Use drm_connector_helper_hpd_irq_event() to the 5.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: drm-rockchip-cdn-dp-use-drm_connector_helper_hpd_irq_event.patch and it can be found in the queue-5.4 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >From 666e1960464140cc4bc9203c203097e70b54c95a Mon Sep 17 00:00:00 2001 From: Thomas Zimmermann Date: Tue, 5 Nov 2024 14:38:16 +0100 Subject: drm/rockchip: cdn-dp: Use drm_connector_helper_hpd_irq_event() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Thomas Zimmermann commit 666e1960464140cc4bc9203c203097e70b54c95a upstream. The code for detecting and updating the connector status in cdn_dp_pd_event_work() has a number of problems. - It does not aquire the locks to call the detect helper and update the connector status. These are struct drm_mode_config.connection_mutex and struct drm_mode_config.mutex. - It does not use drm_helper_probe_detect(), which helps with the details of locking and detection. - It uses the connector's status field to determine a change to the connector status. The epoch_counter field is the correct one. The field signals a change even if the connector status' value did not change. Replace the code with a call to drm_connector_helper_hpd_irq_event(), which fixes all these problems. Signed-off-by: Thomas Zimmermann Fixes: 81632df69772 ("drm/rockchip: cdn-dp: do not use drm_helper_hpd_irq_event") Cc: Chris Zhong Cc: Guenter Roeck Cc: Sandy Huang Cc: "Heiko Stübner" Cc: Andy Yan Cc: dri-devel@lists.freedesktop.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-rockchip@lists.infradead.org Cc: # v4.11+ Signed-off-by: Heiko Stuebner Link: https://patchwork.freedesktop.org/patch/msgid/20241105133848.480407-1-tzimmermann@suse.de Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/rockchip/cdn-dp-core.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) --- a/drivers/gpu/drm/rockchip/cdn-dp-core.c +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c @@ -917,9 +917,6 @@ static void cdn_dp_pd_event_work(struct { struct cdn_dp_device *dp = container_of(work, struct cdn_dp_device, event_work); - struct drm_connector *connector = &dp->connector; - enum drm_connector_status old_status; - int ret; mutex_lock(&dp->lock); @@ -981,11 +978,7 @@ static void cdn_dp_pd_event_work(struct out: mutex_unlock(&dp->lock); - - old_status = connector->status; - connector->status = connector->funcs->detect(connector, false); - if (old_status != connector->status) - drm_kms_helper_hotplug_event(dp->drm_dev); + drm_connector_helper_hpd_irq_event(&dp->connector); } static int cdn_dp_pd_event(struct notifier_block *nb, Patches currently in stable-queue which might be from tzimmermann@suse.de are queue-5.4/drm-rockchip-cdn-dp-use-drm_connector_helper_hpd_irq_event.patch queue-5.4/m68k-vga-fix-i-o-defines.patch