From: Kees Cook <kees@kernel.org>
To: David Gow <davidgow@google.com>
Cc: "Kees Cook" <kees@kernel.org>,
"Luis Felipe Hernandez" <luis.hernandez093@gmail.com>,
"Nicolas Pitre" <npitre@baylibre.com>,
"Rae Moar" <rmoar@google.com>,
"Pedro Orlando" <porlando@lkcamp.dev>,
"Danilo Pereira" <dpereira@lkcamp.dev>,
"Gabriela Bittencourt" <gbittencourt@lkcamp.dev>,
"Gabriel Krisman Bertazi" <krisman@suse.de>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Diego Vieira" <diego.daniel.professional@gmail.com>,
"Steven Rostedt (Google)" <rostedt@goodmis.org>,
"Jakub Kicinski" <kuba@kernel.org>,
"Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
"Vlastimil Babka" <vbabka@suse.cz>,
"Bruno Sobreira França" <brunofrancadevsec@gmail.com>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com
Subject: [PATCH v2 1/6] lib: math: Move KUnit tests into tests/ subdir
Date: Mon, 10 Feb 2025 16:31:29 -0800 [thread overview]
Message-ID: <20250211003136.2860503-1-kees@kernel.org> (raw)
In-Reply-To: <20250211002600.it.339-kees@kernel.org>
From: Luis Felipe Hernandez <luis.hernandez093@gmail.com>
This patch is a follow-up task from a discussion stemming from point 3
in a recent patch introducing the int_pow kunit test [1] and
documentation regarding kunit test style and nomenclature [2].
Colocate all kunit test suites in lib/math/tests/ and
follow recommended naming convention for files <suite>_kunit.c
and kconfig entries CONFIG_<name>_KUNIT_TEST.
Link: https://lore.kernel.org/all/CABVgOS=-vh5TqHFCq_jo=ffq8v_nGgr6JsPnOZag3e6+19ysxQ@mail.gmail.com/ [1]
Link: https://docs.kernel.org/dev-tools/kunit/style.html [2]
Signed-off-by: Luis Felipe Hernandez <luis.hernandez093@gmail.com>
Acked-by: Nicolas Pitre <npitre@baylibre.com>
Reviewed-by: David Gow <davidgow@google.com>
Reviewed-by: Rae Moar <rmoar@google.com>
Link: https://lore.kernel.org/r/20241202075545.3648096-2-davidgow@google.com
Signed-off-by: Kees Cook <kees@kernel.org>
---
lib/Kconfig.debug | 2 +-
lib/math/Makefile | 5 ++---
lib/math/tests/Makefile | 3 ++-
lib/math/{rational-test.c => tests/rational_kunit.c} | 0
4 files changed, 5 insertions(+), 5 deletions(-)
rename lib/math/{rational-test.c => tests/rational_kunit.c} (100%)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 1af972a92d06..b18dbfc53ca4 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -3166,7 +3166,7 @@ config TEST_OBJPOOL
If unsure, say N.
-config INT_POW_TEST
+config INT_POW_KUNIT_TEST
tristate "Integer exponentiation (int_pow) test" if !KUNIT_ALL_TESTS
depends on KUNIT
default KUNIT_ALL_TESTS
diff --git a/lib/math/Makefile b/lib/math/Makefile
index 853f023ae537..d1caba23baa0 100644
--- a/lib/math/Makefile
+++ b/lib/math/Makefile
@@ -5,8 +5,7 @@ obj-$(CONFIG_CORDIC) += cordic.o
obj-$(CONFIG_PRIME_NUMBERS) += prime_numbers.o
obj-$(CONFIG_RATIONAL) += rational.o
-obj-$(CONFIG_INT_POW_TEST) += tests/int_pow_kunit.o
obj-$(CONFIG_TEST_DIV64) += test_div64.o
obj-$(CONFIG_TEST_MULDIV64) += test_mul_u64_u64_div_u64.o
-obj-$(CONFIG_RATIONAL_KUNIT_TEST) += rational-test.o
-obj-$(CONFIG_INT_SQRT_KUNIT_TEST) += tests/int_sqrt_kunit.o
\ No newline at end of file
+
+obj-y += tests/
diff --git a/lib/math/tests/Makefile b/lib/math/tests/Makefile
index e1a79f093b2d..66b10a7f5a84 100644
--- a/lib/math/tests/Makefile
+++ b/lib/math/tests/Makefile
@@ -1,4 +1,5 @@
# SPDX-License-Identifier: GPL-2.0-only
-obj-$(CONFIG_INT_POW_TEST) += int_pow_kunit.o
+obj-$(CONFIG_INT_POW_KUNIT_TEST) += int_pow_kunit.o
+obj-$(CONFIG_RATIONAL_KUNIT_TEST) += rational_kunit.o
obj-$(CONFIG_INT_SQRT_KUNIT_TEST) += int_sqrt_kunit.o
diff --git a/lib/math/rational-test.c b/lib/math/tests/rational_kunit.c
similarity index 100%
rename from lib/math/rational-test.c
rename to lib/math/tests/rational_kunit.c
--
2.34.1
next prev parent reply other threads:[~2025-02-11 0:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 0:31 [PATCH v2 0/6] KUnit test moves / renames Kees Cook
2025-02-11 0:31 ` Kees Cook [this message]
2025-02-11 0:31 ` [PATCH v2 2/6] lib/math: Add int_log test suite Kees Cook
2025-02-11 0:31 ` [PATCH v2 3/6] lib: Move KUnit tests into tests/ subdirectory Kees Cook
2025-02-11 0:31 ` [PATCH v2 4/6] lib/tests/kfifo_kunit.c: add tests for the kfifo structure Kees Cook
2025-02-11 0:31 ` [PATCH v2 5/6] unicode: kunit: refactor selftest to kunit tests Kees Cook
2025-02-11 0:31 ` [PATCH v2 6/6] unicode: kunit: change tests filename and path Kees Cook
2025-02-12 15:40 ` Gabriel Krisman Bertazi
2025-02-12 22:01 ` Kees Cook
2025-02-11 1:11 ` [PATCH v2 0/6] KUnit test moves / renames Andrew Morton
2025-02-11 2:05 ` Kees Cook
2025-02-11 7:15 ` David Gow
-- strict thread matches above, loose matches on Subject: below --
2024-12-02 7:55 [PATCH v2 0/6] [PATCH " David Gow
2024-12-02 7:55 ` [PATCH v2 1/6] lib: math: Move kunit tests into tests/ subdir David Gow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250211003136.2860503-1-kees@kernel.org \
--to=kees@kernel.org \
--cc=brunofrancadevsec@gmail.com \
--cc=davidgow@google.com \
--cc=diego.daniel.professional@gmail.com \
--cc=dpereira@lkcamp.dev \
--cc=gbittencourt@lkcamp.dev \
--cc=krisman@suse.de \
--cc=kuba@kernel.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luis.hernandez093@gmail.com \
--cc=mhiramat@kernel.org \
--cc=npitre@baylibre.com \
--cc=porlando@lkcamp.dev \
--cc=rmoar@google.com \
--cc=rostedt@goodmis.org \
--cc=skhan@linuxfoundation.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.