From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Julia Lawall <julia.lawall@inria.fr>
Subject: Re: [PATCH v2 13/18] cxl/region: Add function to find a port's switch decoder by range
Date: Tue, 11 Feb 2025 00:48:53 +0800 [thread overview]
Message-ID: <202502110032.Tt58A4ik-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20250207153753.418849-14-rrichter@amd.com>
References: <20250207153753.418849-14-rrichter@amd.com>
TO: Robert Richter <rrichter@amd.com>
TO: Alison Schofield <alison.schofield@intel.com>
TO: Vishal Verma <vishal.l.verma@intel.com>
TO: Ira Weiny <ira.weiny@intel.com>
TO: Dan Williams <dan.j.williams@intel.com>
TO: Jonathan Cameron <Jonathan.Cameron@huawei.com>
TO: Dave Jiang <dave.jiang@intel.com>
TO: Davidlohr Bueso <dave@stgolabs.net>
CC: linux-cxl@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: Gregory Price <gourry@gourry.net>
CC: "Fabio M. De Francesco" <fabio.m.de.francesco@linux.intel.com>
CC: Terry Bowman <terry.bowman@amd.com>
CC: Robert Richter <rrichter@amd.com>
Hi Robert,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 5585e342e8d38cc598279bdb87f235f8b954dd5a]
url: https://github.com/intel-lab-lkp/linux/commits/Robert-Richter/cxl-Remove-else-after-return/20250207-234420
base: 5585e342e8d38cc598279bdb87f235f8b954dd5a
patch link: https://lore.kernel.org/r/20250207153753.418849-14-rrichter%40amd.com
patch subject: [PATCH v2 13/18] cxl/region: Add function to find a port's switch decoder by range
:::::: branch date: 3 days ago
:::::: commit date: 3 days ago
config: x86_64-randconfig-102-20250210 (https://download.01.org/0day-ci/archive/20250211/202502110032.Tt58A4ik-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Closes: https://lore.kernel.org/r/202502110032.Tt58A4ik-lkp@intel.com/
cocci warnings: (new ones prefixed by >>)
>> drivers/cxl/core/region.c:3241:42-45: ERROR: cxld is NULL but dereferenced.
drivers/cxl/core/region.c:3242:9-18: ERROR: cxld is NULL but dereferenced.
drivers/cxl/core/region.c:3242:32-41: ERROR: cxld is NULL but dereferenced.
vim +3241 drivers/cxl/core/region.c
f99413f1e5779b Robert Richter 2025-02-07 3222
47da10f758ff50 Robert Richter 2025-02-07 3223 static struct cxl_root_decoder *
47da10f758ff50 Robert Richter 2025-02-07 3224 cxl_find_root_decoder(struct cxl_endpoint_decoder *cxled)
47da10f758ff50 Robert Richter 2025-02-07 3225 {
47da10f758ff50 Robert Richter 2025-02-07 3226 struct cxl_memdev *cxlmd = cxled_to_memdev(cxled);
acf31aa5d4914a Robert Richter 2025-02-07 3227 struct cxl_port *iter = cxled_to_port(cxled);
47da10f758ff50 Robert Richter 2025-02-07 3228 struct cxl_decoder *cxld = &cxled->cxld;
47da10f758ff50 Robert Richter 2025-02-07 3229 struct range *hpa = &cxld->hpa_range;
47da10f758ff50 Robert Richter 2025-02-07 3230
acf31aa5d4914a Robert Richter 2025-02-07 3231 while (iter && !is_cxl_root(iter))
acf31aa5d4914a Robert Richter 2025-02-07 3232 iter = to_cxl_port(iter->dev.parent);
acf31aa5d4914a Robert Richter 2025-02-07 3233
acf31aa5d4914a Robert Richter 2025-02-07 3234 if (!iter)
acf31aa5d4914a Robert Richter 2025-02-07 3235 return NULL;
acf31aa5d4914a Robert Richter 2025-02-07 3236
f99413f1e5779b Robert Richter 2025-02-07 3237 cxld = cxl_port_find_switch_decoder(iter, hpa);
f99413f1e5779b Robert Richter 2025-02-07 3238 if (!cxld) {
47da10f758ff50 Robert Richter 2025-02-07 3239 dev_err(cxlmd->dev.parent,
47da10f758ff50 Robert Richter 2025-02-07 3240 "%s:%s no CXL window for range %#llx:%#llx\n",
47da10f758ff50 Robert Richter 2025-02-07 @3241 dev_name(&cxlmd->dev), dev_name(&cxld->dev),
47da10f758ff50 Robert Richter 2025-02-07 3242 cxld->hpa_range.start, cxld->hpa_range.end);
47da10f758ff50 Robert Richter 2025-02-07 3243 return NULL;
47da10f758ff50 Robert Richter 2025-02-07 3244 }
47da10f758ff50 Robert Richter 2025-02-07 3245
47da10f758ff50 Robert Richter 2025-02-07 3246
f99413f1e5779b Robert Richter 2025-02-07 3247
f99413f1e5779b Robert Richter 2025-02-07 3248 return to_cxl_root_decoder(&cxld->dev);
47da10f758ff50 Robert Richter 2025-02-07 3249 }
47da10f758ff50 Robert Richter 2025-02-07 3250
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2025-02-10 16:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 16:48 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-02-07 15:37 [PATCH v2 00/18] cxl: Address translation support, part 1: Cleanups and refactoring Robert Richter
2025-02-07 15:37 ` [PATCH v2 13/18] cxl/region: Add function to find a port's switch decoder by range Robert Richter
2025-02-07 16:29 ` Gregory Price
2025-02-07 22:22 ` Alison Schofield
2025-02-10 12:31 ` Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202502110032.Tt58A4ik-lkp@intel.com \
--to=lkp@intel.com \
--cc=julia.lawall@inria.fr \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.