From: Binbin Wu <binbin.wu@linux.intel.com>
To: pbonzini@redhat.com, seanjc@google.com, kvm@vger.kernel.org
Cc: rick.p.edgecombe@intel.com, kai.huang@intel.com,
adrian.hunter@intel.com, reinette.chatre@intel.com,
xiaoyao.li@intel.com, tony.lindgren@intel.com,
isaku.yamahata@intel.com, yan.y.zhao@intel.com,
chao.gao@intel.com, linux-kernel@vger.kernel.org,
binbin.wu@linux.intel.com
Subject: [PATCH v2 6/8] KVM: TDX: Handle TDG.VP.VMCALL<ReportFatalError>
Date: Tue, 11 Feb 2025 10:54:40 +0800 [thread overview]
Message-ID: <20250211025442.3071607-7-binbin.wu@linux.intel.com> (raw)
In-Reply-To: <20250211025442.3071607-1-binbin.wu@linux.intel.com>
Convert TDG.VP.VMCALL<ReportFatalError> to KVM_EXIT_SYSTEM_EVENT with
a new type KVM_SYSTEM_EVENT_TDX_FATAL and forward it to userspace for
handling.
TD guest can use TDG.VP.VMCALL<ReportFatalError> to report the fatal
error it has experienced. This hypercall is special because TD guest
is requesting a termination with the error information, KVM needs to
forward the hypercall to userspace anyway, KVM doesn't do sanity checks
and let userspace decide what to do.
Signed-off-by: Binbin Wu <binbin.wu@linux.intel.com>
---
Hypercalls exit to userspace v2:
- Use vp_enter_args instead of x86 registers.
- vcpu->run->system_event.ndata is not hardcoded to 10. (Xiaoyao)
- Undefine COPY_REG after use. (Yilun)
- Updated the document about KVM_SYSTEM_EVENT_TDX_FATAL. (Chao)
Hypercalls exit to userspace v1:
- New added.
Implement one of the hypercalls need to exit to userspace for handling after
reverting "KVM: TDX: Add KVM Exit for TDX TDG.VP.VMCALL", which tries to resolve
Sean's comment.
https://lore.kernel.org/kvm/Zg18ul8Q4PGQMWam@google.com/
- Use TDVMCALL_STATUS prefix for TDX call status codes (Binbin)
---
Documentation/virt/kvm/api.rst | 9 +++++++
arch/x86/kvm/vmx/tdx.c | 45 ++++++++++++++++++++++++++++++++++
include/uapi/linux/kvm.h | 1 +
3 files changed, 55 insertions(+)
diff --git a/Documentation/virt/kvm/api.rst b/Documentation/virt/kvm/api.rst
index 2ba70c1fad51..5e415b312ab0 100644
--- a/Documentation/virt/kvm/api.rst
+++ b/Documentation/virt/kvm/api.rst
@@ -6823,6 +6823,7 @@ should put the acknowledged interrupt vector into the 'epr' field.
#define KVM_SYSTEM_EVENT_WAKEUP 4
#define KVM_SYSTEM_EVENT_SUSPEND 5
#define KVM_SYSTEM_EVENT_SEV_TERM 6
+ #define KVM_SYSTEM_EVENT_TDX_FATAL 7
__u32 type;
__u32 ndata;
__u64 data[16];
@@ -6849,6 +6850,14 @@ Valid values for 'type' are:
reset/shutdown of the VM.
- KVM_SYSTEM_EVENT_SEV_TERM -- an AMD SEV guest requested termination.
The guest physical address of the guest's GHCB is stored in `data[0]`.
+ - KVM_SYSTEM_EVENT_TDX_FATAL -- a TDX guest reported a fatal error state.
+ The error code reported by the TDX guest is stored in `data[0]`, the error
+ code format is defined in TDX GHCI specification.
+ If the bit 63 of `data[0]` is set, it indicates there is TD specified
+ additional information provided in a page, which is shared memory. The
+ guest physical address of the information page is stored in `data[1]`.
+ An optional error message is provided by `data[2]` ~ `data[9]`, which is
+ byte sequence, LSB filled first. Typically, ASCII code(0x20-0x7e) is filled.
- KVM_SYSTEM_EVENT_WAKEUP -- the exiting vCPU is in a suspended state and
KVM has recognized a wakeup event. Userspace may honor this event by
marking the exiting vCPU as runnable, or deny it and call KVM_RUN again.
diff --git a/arch/x86/kvm/vmx/tdx.c b/arch/x86/kvm/vmx/tdx.c
index 8b51b4c937e9..85956768c515 100644
--- a/arch/x86/kvm/vmx/tdx.c
+++ b/arch/x86/kvm/vmx/tdx.c
@@ -1092,11 +1092,56 @@ static int tdx_map_gpa(struct kvm_vcpu *vcpu)
return 1;
}
+static int tdx_report_fatal_error(struct kvm_vcpu *vcpu)
+{
+ struct vcpu_tdx *tdx = to_tdx(vcpu);
+ u64 reg_mask = tdx->vp_enter_args.rcx;
+ u64 *opt_regs;
+
+ /*
+ * Skip sanity checks and let userspace decide what to do if sanity
+ * checks fail.
+ */
+ vcpu->run->exit_reason = KVM_EXIT_SYSTEM_EVENT;
+ vcpu->run->system_event.type = KVM_SYSTEM_EVENT_TDX_FATAL;
+ /* Error codes. */
+ vcpu->run->system_event.data[0] = tdx->vp_enter_args.r12;
+ /* GPA of additional information page. */
+ vcpu->run->system_event.data[1] = tdx->vp_enter_args.r13;
+ /* Information passed via registers (up to 64 bytes). */
+ opt_regs = &vcpu->run->system_event.data[2];
+
+#define COPY_REG(REG, MASK) \
+ do { \
+ if (reg_mask & MASK) { \
+ *opt_regs = tdx->vp_enter_args.REG; \
+ opt_regs++; \
+ } \
+ } while (0)
+
+ /* The order is defined in GHCI. */
+ COPY_REG(r14, BIT_ULL(14));
+ COPY_REG(r15, BIT_ULL(15));
+ COPY_REG(rbx, BIT_ULL(3));
+ COPY_REG(rdi, BIT_ULL(7));
+ COPY_REG(rsi, BIT_ULL(6));
+ COPY_REG(r8, BIT_ULL(8));
+ COPY_REG(r9, BIT_ULL(9));
+ COPY_REG(rdx, BIT_ULL(2));
+#undef COPY_REG
+
+ vcpu->run->system_event.ndata = opt_regs - vcpu->run->system_event.data;
+
+ return 0;
+}
+
static int handle_tdvmcall(struct kvm_vcpu *vcpu)
{
switch (tdvmcall_leaf(vcpu)) {
case TDVMCALL_MAP_GPA:
return tdx_map_gpa(vcpu);
+ case TDVMCALL_REPORT_FATAL_ERROR:
+ return tdx_report_fatal_error(vcpu);
default:
break;
}
diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h
index 45e6d8fca9b9..937400350317 100644
--- a/include/uapi/linux/kvm.h
+++ b/include/uapi/linux/kvm.h
@@ -375,6 +375,7 @@ struct kvm_run {
#define KVM_SYSTEM_EVENT_WAKEUP 4
#define KVM_SYSTEM_EVENT_SUSPEND 5
#define KVM_SYSTEM_EVENT_SEV_TERM 6
+#define KVM_SYSTEM_EVENT_TDX_FATAL 7
__u32 type;
__u32 ndata;
union {
--
2.46.0
next prev parent reply other threads:[~2025-02-11 2:53 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 2:54 [PATCH v2 0/8] KVM: TDX: TDX hypercalls may exit to userspace Binbin Wu
2025-02-11 2:54 ` [PATCH v2 1/8] KVM: x86: Have ____kvm_emulate_hypercall() read the GPRs Binbin Wu
2025-02-11 5:05 ` Huang, Kai
2025-02-11 10:23 ` Xiaoyao Li
2025-02-12 1:32 ` Binbin Wu
2025-02-12 3:12 ` Xiaoyao Li
2025-02-11 2:54 ` [PATCH v2 2/8] KVM: TDX: Add a place holder to handle TDX VM exit Binbin Wu
2025-02-11 2:54 ` [PATCH v2 3/8] KVM: TDX: Add a place holder for handler of TDX hypercalls (TDG.VP.VMCALL) Binbin Wu
2025-02-11 8:41 ` Chao Gao
2025-02-11 9:08 ` Binbin Wu
2025-02-11 23:46 ` Sean Christopherson
2025-02-12 2:21 ` Binbin Wu
2025-02-11 2:54 ` [PATCH v2 4/8] KVM: TDX: Handle KVM hypercall with TDG.VP.VMCALL Binbin Wu
2025-02-11 23:48 ` Sean Christopherson
2025-02-11 2:54 ` [PATCH v2 5/8] KVM: TDX: Handle TDG.VP.VMCALL<MapGPA> Binbin Wu
2025-02-11 6:54 ` Yan Zhao
2025-02-11 8:11 ` Binbin Wu
2025-02-11 8:59 ` Chao Gao
2025-02-12 0:46 ` Sean Christopherson
2025-02-12 5:16 ` Binbin Wu
2025-02-12 18:56 ` Sean Christopherson
2025-02-13 3:23 ` Binbin Wu
2025-02-13 5:11 ` Binbin Wu
2025-02-13 15:17 ` Sean Christopherson
2025-02-17 3:41 ` Binbin Wu
2025-02-19 0:29 ` Sean Christopherson
2025-02-19 0:49 ` Binbin Wu
2025-02-11 2:54 ` Binbin Wu [this message]
2025-02-12 0:18 ` [PATCH v2 6/8] KVM: TDX: Handle TDG.VP.VMCALL<ReportFatalError> Sean Christopherson
2025-02-12 5:37 ` Binbin Wu
2025-02-12 13:53 ` Sean Christopherson
2025-02-11 2:54 ` [PATCH v2 7/8] KVM: TDX: Handle TDX PV port I/O hypercall Binbin Wu
2025-02-11 2:54 ` [PATCH v2 8/8] KVM: TDX: Handle TDX PV MMIO hypercall Binbin Wu
2025-02-12 2:28 ` Chao Gao
2025-02-12 2:39 ` Binbin Wu
2025-02-13 21:41 ` Edgecombe, Rick P
2025-02-14 0:47 ` Binbin Wu
2025-02-14 1:01 ` Edgecombe, Rick P
2025-02-14 1:20 ` Binbin Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250211025442.3071607-7-binbin.wu@linux.intel.com \
--to=binbin.wu@linux.intel.com \
--cc=adrian.hunter@intel.com \
--cc=chao.gao@intel.com \
--cc=isaku.yamahata@intel.com \
--cc=kai.huang@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=reinette.chatre@intel.com \
--cc=rick.p.edgecombe@intel.com \
--cc=seanjc@google.com \
--cc=tony.lindgren@intel.com \
--cc=xiaoyao.li@intel.com \
--cc=yan.y.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.