All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vadim Pasternak <vadimp@nvidia.com>
To: <hdegoede@redhat.com>, <ilpo.jarvinen@linux.intel.com>
Cc: <michaelsh@nvidia.com>, <crajank@nvidia.com>,
	<fradensky@nvidia.com>, <oleksandrs@nvidia.com>,
	<platform-driver-x86@vger.kernel.org>,
	"Vadim Pasternak" <vadimp@nvidia.com>
Subject: [PATCH v6 2/9] platform/mellanox mlxreg-hotplug: Add support for new flavor of capability registers
Date: Tue, 11 Feb 2025 11:19:05 +0200	[thread overview]
Message-ID: <20250211091912.36787-3-vadimp@nvidia.com> (raw)
In-Reply-To: <20250211091912.36787-1-vadimp@nvidia.com>

Hotplug platform data is common across the various systems, while
hotplug driver should be able to configure only the instances relevant
to specific system.

For example, platform hoptplug data might contain descriptions for fan1,
fan2, ..., fan{n}, while some systems equipped with all 'n' fans,
others with less. Same for power units, power controllers, ASICs and so
on.

New 'capability_mask' is introduced to allow sharing of same hoptplug
structure between different systems, equipped with different number of
hotplug devices. It contains superset mask for all systems sharing the
same configuration.

The purpose is to reduce unnecessary duplication of hoptplug structures
between different systems - same structure is to be used for example for
system equipped fir for 4, 6 or 8 fans.

For detection of the real number of equipped devices capability
registers are used. These registers used to indicate presence of
hotplug devices. On some systems presence is porvided through the
bitmap. For some new big modular systems, these registers will provide
presence by counters. Use slot parameter to determine whether
capability register contains bitmask or counter.

Reviewed-by: Felix Radensky <fradensky@nvidia.com>
Signed-off-by: Vadim Pasternak <vadimp@nvidia.com>
---
v5->v6
Revised after comments pointed out by Ilpo:
- Drop 'capability_bit' from structure 'mlxreg_core_data', since it is
  not used.
---
 drivers/platform/mellanox/mlxreg-hotplug.c | 25 ++++++++++++++++++++--
 1 file changed, 23 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/mellanox/mlxreg-hotplug.c b/drivers/platform/mellanox/mlxreg-hotplug.c
index 0ce9fff1f7d4..93bdd20fd71a 100644
--- a/drivers/platform/mellanox/mlxreg-hotplug.c
+++ b/drivers/platform/mellanox/mlxreg-hotplug.c
@@ -274,6 +274,16 @@ static int mlxreg_hotplug_attr_init(struct mlxreg_hotplug_priv_data *priv)
 			if (ret)
 				return ret;
 
+			if (!regval)
+				continue;
+
+			/*
+			 * Remove non-relevant bits: 'regval' contains bitmask of attributes or
+			 * number of attributtes, which should be handled. While 'capability mask'
+			 * is superset mask.
+			 */
+			if (item->capability_mask)
+				regval = (regval & item->capability_mask);
 			item->mask = GENMASK((regval & item->mask) - 1, 0);
 		}
 
@@ -294,7 +304,18 @@ static int mlxreg_hotplug_attr_init(struct mlxreg_hotplug_priv_data *priv)
 				if (ret)
 					return ret;
 
-				if (!(regval & data->bit)) {
+				if (data->capability_mask)
+					regval = (regval & data->capability_mask);
+
+				/*
+				 * In case slot field is provided, capability register contains
+				 * counter, otherwise bitmask. Skip non-relevant entries if slot
+				 * is set and exceeds counter. Othewise validate entry by matching
+				 * bitmask.
+				 */
+				if (data->slot > regval)
+					break;
+				if (!(regval & data->bit) && !data->slot) {
 					data++;
 					continue;
 				}
@@ -611,7 +632,7 @@ static int mlxreg_hotplug_set_irq(struct mlxreg_hotplug_priv_data *priv)
 				if (ret)
 					goto out;
 
-				if (!(regval & data->bit))
+				if (!(regval & data->bit) && !data->slot)
 					item->mask &= ~BIT(j);
 			}
 		}
-- 
2.44.0


  parent reply	other threads:[~2025-02-11  9:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-11  9:19 [PATCH v6 0/9] Add support for new systems, amendments Vadim Pasternak
2025-02-11  9:19 ` [PATCH v6 1/9] platform_data/mlxreg: Add capability mask fields Vadim Pasternak
2025-02-11 14:49   ` Ilpo Järvinen
2025-02-11  9:19 ` Vadim Pasternak [this message]
2025-03-04 13:25   ` [PATCH v6 2/9] platform/mellanox mlxreg-hotplug: Add support for new flavor of capability registers Ilpo Järvinen
2025-03-17 16:16     ` Vadim Pasternak
2025-02-11  9:19 ` [PATCH v6 3/9] platform/mellanox: Rename field to improve code readability Vadim Pasternak
2025-02-11  9:19 ` [PATCH v6 4/9] platform/mellanox: mlxreg-dpu: Add initial support for Nvidia DPU Vadim Pasternak
2025-02-11  9:19 ` [PATCH v6 5/9] platform: mellanox: Introduce support of Nvidia smart switch Vadim Pasternak
2025-02-11 14:52   ` Ilpo Järvinen
2025-02-11  9:19 ` [PATCH v6 6/9] platform: mellanox: Cosmetic changes to improve code style Vadim Pasternak
2025-02-11  9:19 ` [PATCH v6 7/9] platform: mellanox: mlx-platform: Add support for new Nvidia system Vadim Pasternak
2025-02-11  9:19 ` [PATCH v6 8/9] platform: mellanox: nvsw-sn2200: Add support for new system flavour Vadim Pasternak
2025-02-11  9:19 ` [PATCH v6 9/9] Documentation/ABI: Add new attribute for mlxreg-io sysfs interfaces Vadim Pasternak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250211091912.36787-3-vadimp@nvidia.com \
    --to=vadimp@nvidia.com \
    --cc=crajank@nvidia.com \
    --cc=fradensky@nvidia.com \
    --cc=hdegoede@redhat.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=michaelsh@nvidia.com \
    --cc=oleksandrs@nvidia.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.