From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: Li Ming <ming.li@zohomail.com>
Cc: <dave@stgolabs.net>, <dave.jiang@intel.com>,
<alison.schofield@intel.com>, <vishal.l.verma@intel.com>,
<ira.weiny@intel.com>, <dan.j.williams@intel.com>,
<linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/1] cxl/cdat: Remove redundant gp_port initialization
Date: Tue, 11 Feb 2025 09:28:45 +0000 [thread overview]
Message-ID: <20250211092845.00000d3e@huawei.com> (raw)
In-Reply-To: <20250211062054.300108-1-ming.li@zohomail.com>
On Tue, 11 Feb 2025 14:20:54 +0800
Li Ming <ming.li@zohomail.com> wrote:
> gp_port is already pointed to the grandparent port during its definition,
> remove a redundant code to let gp_port point to the grandparent port
> again.
>
> Signed-off-by: Li Ming <ming.li@zohomail.com>
LGTM
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> drivers/cxl/core/cdat.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cxl/core/cdat.c b/drivers/cxl/core/cdat.c
> index 8153f8d83a16..c656c1346aa0 100644
> --- a/drivers/cxl/core/cdat.c
> +++ b/drivers/cxl/core/cdat.c
> @@ -651,7 +651,6 @@ static int cxl_endpoint_gather_bandwidth(struct cxl_region *cxlr,
> if (IS_ERR(perf))
> return PTR_ERR(perf);
>
> - gp_port = to_cxl_port(parent_port->dev.parent);
> *gp_is_root = is_cxl_root(gp_port);
>
> /*
next prev parent reply other threads:[~2025-02-11 9:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 6:20 [PATCH v1 1/1] cxl/cdat: Remove redundant gp_port initialization Li Ming
2025-02-11 9:28 ` Jonathan Cameron [this message]
2025-02-11 16:25 ` Davidlohr Bueso
2025-02-11 16:38 ` Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250211092845.00000d3e@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.li@zohomail.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.