From: Jakub Kicinski <kuba@kernel.org>
To: Gal Pressman <gal@nvidia.com>
Cc: Kees Cook <kees@kernel.org>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Tariq Toukan <tariqt@nvidia.com>,
Louis Peens <louis.peens@corigine.com>,
Simon Horman <horms@kernel.org>, David Ahern <dsahern@kernel.org>,
Pravin B Shelar <pshelar@ovn.org>,
Yotam Gigi <yotam.gi@gmail.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
dev@openvswitch.org, linux-hardening@vger.kernel.org,
Cosmin Ratiu <cratiu@nvidia.com>
Subject: Re: [PATCH net-next] net: Add options as a flexible array to struct ip_tunnel_info
Date: Tue, 11 Feb 2025 16:28:51 -0800 [thread overview]
Message-ID: <20250211162851.4409b61a@kernel.org> (raw)
In-Reply-To: <ee761ca9-5aa0-4f48-96b9-295ed2c444c4@nvidia.com>
On Tue, 11 Feb 2025 20:59:24 +0200 Gal Pressman wrote:
> > Everything else looks very good, though, yes, I would agree with the
> > alignment comments made down-thread. This was "accidentally correct"
> > before in the sense that the end of the struct would be padded for
> > alignment, but isn't guaranteed to be true with an explicit u8 array.
> > The output of "pahole -C struct ip_tunnel_info" before/after should
> > answer any questions, though.
>
> Thanks, I will attach pahole's output in the commit message.
Why not slap an __aligned(sizeof(void *)) or just __aligned(8)
on the new option field? That should give us the same behavior
as we have today implicitly.
prev parent reply other threads:[~2025-02-12 0:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-09 10:18 [PATCH net-next] net: Add options as a flexible array to struct ip_tunnel_info Gal Pressman
2025-02-09 16:21 ` [ovs-dev] " Ilya Maximets
2025-02-09 19:37 ` Gal Pressman
2025-02-09 20:16 ` Ilya Maximets
2025-02-11 15:38 ` Gal Pressman
2025-02-11 17:49 ` Kees Cook
2025-02-11 18:59 ` Gal Pressman
2025-02-12 0:28 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250211162851.4409b61a@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=gustavoars@kernel.org \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=louis.peens@corigine.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pshelar@ovn.org \
--cc=tariqt@nvidia.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yotam.gi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.