From: Jakub Kicinski <kuba@kernel.org>
To: Stanislav Fomichev <stfomichev@gmail.com>
Cc: Joe Damato <jdamato@fastly.com>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, horms@kernel.org,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>, Shuah Khan <shuah@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
open list <linux-kernel@vger.kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
"open list:XDP (eXpress Data Path):Keyword:(?:b|_)xdp(?:b|_)"
<bpf@vger.kernel.org>
Subject: Re: [PATCH net-next v6 3/3] selftests: drv-net: Test queue xsk attribute
Date: Tue, 11 Feb 2025 18:37:06 -0800 [thread overview]
Message-ID: <20250211183706.5b53ee5e@kernel.org> (raw)
In-Reply-To: <Z6vY_LXp3LTp7qWV@mini-arch>
On Tue, 11 Feb 2025 15:10:52 -0800 Stanislav Fomichev wrote:
> > I can't comment on NIPA because I have no idea how it works. Maybe
> > there is a kernel with some options enabled and other kernels with
> > various options disabled?
>
> Sorry, should've been more clear. My suggestion is to add
> CONFIG_XDP_SOCKETS to tools/testing/selftests/drivers/net/config
> to make your new testcase run in a proper environment with XSKs enabled.
+1 this we need for sure
> > I wonder if that's a separate issue though?
> >
> > In other words: maybe writing the test as I've mentioned above so it
> > works regardless of whether CONFIG_XDP_SOCKETS is set or not is a
> > good idea just on its own?
> >
> > I'm just not sure if there's some other pattern I should be
> > following other than what I proposed above. I'm hesitant to re-spin
> > until I get feedback on the proposed approach.
>
> I'd keep your test as is (fail hard if XSK is not there), but
> let's see if Paolo/Jakub have any other suggestions.
No strong preference. Stan is right that validating the environment
is definitely a non-goal for the upstream tests. But if you already
added and tested the checks Joe you can keep them, up to you.
next prev parent reply other threads:[~2025-02-12 2:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 19:38 [PATCH net-next v6 0/3] netdev-genl: Add an xsk attribute to queues Joe Damato
2025-02-10 19:38 ` [PATCH net-next v6 1/3] netlink: Add nla_put_empty_nest helper Joe Damato
2025-02-10 19:38 ` [PATCH net-next v6 2/3] netdev-genl: Add an XSK attribute to queues Joe Damato
2025-02-10 19:38 ` [PATCH net-next v6 3/3] selftests: drv-net: Test queue xsk attribute Joe Damato
2025-02-11 11:09 ` Paolo Abeni
2025-02-11 17:45 ` Joe Damato
2025-02-11 19:57 ` Joe Damato
2025-02-11 20:00 ` Stanislav Fomichev
2025-02-11 22:37 ` Joe Damato
2025-02-11 23:10 ` Stanislav Fomichev
2025-02-12 2:37 ` Jakub Kicinski [this message]
2025-02-12 13:30 ` Joe Damato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250211183706.5b53ee5e@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=john.fastabend@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=stfomichev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.