From: Jakub Kicinski <kuba@kernel.org>
To: Birger Koblitz <mail@birger-koblitz.de>
Cc: netdev@vger.kernel.org, Daniel Golle <daniel@makrotopia.org>
Subject: Re: [PATCH net-next] net: sfp: add quirk for 2.5G OEM BX SFP
Date: Tue, 11 Feb 2025 19:02:41 -0800 [thread overview]
Message-ID: <20250211190241.6c978f6a@kernel.org> (raw)
In-Reply-To: <96223803-95a8-4879-8a26-bc13b66a6e6b@birger-koblitz.de>
On Sun, 9 Feb 2025 12:01:55 +0100 Birger Koblitz wrote:
> SFP_QUIRK_F("OEM", "SFP-10G-T", sfp_fixup_rollball_cc),
The patch is corrupted, there is an extra space at the start
of each context line. Perhaps try resending with git send-email?
Before resending please add Daniel's review tag to the commit message.
> SFP_QUIRK_M("OEM", "SFP-2.5G-T", sfp_quirk_oem_2_5g),
> + SFP_QUIRK_M("OEM", "SFP-2.5G-BX10-D", sfp_quirk_2500basex),
> + SFP_QUIRK_M("OEM", "SFP-2.5G-BX10-U", sfp_quirk_2500basex),
--
pw-bot: cr
next prev parent reply other threads:[~2025-02-12 3:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-09 11:01 [PATCH net-next] net: sfp: add quirk for 2.5G OEM BX SFP Birger Koblitz
2025-02-09 15:13 ` Daniel Golle
2025-02-12 3:02 ` Jakub Kicinski [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-02-12 15:13 Birger Koblitz
2025-02-14 21:24 ` Jakub Kicinski
2025-02-15 6:29 Birger Koblitz
2025-02-18 1:00 ` Jakub Kicinski
2025-02-18 17:59 Birger Koblitz
2025-02-21 23:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250211190241.6c978f6a@kernel.org \
--to=kuba@kernel.org \
--cc=daniel@makrotopia.org \
--cc=mail@birger-koblitz.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.