From: Jakub Kicinski <kuba@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
andrew+netdev@lunn.ch, netdev@vger.kernel.org,
Karol Kolacinski <karol.kolacinski@intel.com>,
richardcochran@gmail.com, grzegorz.nitka@intel.com,
przemyslaw.kitszel@intel.com
Subject: Re: [PATCH net-next 04/10] ice: Process TSYN IRQ in a separate function
Date: Tue, 11 Feb 2025 19:47:27 -0800 [thread overview]
Message-ID: <20250211194727.59090a33@kernel.org> (raw)
In-Reply-To: <20250210192352.3799673-5-anthony.l.nguyen@intel.com>
On Mon, 10 Feb 2025 11:23:42 -0800 Tony Nguyen wrote:
> Simplify TSYN IRQ processing by moving it to a separate function and
> having appropriate behavior per PHY model, instead of multiple
> conditions not related to HW, but to specific timestamping modes.
>
> When PTP is not enabled in the kernel, don't process timestamps and
> return IRQ_HANDLED.
You also switched from spin_lock_irqsave() to bare spin_lock().
Looks safe but you should have mentioned why.
next prev parent reply other threads:[~2025-02-12 3:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 19:23 [PATCH net-next 00/10][pull request] Intel Wired LAN Driver Updates 2025-02-10 (ice, igc, e1000e) Tony Nguyen
2025-02-10 19:23 ` [PATCH net-next 01/10] ice: Don't check device type when checking GNSS presence Tony Nguyen
2025-02-10 19:23 ` [PATCH net-next 02/10] ice: Remove unnecessary ice_is_e8xx() functions Tony Nguyen
2025-02-10 19:23 ` [PATCH net-next 03/10] ice: Use FIELD_PREP for timestamp values Tony Nguyen
2025-02-10 19:23 ` [PATCH net-next 04/10] ice: Process TSYN IRQ in a separate function Tony Nguyen
2025-02-12 3:47 ` Jakub Kicinski [this message]
2025-02-10 19:23 ` [PATCH net-next 05/10] ice: Add unified ice_capture_crosststamp Tony Nguyen
2025-02-10 19:23 ` [PATCH net-next 06/10] ice: Refactor ice_ptp_init_tx_* Tony Nguyen
2025-02-10 19:23 ` [PATCH net-next 07/10] ice: Implement PTP support for E830 devices Tony Nguyen
2025-02-10 19:23 ` [PATCH net-next 08/10] ice: refactor ice_fdir_create_dflt_rules() function Tony Nguyen
2025-02-10 19:23 ` [PATCH net-next 09/10] igc: Avoid unnecessary link down event in XDP_SETUP_PROG process Tony Nguyen
2025-02-10 19:23 ` [PATCH net-next 10/10] e1000e: Fix real-time violations on link up Tony Nguyen
2025-02-12 4:00 ` [PATCH net-next 00/10][pull request] Intel Wired LAN Driver Updates 2025-02-10 (ice, igc, e1000e) patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250211194727.59090a33@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=grzegorz.nitka@intel.com \
--cc=karol.kolacinski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.