From: "James A. MacInnes" <james.a.macinnes@gmail.com>
To: linux-arm-msm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
andersson@kernel.org, konradybcio@kernel.org,
quic_wcheng@quicinc.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org,
"James A. MacInnes" <james.a.macinnes@gmail.com>
Subject: [PATCH 2/3] regulator: qcom_usb_vbus: Add support for PMI8998 VBUS
Date: Tue, 11 Feb 2025 11:49:15 -0800 [thread overview]
Message-ID: <20250211194918.2517593-3-james.a.macinnes@gmail.com> (raw)
In-Reply-To: <20250211194918.2517593-1-james.a.macinnes@gmail.com>
This patch extends the Qualcomm USB VBUS regulator driver to support
PMI8998 PMIC alongside the existing support for PM8150B.
Key changes:
- Added current limit tables specific to PMI8998.
- Dynamically configure the VBUS regulator based on the PMIC type.
- Updated debug messages to reflect successful initialization for
supported PMICs.
- Changed registration log message
These changes ensure proper VBUS current limit configuration and
compatibility across multiple Qualcomm PMICs.
Signed-off-by: James A. MacInnes <james.a.macinnes@gmail.com>
---
drivers/regulator/qcom_usb_vbus-regulator.c | 33 +++++++++++++++++----
1 file changed, 28 insertions(+), 5 deletions(-)
diff --git a/drivers/regulator/qcom_usb_vbus-regulator.c b/drivers/regulator/qcom_usb_vbus-regulator.c
index cd94ed67621f..bfcb77698ba2 100644
--- a/drivers/regulator/qcom_usb_vbus-regulator.c
+++ b/drivers/regulator/qcom_usb_vbus-regulator.c
@@ -20,10 +20,15 @@
#define OTG_CFG 0x53
#define OTG_EN_SRC_CFG BIT(1)
-static const unsigned int curr_table[] = {
+static const unsigned int curr_table_pm8150b[] = {
500000, 1000000, 1500000, 2000000, 2500000, 3000000,
};
+static const unsigned int curr_table_pmi8998[] = {
+ 250000, 500000, 750000, 1000000,
+ 1250000, 1500000, 1750000, 2000000,
+};
+
static const struct regulator_ops qcom_usb_vbus_reg_ops = {
.enable = regulator_enable_regmap,
.disable = regulator_disable_regmap,
@@ -37,8 +42,8 @@ static struct regulator_desc qcom_usb_vbus_rdesc = {
.ops = &qcom_usb_vbus_reg_ops,
.owner = THIS_MODULE,
.type = REGULATOR_VOLTAGE,
- .curr_table = curr_table,
- .n_current_limits = ARRAY_SIZE(curr_table),
+ .curr_table = NULL,
+ .n_current_limits = 0,
};
static int qcom_usb_vbus_regulator_probe(struct platform_device *pdev)
@@ -50,6 +55,7 @@ static int qcom_usb_vbus_regulator_probe(struct platform_device *pdev)
struct regulator_init_data *init_data;
int ret;
u32 base;
+ const char *pmic_type;
ret = of_property_read_u32(dev->of_node, "reg", &base);
if (ret < 0) {
@@ -68,6 +74,19 @@ static int qcom_usb_vbus_regulator_probe(struct platform_device *pdev)
if (!init_data)
return -ENOMEM;
+ // Determine PMIC type
+ pmic_type = of_device_get_match_data(dev);
+ if (pmic_type && strcmp(pmic_type, "pmi8998") == 0) {
+ qcom_usb_vbus_rdesc.curr_table = curr_table_pmi8998;
+ qcom_usb_vbus_rdesc.n_current_limits =
+ ARRAY_SIZE(curr_table_pmi8998);
+ } else if (pmic_type && strcmp(pmic_type, "pm8150b") == 0) {
+ qcom_usb_vbus_rdesc.curr_table = curr_table_pm8150b;
+ qcom_usb_vbus_rdesc.n_current_limits =
+ ARRAY_SIZE(curr_table_pm8150b);
+ } else {
+ return -ENODEV;
+ }
qcom_usb_vbus_rdesc.enable_reg = base + CMD_OTG;
qcom_usb_vbus_rdesc.enable_mask = OTG_EN;
qcom_usb_vbus_rdesc.csel_reg = base + OTG_CURRENT_LIMIT_CFG;
@@ -80,18 +99,22 @@ static int qcom_usb_vbus_regulator_probe(struct platform_device *pdev)
rdev = devm_regulator_register(dev, &qcom_usb_vbus_rdesc, &config);
if (IS_ERR(rdev)) {
ret = PTR_ERR(rdev);
- dev_err(dev, "not able to register vbus reg %d\n", ret);
+ dev_err(dev, "Failed to register vbus reg %d\n", ret);
return ret;
}
/* Disable HW logic for VBUS enable */
regmap_update_bits(regmap, base + OTG_CFG, OTG_EN_SRC_CFG, 0);
+ dev_info(dev, "Registered QCOM %s VBUS regulator\n",
+ pmic_type);
+
return 0;
}
static const struct of_device_id qcom_usb_vbus_regulator_match[] = {
- { .compatible = "qcom,pm8150b-vbus-reg" },
+ { .compatible = "qcom,pm8150b-vbus-reg", .data = "pm8150b" },
+ { .compatible = "qcom,pmi8998-vbus-reg", .data = "pmi8998" },
{ }
};
MODULE_DEVICE_TABLE(of, qcom_usb_vbus_regulator_match);
--
2.43.0
next prev parent reply other threads:[~2025-02-11 19:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 19:49 [PATCH 0/3] Add PMI8998 VBUS Regulator Support James A. MacInnes
2025-02-11 19:49 ` [PATCH 1/3] regulator: qcom_usb_vbus: Update DTS binding for PMI8998 support James A. MacInnes
2025-02-11 19:49 ` James A. MacInnes [this message]
2025-02-11 20:00 ` [PATCH 2/3] regulator: qcom_usb_vbus: Add support for PMI8998 VBUS Mark Brown
2025-02-11 23:16 ` Dmitry Baryshkov
2025-02-12 0:09 ` Mark Brown
2025-02-11 23:55 ` Bryan O'Donoghue
2025-02-11 19:49 ` [PATCH 3/3] arm64: boot: dts: pmi8998.dtsi: Add VBUS regulator James A. MacInnes
2025-02-11 23:32 ` Dmitry Baryshkov
-- strict thread matches above, loose matches on Subject: below --
2025-02-12 1:07 [PATCH 0/3] Add PMI8998 VBUS Regulator Support v2 James A. MacInnes
2025-02-12 1:07 ` [PATCH 2/3] regulator: qcom_usb_vbus: Add support for PMI8998 VBUS James A. MacInnes
2025-02-12 3:48 ` Dmitry Baryshkov
2025-02-12 12:55 ` Konrad Dybcio
2025-02-12 16:46 ` James A. MacInnes
2025-02-12 15:29 ` Caleb Connolly
2025-02-12 15:37 ` Mark Brown
2025-02-12 16:09 ` Caleb Connolly
2025-02-12 19:25 ` James A. MacInnes
2025-02-12 16:56 ` James A. MacInnes
2025-02-12 17:12 ` Caleb Connolly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250211194918.2517593-3-james.a.macinnes@gmail.com \
--to=james.a.macinnes@gmail.com \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_wcheng@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.