From: "James A. MacInnes" <james.a.macinnes@gmail.com>
To: linux-arm-msm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, robdclark@gmail.com,
quic_abhinavk@quicinc.com, dmitry.baryshkov@linaro.org,
sean@poorly.run, marijn.suijten@somainline.org,
airlied@gmail.com, simona@ffwll.ch,
"James A. MacInnes" <james.a.macinnes@gmail.com>
Subject: [PATCH 2/2] drm/msm/disp: Correct porch timing for SDM845
Date: Tue, 11 Feb 2025 19:42:25 -0800 [thread overview]
Message-ID: <20250212034225.2565069-3-james.a.macinnes@gmail.com> (raw)
In-Reply-To: <20250212034225.2565069-1-james.a.macinnes@gmail.com>
Type-C DisplayPort inop due to incorrect settings.
SDM845 (DPU 4.0) lacks wide_bus support; porch shift removed.
Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support")
Signed-off-by: James A. MacInnes <james.a.macinnes@gmail.com>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c
index abd6600046cb..3e0fef0955ce 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c
@@ -94,17 +94,17 @@ static void drm_mode_to_intf_timing_params(
timing->vsync_polarity = 0;
}
+ timing->wide_bus_en = dpu_encoder_is_widebus_enabled(phys_enc->parent);
+ timing->compression_en = dpu_encoder_is_dsc_enabled(phys_enc->parent);
+
/* for DP/EDP, Shift timings to align it to bottom right */
- if (phys_enc->hw_intf->cap->type == INTF_DP) {
+ if (phys_enc->hw_intf->cap->type == INTF_DP && timing->wide_bus_en) {
timing->h_back_porch += timing->h_front_porch;
timing->h_front_porch = 0;
timing->v_back_porch += timing->v_front_porch;
timing->v_front_porch = 0;
}
- timing->wide_bus_en = dpu_encoder_is_widebus_enabled(phys_enc->parent);
- timing->compression_en = dpu_encoder_is_dsc_enabled(phys_enc->parent);
-
/*
* for DP, divide the horizonal parameters by 2 when
* widebus is enabled
--
2.43.0
next prev parent reply other threads:[~2025-02-12 3:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 3:42 [PATCH 0/2] drm/msm/dp: Fix Type-C Timing James A. MacInnes
2025-02-12 3:42 ` [PATCH 1/2] drm/msm/dp: Disable wide bus support for SDM845 James A. MacInnes
2025-02-12 10:03 ` Marijn Suijten
2025-02-12 16:16 ` James A. MacInnes
2025-02-12 17:22 ` Marijn Suijten
2025-02-12 3:42 ` James A. MacInnes [this message]
2025-02-12 10:13 ` [PATCH 2/2] drm/msm/disp: Correct porch timing " Marijn Suijten
2025-02-12 16:23 ` James A. MacInnes
2025-02-12 17:15 ` Marijn Suijten
2025-02-12 19:56 ` James A. MacInnes
2025-02-12 11:20 ` [PATCH 0/2] drm/msm/dp: Fix Type-C Timing Dmitry Baryshkov
2025-02-12 16:34 ` James A. MacInnes
2025-02-12 17:24 ` Marijn Suijten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250212034225.2565069-3-james.a.macinnes@gmail.com \
--to=james.a.macinnes@gmail.com \
--cc=airlied@gmail.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.